From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH] vhost-user-input: use free(elem) instead of g_free(elem)
Date: Wed, 20 Nov 2019 07:04:43 -0500 [thread overview]
Message-ID: <20191120070222-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191120114132.GD242924@stefanha-x1.localdomain>
On Wed, Nov 20, 2019 at 11:41:32AM +0000, Stefan Hajnoczi wrote:
> On Wed, Nov 20, 2019 at 10:37:35AM +0100, Philippe Mathieu-Daudé wrote:
> > On 11/19/19 12:16 PM, Stefan Hajnoczi wrote:
> > > The virtqueue element returned by vu_queue_pop() is allocated using
> > > malloc(3) by virtqueue_alloc_element(). Use the matching free(3)
> > > function instead of glib's g_free().
> > >
> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> >
> > Fixes: 06914c97d3a ?
>
> Good idea, I should have included that.
>
> Stefan
I'd prefer keeping the Fixes tag to bugfixes as opposed to cleanups.
I.e. it should be a reasonable heuristic for people asking "do I need
this patch" to be able to answer based on whether they have the
linked patch.
--
MST
next prev parent reply other threads:[~2019-11-20 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 11:16 [PATCH] vhost-user-input: use free(elem) instead of g_free(elem) Stefan Hajnoczi
2019-11-19 11:52 ` Marc-André Lureau
2019-11-20 9:37 ` Philippe Mathieu-Daudé
2019-11-20 11:41 ` Stefan Hajnoczi
2019-11-20 12:04 ` Michael S. Tsirkin [this message]
2019-11-20 11:48 ` Daniel P. Berrangé
2019-11-21 13:51 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120070222-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=kraxel@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.