From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
brouer@redhat.com
Subject: Re: [PATCH net-next V3 1/3] page_pool: Add API to update numa node
Date: Wed, 20 Nov 2019 13:15:37 +0100 [thread overview]
Message-ID: <20191120131537.5481402e@carbon> (raw)
In-Reply-To: <20191120001456.11170-2-saeedm@mellanox.com>
On Wed, 20 Nov 2019 00:15:17 +0000
Saeed Mahameed <saeedm@mellanox.com> wrote:
> Add page_pool_update_nid() to be called by page pool consumers when they
> detect numa node changes.
>
> It will update the page pool nid value to start allocating from the new
> effective numa node.
>
> This is to mitigate page pool allocating pages from a wrong numa node,
> where the pool was originally allocated, and holding on to pages that
> belong to a different numa node, which causes performance degradation.
>
> For pages that are already being consumed and could be returned to the
> pool by the consumer, in next patch we will add a check per page to avoid
> recycling them back to the pool and return them to the page allocator.
>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-11-20 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 0:15 [PATCH net-next V3 0/3] page_pool: API for numa node change handling Saeed Mahameed
2019-11-20 0:15 ` [PATCH net-next V3 1/3] page_pool: Add API to update numa node Saeed Mahameed
2019-11-20 12:15 ` Jesper Dangaard Brouer [this message]
2019-11-20 0:15 ` [PATCH net-next V3 2/3] page_pool: Don't recycle non-reusable pages Saeed Mahameed
2019-11-20 12:16 ` Jesper Dangaard Brouer
2019-11-20 0:15 ` [PATCH net-next V3 3/3] net/mlx5e: Rx, Update page pool numa node when changed Saeed Mahameed
2019-11-20 12:16 ` Jesper Dangaard Brouer
2019-11-20 12:15 ` [PATCH net-next V3 0/3] page_pool: API for numa node change handling Jesper Dangaard Brouer
2019-11-20 19:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120131537.5481402e@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=jonathan.lemon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.