From: Florian Westphal <fw@strlen.de>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: "Pablo Neira Ayuso" <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org,
"Florian Westphal" <fw@strlen.de>,
"Kadlecsik József" <kadlec@blackhole.kfki.hu>,
"Eric Garver" <eric@garver.life>, "Phil Sutter" <phil@nwl.cc>,
"Sabrina Dubroca" <sd@queasysnail.net>,
"Jay Ligatti" <ligatti@usf.edu>,
"Ori Rottenstreich" <or@cs.technion.ac.il>,
"Kirill Kogan" <kirill.kogan@gmail.com>
Subject: Re: [PATCH nf-next 8/8] nft_set_pipapo: Introduce AVX2-based lookup implementation
Date: Wed, 20 Nov 2019 16:16:53 +0100 [thread overview]
Message-ID: <20191120151653.GD20235@breakpoint.cc> (raw)
In-Reply-To: <367e77e2a0097a0c1b715919b8d21f7a51a10429.1574119038.git.sbrivio@redhat.com>
Stefano Brivio <sbrivio@redhat.com> wrote:
> If the AVX2 set is available, we can exploit the repetitive
> characteristic of this algorithm to provide a fast, vectorised
> version by using 256-bit wide AVX2 operands for bucket loads and
> bitwise intersections.
>
> In most cases, this implementation consistently outperforms rbtree
> set instances despite the fact they are configured to use a given,
> single, ranged data type out of the ones used for performance
> measurements by the nft_concat_range.sh kselftest.
I think in that case it makes sense to remove rbtree once this new
set type has had some upstream exposure and let pipapo handle the
range sets.
Stefano, if I understand this right then we could figure out which
implementation (C or AVX) is used via "grep avx2 /proc/cpuinfo".
If not, I think we might want to expose some additional debug info
on set dumps.
next prev parent reply other threads:[~2019-11-20 15:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 1:06 [PATCH nf-next 0/8] nftables: Set implementation for arbitrary concatenation of ranges Stefano Brivio
2019-11-19 1:06 ` [PATCH nf-next 1/8] nf_tables: Support for subkeys, set with multiple ranged fields Stefano Brivio
2019-11-19 1:06 ` [PATCH nf-next 2/8] bitmap: Introduce bitmap_cut(): cut bits and shift remaining Stefano Brivio
2019-11-19 1:06 ` [PATCH nf-next 3/8] nf_tables: Add set type for arbitrary concatenation of ranges Stefano Brivio
2019-11-20 15:06 ` Florian Westphal
2019-11-21 19:54 ` Stefano Brivio
2019-11-21 20:41 ` Florian Westphal
2019-11-21 21:00 ` Stefano Brivio
2019-11-22 13:39 ` Stefano Brivio
2019-11-19 1:06 ` [PATCH nf-next 4/8] selftests: netfilter: Introduce tests for sets with range concatenation Stefano Brivio
2019-11-19 1:06 ` [PATCH nf-next 5/8] nft_set_pipapo: Provide unrolled lookup loops for common field sizes Stefano Brivio
2019-11-19 1:06 ` [PATCH nf-next 6/8] nft_set_pipapo: Prepare for vectorised implementation: alignment Stefano Brivio
2019-11-19 1:06 ` [PATCH nf-next 7/8] nft_set_pipapo: Prepare for vectorised implementation: helpers Stefano Brivio
2019-11-19 1:06 ` [PATCH nf-next 8/8] nft_set_pipapo: Introduce AVX2-based lookup implementation Stefano Brivio
2019-11-20 15:16 ` Florian Westphal [this message]
2019-11-20 16:08 ` Phil Sutter
2019-11-21 19:55 ` Stefano Brivio
2019-11-21 20:22 ` Pablo Neira Ayuso
2019-11-21 20:46 ` Florian Westphal
2019-11-21 20:54 ` Pablo Neira Ayuso
2019-11-21 20:56 ` Pablo Neira Ayuso
2019-11-21 20:51 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120151653.GD20235@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric@garver.life \
--cc=kadlec@blackhole.kfki.hu \
--cc=kirill.kogan@gmail.com \
--cc=ligatti@usf.edu \
--cc=netfilter-devel@vger.kernel.org \
--cc=or@cs.technion.ac.il \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=sbrivio@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.