From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-6359-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 62B5F985E7F for ; Wed, 20 Nov 2019 21:56:31 +0000 (UTC) Date: Wed, 20 Nov 2019 16:56:20 -0500 From: "Michael S. Tsirkin" Message-ID: <20191120165532-mutt-send-email-mst@kernel.org> References: <20191120151903.175110-1-jean-philippe@linaro.org> <20191120151903.175110-2-jean-philippe@linaro.org> <20191120182734.7d6ec586.cohuck@redhat.com> <20191120174451.GB89876@lophozonia> MIME-Version: 1.0 In-Reply-To: <20191120174451.GB89876@lophozonia> Subject: Re: [virtio-dev] [PATCH RESEND v4 1/1] Add virtio-iommu device specification Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline To: Jean-Philippe Brucker Cc: Cornelia Huck , virtio-dev@lists.oasis-open.org, joro@8bytes.org, tnowicki@marvell.com, eric.auger@redhat.com, kevin.tian@intel.com, lorenzo.pieralisi@arm.com, bauerman@linux.ibm.com List-ID: On Wed, Nov 20, 2019 at 06:44:51PM +0100, Jean-Philippe Brucker wrote: > On Wed, Nov 20, 2019 at 06:27:34PM +0100, Cornelia Huck wrote: > > > +\begin{lstlisting} > > > +struct virtio_iommu_config { > > > + le64 page_size_mask; > > > + struct virtio_iommu_range_64 { > > > + le64 start; > > > + le64 end; > > > + } input_range; > > > + struct virtio_iommu_range_32 { > > > + le32 start; > > > + le32 end; > > > + } domain_range; > > > + le32 probe_size; > > > +}; > > > +\end{lstlisting} > > > + > > > +\drivernormative{\subsubsection}{Device configuration layout}{Device= Types / IOMMU Device / Device configuration layout} > > > + > > > +The driver MUST NOT write to device configuration fields. > > > + > > > +\devicenormative{\subsubsection}{Device configuration layout}{Device= Types / IOMMU Device / Device configuration layout} > > > + > > > +The device SHOULD set \field{padding} to zero. > >=20 > > I don't see any field named 'padding' -- is that a leftover from an > > earlier version? >=20 > Oh right, it is. The previous version had an 1-byte field before > probe_size, so the structure needed 3 bytes of padding. Since we replaced > that field by domain_range in v4, padding is gone. >=20 > > If it is, we can probably remove it as a trivial change on top after > > this change went in. >=20 > I can also send a new version (after waiting a few days for other > comments), please let me know what you prefer. >=20 > Thanks, > Jean If we are re-doing review, we should withdraw the ballot for now. Pls let me know. --=20 MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org