All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Stefan Roese" <sr@denx.de>
Subject: Re: [PATCH] ARM: dts: omap3-tao3530: Fix incorrect MMC card detection GPIO polarity
Date: Wed, 20 Nov 2019 09:38:53 -0800	[thread overview]
Message-ID: <20191120173853.GS35479@atomide.com> (raw)
In-Reply-To: <20191116151651.7042-1-jarkko.nikula@bitmer.com>

* Jarkko Nikula <jarkko.nikula@bitmer.com> [191116 07:59]:
> The MMC card detection GPIO polarity is active low on TAO3530, like in many
> other similar boards. Now the card is not detected and it is unable to
> mount rootfs from an SD card.
> 
> Fix this by using the correct polarity.
> 
> This incorrect polarity was defined already in the commit 30d95c6d7092
> ("ARM: dts: omap3: Add Technexion TAO3530 SOM omap3-tao3530.dtsi") in v3.18
> kernel and later changed to use defined GPIO constants in v4.4 kernel by
> the commit 3a637e008e54 ("ARM: dts: Use defined GPIO constants in flags
> cell for OMAP2+ boards").
> 
> While the latter commit did not introduce the issue I'm marking it with
> Fixes tag due the v4.4 kernels still being maintained.

Thanks applying into omap-for-v5.5/dt.

Tony

  reply	other threads:[~2019-11-20 17:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-16 15:16 [PATCH] ARM: dts: omap3-tao3530: Fix incorrect MMC card detection GPIO polarity Jarkko Nikula
2019-11-20 17:38 ` Tony Lindgren [this message]
     [not found] ` <20191125111125.AF5D720836@mail.kernel.org>
2019-11-25 18:27   ` Jarkko Nikula
2019-12-15 11:12     ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120173853.GS35479@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.