From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: sfp: add some quirks for GPON modules
Date: Thu, 21 Nov 2019 00:03:28 +0000 [thread overview]
Message-ID: <20191121000328.GX25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20191120144632.0658d920@cakuba.netronome.com>
On Wed, Nov 20, 2019 at 02:46:32PM -0800, Jakub Kicinski wrote:
> On Wed, 20 Nov 2019 11:42:47 +0000, Russell King wrote:
> > static const struct sfp_quirk sfp_quirks[] = {
> > + {
> > + // Alcatel Lucent G-010S-P can operate at 2500base-X, but
> > + // incorrectly report 2500MBd NRZ in their EEPROM
> > + .vendor = "ALCATELLUCENT",
> > + .part = "G010SP",
> > + .modes = sfp_quirk_2500basex,
> > + }, {
> > + // Alcatel Lucent G-010S-A can operate at 2500base-X, but
> > + // report 3.2GBd NRZ in their EEPROM
> > + .vendor = "ALCATELLUCENT",
> > + .part = "3FE46541AA",
> > + .modes = sfp_quirk_2500basex,
> > + }, {
> > + // Huawei MA5671A can operate at 2500base-X, but report 1.2GBd
> > + // NRZ in their EEPROM
> > + .vendor = "HUAWEI",
> > + .part = "MA5671A",
> > + .modes = sfp_quirk_2500basex,
> > + },
> > };
>
> nit: no C++ comment style?
Did you read Linus' opinions on commentry style during the discussion
over the SPDX tags?
https://lkml.org/lkml/2017/11/2/715
https://lkml.org/lkml/2017/11/25/133
It seems that Linus has decided to prefer // over /* */
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-11-21 0:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 11:39 [PATCH net-next 0/2] Add rudimentary SFP module quirk support Russell King - ARM Linux admin
2019-11-20 11:42 ` [PATCH net-next 1/2] net: sfp: add support for module quirks Russell King
2019-11-21 2:24 ` Andrew Lunn
2019-11-21 9:11 ` Russell King - ARM Linux admin
2019-11-21 3:46 ` Florian Fainelli
2019-11-20 11:42 ` [PATCH net-next 2/2] net: sfp: add some quirks for GPON modules Russell King
2019-11-20 22:46 ` Jakub Kicinski
2019-11-21 0:03 ` Russell King - ARM Linux admin [this message]
2019-11-21 0:14 ` Jakub Kicinski
2019-11-21 2:26 ` Andrew Lunn
2019-11-21 3:46 ` Florian Fainelli
2019-11-21 2:28 ` [PATCH net-next 0/2] Add rudimentary SFP module quirk support Andrew Lunn
2019-11-21 6:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121000328.GX25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.