Re: [Xen-devel] [PATCH v5 00/12] livepatch: new features and fixes

From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Wieczorkiewicz, Pawel" <wipawel@amazon.de>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
	"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
	"George Dunlap" <George.Dunlap@eu.citrix.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Ian Jackson" <ian.jackson@eu.citrix.com>,
	"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
	"Pohlack, Martin" <mpohlack@amazon.de>,
	"Ross Lagerwall" <ross.lagerwall@citrix.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH v5 00/12] livepatch: new features and fixes
Date: Wed, 20 Nov 2019 20:09:59 -0500	[thread overview]
Message-ID: <20191121010959.GA10410@char.us.oracle.com> (raw)
In-Reply-To: <7F0CE196-9FE7-43B9-B311-6EA0647338A4@amazon.com>

> Yes, this hunk is missing (somehow it did not make it to the v5 patchset, sorry):
> 
> diff --git a/tools/libxc/xc_misc.c b/tools/libxc/xc_misc.c
> index 7747ea83aa..0b21a6aca4 100644
> --- a/tools/libxc/xc_misc.c
> +++ b/tools/libxc/xc_misc.c
> @@ -976,6 +976,7 @@ static int _xc_livepatch_action(xc_interface *xch,
>      sysctl.u.livepatch.u.action.cmd = action;
>      sysctl.u.livepatch.u.action.timeout = timeout;
>      sysctl.u.livepatch.u.action.flags = flags;
> +    sysctl.u.livepatch.u.action.pad = 0;
> 
>      sysctl.u.livepatch.u.action.name = def_name;
>      set_xen_guest_handle(sysctl.u.livepatch.u.action.name.name, name);

That did it! With that I can test the livepatches on ARM[32,64].

Let me squash that in "livepatch: Allow to override inter-modules buildid dependency"

See:
https://github.com/konradwilk/xen.git  #livepatch.aws.v5

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel