All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: netdev@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	"David S . Miller" <davem@davemloft.net>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 5/5] net: dsa: ocelot: add hardware timestamping support for Felix
Date: Thu, 21 Nov 2019 03:56:10 +0100	[thread overview]
Message-ID: <20191121025610.GO18325@lunn.ch> (raw)
In-Reply-To: <20191120082318.3909-6-yangbo.lu@nxp.com>

> +static irqreturn_t felix_irq_handler(int irq, void *data)
> +{
> +	struct ocelot *ocelot = (struct ocelot *)data;
> +
> +	/* The INTB interrupt is used for both PTP TX timestamp interrupt
> +	 * and preemption status change interrupt on each port.
> +	 *
> +	 * - Get txtstamp if have
> +	 * - TODO: handle preemption. Without handling it, driver may get
> +	 *   interrupt storm.
> +	 */

I assume there are no register bits to enable/disable these two
interrupt sources?

What is preemption?

     Andrew

  reply	other threads:[~2019-11-21  2:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  8:23 [PATCH 0/5] Support PTP clock and hardware timestamping for DSA Felix driver Yangbo Lu
2019-11-20  8:23 ` [PATCH 1/5] net: mscc: ocelot: export ocelot_hwstamp_get/set functions Yangbo Lu
2019-11-21  2:40   ` Andrew Lunn
2019-11-21  4:03   ` Florian Fainelli
2019-11-20  8:23 ` [PATCH 2/5] net: mscc: ocelot: convert to use ocelot_get_txtstamp() Yangbo Lu
2019-11-21  2:41   ` Andrew Lunn
2019-11-21  4:04   ` Florian Fainelli
2019-11-20  8:23 ` [PATCH 3/5] net: mscc: ocelot: convert to use ocelot_port_add_txtstamp_skb() Yangbo Lu
2019-11-21  2:43   ` Andrew Lunn
2019-11-21  4:04   ` Florian Fainelli
2019-11-20  8:23 ` [PATCH 4/5] net: dsa: ocelot: define PTP registers for felix_vsc9959 Yangbo Lu
2019-11-21  2:49   ` Andrew Lunn
2019-11-21  3:20     ` Y.b. Lu
2019-11-21  4:04   ` Florian Fainelli
2019-11-20  8:23 ` [PATCH 5/5] net: dsa: ocelot: add hardware timestamping support for Felix Yangbo Lu
2019-11-21  2:56   ` Andrew Lunn [this message]
2019-11-21  3:29     ` Y.b. Lu
2019-11-21 22:39 ` [PATCH 0/5] Support PTP clock and hardware timestamping for DSA Felix driver David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191121025610.GO18325@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=vivien.didelot@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.