Re: [PATCH V3 0/2] nvme-pci: check CQ after batch submission for Microsoft device

[Ming Lei <ming.lei@redhat.com>]

On Thu, Nov 14, 2019 at 10:59:15AM +0800, Ming Lei wrote:
> Hi,
> 
> The two patches fix one performance regression on Microsoft Corporation device. The
> root cause is that Microsoft device applies aggressive interrupt coalescing, so
> single job fio performance drops much after we removes checking cq in
> f9dde187fa92("nvme-pci: remove cq check after submission").
> 
> Turns out this issue is very specific on Microsoft device, so add
> a quirk for checking CQ on this device.
> 
> V3:
> 	- replace spin_trylock_irqsave with spin_trylock_irq
> 	- fix comment on cq_lock & cq_poll_lock
> 
> V2:
> 	- only check CQ for Microsoft device.
> 
> 
> 
> Ming Lei (2):
>   nvme-pci: move sq/cq_poll lock initialization into nvme_init_queue
>   nvme-pci: check CQ after batch submission for Microsoft device
> 
>  drivers/nvme/host/nvme.h |  6 +++
>  drivers/nvme/host/pci.c  | 98 ++++++++++++++++++++++++++++++++++------
>  2 files changed, 90 insertions(+), 14 deletions(-)
> 
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Long Li <longli@microsoft.com>
> -- 
> 2.20.1
> 

Hi Guys,

Ping...

Thanks,
Ming


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme