From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mbuf: display more fields in dump
Date: Thu, 21 Nov 2019 08:43:17 -0800 [thread overview]
Message-ID: <20191121084317.169ea71e@hermes.lan> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C60C1B@smartserver.smartshare.dk>
On Thu, 21 Nov 2019 17:16:42 +0100
Morten Brørup <mb@smartsharesystems.com> wrote:
> Are all these explicit type casts really needed? buf_iova is already uint64_t, buflen is uint16_t, data_off is uint16_t, rte_mbuf_refcnt_read() returns uint16_t, pkt_len is uint32_t, nb_segs is uint16_t, port is uint16_t, vlan_tci is uint16_t.
Normally, they are not needed.
If you turn up some of the warning levels in Gcc, then yes.
>
> m->port is not only the input port anymore (ref. the mbuf documentation), so please change in_port=%u to port=%u.
Makes sense, but since this in internal would rather keep existing
to print the name of the field.
>
> For consistency with ol_flags and vlan_tci format, consider changing iova=% to iova=%#.
good idea, personal preference is to always use %#x over %x
next prev parent reply other threads:[~2019-11-21 16:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 17:41 [dpdk-dev] [PATCH] mbuf: display more fields in dump Stephen Hemminger
2019-11-21 16:16 ` Morten Brørup
2019-11-21 16:43 ` Stephen Hemminger [this message]
2019-11-21 18:30 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2019-11-22 12:31 ` Andrew Rybchenko
2019-12-26 16:15 ` Olivier Matz
2019-12-26 16:58 ` Stephen Hemminger
2019-12-27 9:10 ` Olivier Matz
2019-12-27 17:05 ` Stephen Hemminger
2019-12-30 8:11 ` Olivier Matz
2020-01-22 17:39 ` [dpdk-dev] [PATCH v3] " Stephen Hemminger
2020-02-06 9:48 ` Olivier Matz
2020-02-06 14:32 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2019-11-21 17:04 [dpdk-dev] [PATCH] " Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121084317.169ea71e@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.