Re: [virtio-dev] [PATCH RESEND v4 1/1] Add virtio-iommu device specification

[Cornelia Huck <cohuck@redhat.com>]

On Wed, 20 Nov 2019 18:44:51 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:

> On Wed, Nov 20, 2019 at 06:27:34PM +0100, Cornelia Huck wrote:
> > > +\begin{lstlisting}
> > > +struct virtio_iommu_config {
> > > +  le64 page_size_mask;
> > > +  struct virtio_iommu_range_64 {
> > > +    le64 start;
> > > +    le64 end;
> > > +  } input_range;
> > > +  struct virtio_iommu_range_32 {
> > > +    le32 start;
> > > +    le32 end;
> > > +  } domain_range;
> > > +  le32 probe_size;
> > > +};
> > > +\end{lstlisting}
> > > +
> > > +\drivernormative{\subsubsection}{Device configuration layout}{Device Types / IOMMU Device / Device configuration layout}
> > > +
> > > +The driver MUST NOT write to device configuration fields.
> > > +
> > > +\devicenormative{\subsubsection}{Device configuration layout}{Device Types / IOMMU Device / Device configuration layout}
> > > +
> > > +The device SHOULD set \field{padding} to zero.  
> > 
> > I don't see any field named 'padding' -- is that a leftover from an
> > earlier version?  
> 
> Oh right, it is. The previous version had an 1-byte field before
> probe_size, so the structure needed 3 bytes of padding. Since we replaced
> that field by domain_range in v4, padding is gone.
> 
> > If it is, we can probably remove it as a trivial change on top after
> > this change went in.  
> 
> I can also send a new version (after waiting a few days for other
> comments), please let me know what you prefer.

If nothing else turns up (I didn't spot anything), I think we can just
remove this sentence on top, no need to restart the voting IMHO.


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org