From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FBA3C432C3 for ; Thu, 21 Nov 2019 13:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BF3020409 for ; Thu, 21 Nov 2019 13:35:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726546AbfKUNf4 (ORCPT ); Thu, 21 Nov 2019 08:35:56 -0500 Received: from orbyte.nwl.cc ([151.80.46.58]:41232 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbfKUNf4 (ORCPT ); Thu, 21 Nov 2019 08:35:56 -0500 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1iXmck-0003Po-8b; Thu, 21 Nov 2019 14:35:54 +0100 Date: Thu, 21 Nov 2019 14:35:54 +0100 From: Phil Sutter To: Michal Rostecki Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] mnl: Fix -Wimplicit-function-declaration warnings Message-ID: <20191121133554.GA3074@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Michal Rostecki , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20191121123332.5245-1-mrostecki@opensuse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191121123332.5245-1-mrostecki@opensuse.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Nov 21, 2019 at 01:33:32PM +0100, Michal Rostecki wrote: > This change fixes the following warnings: > > mnl.c: In function ‘mnl_nft_flowtable_add’: > mnl.c:1442:14: warning: implicit declaration of function ‘calloc’ [-Wimplicit-function-declaration] > dev_array = calloc(len, sizeof(char *)); > ^~~~~~ > mnl.c:1442:14: warning: incompatible implicit declaration of built-in function ‘calloc’ > mnl.c:1442:14: note: include ‘’ or provide a declaration of ‘calloc’ > mnl.c:1449:2: warning: implicit declaration of function ‘free’ [-Wimplicit-function-declaration] > free(dev_array); > ^~~~ > mnl.c:1449:2: warning: incompatible implicit declaration of built-in function ‘free’ > mnl.c:1449:2: note: include ‘’ or provide a declaration of ‘free’ > > Signed-off-by: Michal Rostecki Fixes: 1698fca7d49ff ("mnl: remove artifical cap on 8 devices per flowtable") Acked-by: Phil Sutter