From: Greg KH <greg@kroah.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, jikos@kernel.org,
benjamin.tissoires@redhat.com, dmitry.torokhov@gmail.com,
Jes.Sorensen@gmail.com, kvalo@codeaurora.org, johan@kernel.org,
linux-input@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] drivers: usb: consolidate USB vendor IDs in one include file
Date: Thu, 21 Nov 2019 17:33:09 +0100 [thread overview]
Message-ID: <20191121163309.GA651886@kroah.com> (raw)
In-Reply-To: <20191121161742.31435-1-info@metux.net>
On Thu, Nov 21, 2019 at 05:17:42PM +0100, Enrico Weigelt, metux IT consult wrote:
> Instead of redefining usb vendor IDs in several places, consolidate
> into one include file: include/linux/usb/usb_ids.h
No, please no.
There's a specific reason we do not have this, unlike other operating
systems. It's because merges are a pain, and touching the "big one
file" ends up rebuilding too many things.
Read the top of the pci-ids.h file for why I do not want to see us do
this for any other type of id. It's best to leave them where they are
used, right in the driver itself.
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-21 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 16:17 [PATCH] drivers: usb: consolidate USB vendor IDs in one include file Enrico Weigelt, metux IT consult
2019-11-21 16:33 ` Greg KH [this message]
2019-11-21 16:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121163309.GA651886@kroah.com \
--to=greg@kroah.com \
--cc=Jes.Sorensen@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=info@metux.net \
--cc=jikos@kernel.org \
--cc=johan@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.