From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-comment-return-930-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 7B8AF985EA4 for ; Thu, 21 Nov 2019 22:10:09 +0000 (UTC) Date: Thu, 21 Nov 2019 17:10:01 -0500 From: "Michael S. Tsirkin" Message-ID: <20191121170926-mutt-send-email-mst@kernel.org> References: <20191120132359.6626-1-cohuck@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191120132359.6626-1-cohuck@redhat.com> Subject: [virtio-comment] Re: [PATCH v2] virtio-net: add missing articles for new hdr_len feature Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline To: Cornelia Huck Cc: virtio-comment@lists.oasis-open.org, Vitaly Mireyno , Jason Wang , Stefan Hajnoczi List-ID: On Wed, Nov 20, 2019 at 02:23:59PM +0100, Cornelia Huck wrote: > And tweak a sentence slightly. >=20 > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Cornelia Huck Thanks! Can you pls add a link to this as a comment to the hdr_len github issue? This way I will remember to pick it up. > --- >=20 > v1->v2: > - add one more tweak [Stefan] >=20 > Note: I have not added definite articles to the feature description; _all= _ > features for virtio-net are described in that way, and we should add them > in one go should we decide to change that. >=20 > --- > content.tex | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/content.tex b/content.tex > index 5d3f865956aa..fc59eea95716 100644 > --- a/content.tex > +++ b/content.tex > @@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Devic= e Types / Network Device / De > \begin{itemize} > \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated, > \field{hdr_len} indicates the header length that needs to be replica= ted > - for each packet. It's a number of bytes from beginning of the packet > - to beginning of the transport payload. > + for each packet. It's the number of bytes from the beginning of the = packet > + to the beginning of the transport payload. > Otherwise, if the VIRTIO_NET_F_GUEST_HDRLEN feature has not been neg= otiated, > \field{hdr_len} is a hint to the device as to how much of the header > needs to be kept to copy into each packet, usually set to the > @@ -3217,7 +3217,7 @@ \subsubsection{Packet Transmission}\label{sec:Devic= e Types / Network Device / De > =20 > =09\begin{note} > =09Caution should be taken by the implementation so as to prevent > -=09malicious driver from attacking the device by setting incorrect hdr_l= en. > +=09a malicious driver from attacking the device by setting an incorrect = hdr_len. > =09\end{note} > =20 > \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated, > --=20 > 2.21.0 This publicly archived list offers a means to provide input to the=0D OASIS Virtual I/O Device (VIRTIO) TC.=0D =0D In order to verify user consent to the Feedback License terms and=0D to minimize spam in the list archive, subscription is required=0D before posting.=0D =0D Subscribe: virtio-comment-subscribe@lists.oasis-open.org=0D Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org=0D List help: virtio-comment-help@lists.oasis-open.org=0D List archive: https://lists.oasis-open.org/archives/virtio-comment/=0D Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf= =0D List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lis= ts=0D Committee: https://www.oasis-open.org/committees/virtio/=0D Join OASIS: https://www.oasis-open.org/join/