From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22D2C432C0 for ; Thu, 21 Nov 2019 18:13:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8270D2068F for ; Thu, 21 Nov 2019 18:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbfKUSNz (ORCPT ); Thu, 21 Nov 2019 13:13:55 -0500 Received: from muru.com ([72.249.23.125]:43184 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbfKUSNz (ORCPT ); Thu, 21 Nov 2019 13:13:55 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1541880DB; Thu, 21 Nov 2019 18:14:30 +0000 (UTC) Date: Thu, 21 Nov 2019 10:13:50 -0800 From: Tony Lindgren To: Jean-Jacques Hiblot Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, sre@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, lee.jones@linaro.org, daniel.thompson@linaro.org, dmurphy@ti.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com Subject: Re: [PATCH v10 6/6] backlight: add led-backlight driver Message-ID: <20191121181350.GN43123@atomide.com> References: <20191009085127.22843-1-jjhiblot@ti.com> <20191009085127.22843-7-jjhiblot@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009085127.22843-7-jjhiblot@ti.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi, * Jean-Jacques Hiblot [700101 00:00]: > From: Tomi Valkeinen > > This patch adds a led-backlight driver (led_bl), which is similar to > pwm_bl except the driver uses a LED class driver to adjust the > brightness in the HW. Multiple LEDs can be used for a single backlight. ... > + ret = of_property_read_u32(node, "default-brightness", &value); > + if (!ret && value <= priv->max_brightness) > + priv->default_brightness = value; > + else if (!ret && value > priv->max_brightness) > + dev_warn(dev, "Invalid default brightness. Ignoring it\n"); Hmm so just wondering.. Are we using "default-brightness" instead of the usual "default-brightness-level" here? Please Cc me on the next patchset too :) Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C972DC432C0 for ; Fri, 22 Nov 2019 09:01:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA44220708 for ; Fri, 22 Nov 2019 09:01:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA44220708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5946D6F4FE; Fri, 22 Nov 2019 09:01:24 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id C3E546E1E8 for ; Thu, 21 Nov 2019 18:13:55 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1541880DB; Thu, 21 Nov 2019 18:14:30 +0000 (UTC) Date: Thu, 21 Nov 2019 10:13:50 -0800 From: Tony Lindgren To: Jean-Jacques Hiblot Subject: Re: [PATCH v10 6/6] backlight: add led-backlight driver Message-ID: <20191121181350.GN43123@atomide.com> References: <20191009085127.22843-1-jjhiblot@ti.com> <20191009085127.22843-7-jjhiblot@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191009085127.22843-7-jjhiblot@ti.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Approved-At: Fri, 22 Nov 2019 09:00:44 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, daniel.thompson@linaro.org, tomi.valkeinen@ti.com, sre@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, lee.jones@linaro.org, linux-leds@vger.kernel.org, dmurphy@ti.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191121181350.MLPla-geTAb3TP1AG2ybT0GwBRw03atAvQgcorweT2M@z> SGksCgoqIEplYW4tSmFjcXVlcyBIaWJsb3QgPGpqaGlibG90QHRpLmNvbT4gWzcwMDEwMSAwMDow MF06Cj4gRnJvbTogVG9taSBWYWxrZWluZW4gPHRvbWkudmFsa2VpbmVuQHRpLmNvbT4KPiAKPiBU aGlzIHBhdGNoIGFkZHMgYSBsZWQtYmFja2xpZ2h0IGRyaXZlciAobGVkX2JsKSwgd2hpY2ggaXMg c2ltaWxhciB0bwo+IHB3bV9ibCBleGNlcHQgdGhlIGRyaXZlciB1c2VzIGEgTEVEIGNsYXNzIGRy aXZlciB0byBhZGp1c3QgdGhlCj4gYnJpZ2h0bmVzcyBpbiB0aGUgSFcuIE11bHRpcGxlIExFRHMg Y2FuIGJlIHVzZWQgZm9yIGEgc2luZ2xlIGJhY2tsaWdodC4KLi4uCgo+ICsJcmV0ID0gb2ZfcHJv cGVydHlfcmVhZF91MzIobm9kZSwgImRlZmF1bHQtYnJpZ2h0bmVzcyIsICZ2YWx1ZSk7Cj4gKwlp ZiAoIXJldCAmJiB2YWx1ZSA8PSBwcml2LT5tYXhfYnJpZ2h0bmVzcykKPiArCQlwcml2LT5kZWZh dWx0X2JyaWdodG5lc3MgPSB2YWx1ZTsKPiArCWVsc2UgaWYgKCFyZXQgICYmIHZhbHVlID4gcHJp di0+bWF4X2JyaWdodG5lc3MpCj4gKwkJZGV2X3dhcm4oZGV2LCAiSW52YWxpZCBkZWZhdWx0IGJy aWdodG5lc3MuIElnbm9yaW5nIGl0XG4iKTsKCkhtbSBzbyBqdXN0IHdvbmRlcmluZy4uIEFyZSB3 ZSB1c2luZyAiZGVmYXVsdC1icmlnaHRuZXNzIiBpbnN0ZWFkIG9mIHRoZQp1c3VhbCAiZGVmYXVs dC1icmlnaHRuZXNzLWxldmVsIiBoZXJlPwoKUGxlYXNlIENjIG1lIG9uIHRoZSBuZXh0IHBhdGNo c2V0IHRvbyA6KQoKUmVnYXJkcywKClRvbnkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVs