All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>, eric.saint.etienne@oracle.com
Subject: Re: [PATCH] tune2fs: prohibit toggling uninit_bg on live filesystems
Date: Thu, 21 Nov 2019 13:22:40 -0500	[thread overview]
Message-ID: <20191121182240.GJ4262@mit.edu> (raw)
In-Reply-To: <20191120193255.GF6213@magnolia>

On Wed, Nov 20, 2019 at 11:32:55AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> An internal customer followed an erroneous AskUbuntu article[1] to try to
> change the UUID of a live ext4 filesystem.  The article claims that you
> can work around tune2fs' "cannot change UUID on live fs" error by
> disabling uninit_bg, changing the UUID, and re-enabling the feature.
> 
> This led to metadata corruption because tune2fs' journal descriptor
> rewrite races with regular filesystem writes.  Therefore, prevent
> administrators from turning on or off uninit_bg on a mounted fs.
> 
> [1] https://askubuntu.com/questions/132079/how-do-i-change-uuid-of-a-disk-to-whatever-i-want/195839#459097
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Thanks, applied.

					- Ted

      reply	other threads:[~2019-11-21 18:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 19:32 [PATCH] tune2fs: prohibit toggling uninit_bg on live filesystems Darrick J. Wong
2019-11-21 18:22 ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191121182240.GJ4262@mit.edu \
    --to=tytso@mit.edu \
    --cc=darrick.wong@oracle.com \
    --cc=eric.saint.etienne@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.