diff for duplicates of <20191122060129.4239-83-sashal@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 82c7c23..718a07f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -10,7 +10,7 @@ Function sctp_transport_reset_hb_timer has two roles: - update expire date of hb_timer for a given transport. The function is optimized to update timer's expire only if it is before a new calculated one but this comparison is invalid for a timer which -has not yet started. Such a timer has expire = 0 and if a new expire +has not yet started. Such a timer has expire == 0 and if a new expire value is bigger than (MAX_JIFFIES / 2 + 2) then "time_before" macro will fail and timer will not start resulting in no heartbeat packets send by the node. @@ -21,7 +21,7 @@ after system boot due to jiffies init value which is near to MAX_JIFFIES. Test kernel version: 4.9.154 (ARCH=arm) hb_timer.expire = 0; //initialized, not started timer new_expire = MAX_JIFFIES / 2 + 2; //or more -time_before(hb_timer.expire, new_expire) = false +time_before(hb_timer.expire, new_expire) == false Fixes: ba6f5e33bdbb ("sctp: avoid refreshing heartbeat timer too often") Reported-by: Marcin Stojek <marcin.stojek@nokia.com> diff --git a/a/content_digest b/N1/content_digest index 6a4f11c..e014d59 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020191122060129.4239-1-sashal@kernel.org\0" "From\0Sasha Levin <sashal@kernel.org>\0" "Subject\0[PATCH AUTOSEL 4.9 84/91] sctp: don't compare hb_timer expire date before starting it\0" - "Date\0Fri, 22 Nov 2019 06:01:22 +0000\0" + "Date\0Fri, 22 Nov 2019 01:01:22 -0500\0" "To\0linux-kernel@vger.kernel.org" " stable@vger.kernel.org\0" "Cc\0Maciej Kwiecien <maciej.kwiecien@nokia.com>" @@ -26,7 +26,7 @@ " - update expire date of hb_timer for a given transport.\n" "The function is optimized to update timer's expire only if it is before\n" "a new calculated one but this comparison is invalid for a timer which\n" - "has not yet started. Such a timer has expire = 0 and if a new expire\n" + "has not yet started. Such a timer has expire == 0 and if a new expire\n" "value is bigger than (MAX_JIFFIES / 2 + 2) then \"time_before\" macro will\n" "fail and timer will not start resulting in no heartbeat packets send by\n" "the node.\n" @@ -37,7 +37,7 @@ "Test kernel version: 4.9.154 (ARCH=arm)\n" "hb_timer.expire = 0; //initialized, not started timer\n" "new_expire = MAX_JIFFIES / 2 + 2; //or more\n" - "time_before(hb_timer.expire, new_expire) = false\n" + "time_before(hb_timer.expire, new_expire) == false\n" "\n" "Fixes: ba6f5e33bdbb (\"sctp: avoid refreshing heartbeat timer too often\")\n" "Reported-by: Marcin Stojek <marcin.stojek@nokia.com>\n" @@ -68,4 +68,4 @@ "-- \n" 2.20.1 -0a3fc57863870600830e19190423b0e161c972347f9c18c8295405307fb443da +f5384065be2858bba2f3aae237d4bf69daabf2eb216df320b69c4640fdfa61e4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.