From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: andrew@lunn.ch, nbd@openwrt.org, sean.wang@mediatek.com,
alexandre.torgue@st.com, netdev@vger.kernel.org,
peppe.cavallaro@st.com, radhey.shyam.pandey@xilinx.com,
michal.simek@xilinx.com, mcoquelin.stm32@gmail.com,
linux-stm32@st-md-mailman.stormreply.com, joabreu@synopsys.com,
linux-mediatek@lists.infradead.org, thomas.petazzoni@bootlin.com,
john@phrozen.org, matthias.bgg@gmail.com,
vivien.didelot@gmail.com, hkallweit1@gmail.com,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org, Mark-MC.Lee@mediatek.com
Subject: Re: [CFT PATCH net-next v2] net: phylink: rename mac_link_state() op to mac_pcs_get_state()
Date: Fri, 22 Nov 2019 09:21:37 +0000 [thread overview]
Message-ID: <20191122092136.GJ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <0a9e016b-4ee3-1f1c-0222-74180f130e6c@gmail.com>
On Thu, Nov 21, 2019 at 07:36:44PM -0800, Florian Fainelli wrote:
>
>
> On 11/21/2019 7:14 PM, David Miller wrote:
> > From: Russell King <rmk+kernel@armlinux.org.uk>
> > Date: Thu, 21 Nov 2019 00:36:22 +0000
> >
> >> Rename the mac_link_state() method to mac_pcs_get_state() to make it
> >> clear that it should be returning the MACs PCS current state, which
> >> is used for inband negotiation rather than just reading back what the
> >> MAC has been configured for. Update the documentation to explicitly
> >> mention that this is for inband.
> >>
> >> We drop the return value as well; most of phylink doesn't check the
> >> return value and it is not clear what it should do on error - instead
> >> arrange for state->link to be false.
> >>
> >> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> >> ---
> >> This is something I'd like to do to make it clearer what phylink
> >> expects of this function, and that it shouldn't just read-back how
> >> the MAC was configured.
> >>
> >> This version drops the deeper changes, concentrating just on the
> >> phylink API rather than delving deeper into drivers, as I haven't
> >> received any feedback on that patch.
> >>
> >> It would be nice to see all these drivers tested with this change.
> >
> > I'm tempted to just apply this, any objections?
> >
>
> Russell, which of this patch or: http://patchwork.ozlabs.org/patch/1197425/
>
> would you consider worthy of merging?
Let's go with v2 for now - it gets the rename done with less risk that
there'll be a problem. I can always do the remainder in a separate
patch after the merge window as a separate patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: andrew@lunn.ch, nbd@openwrt.org, sean.wang@mediatek.com,
alexandre.torgue@st.com, netdev@vger.kernel.org,
peppe.cavallaro@st.com, radhey.shyam.pandey@xilinx.com,
michal.simek@xilinx.com, mcoquelin.stm32@gmail.com,
linux-stm32@st-md-mailman.stormreply.com, joabreu@synopsys.com,
linux-mediatek@lists.infradead.org, thomas.petazzoni@bootlin.com,
john@phrozen.org, matthias.bgg@gmail.com,
vivien.didelot@gmail.com, hkallweit1@gmail.com,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org, Mark-MC.Lee@mediatek.com
Subject: Re: [CFT PATCH net-next v2] net: phylink: rename mac_link_state() op to mac_pcs_get_state()
Date: Fri, 22 Nov 2019 09:21:37 +0000 [thread overview]
Message-ID: <20191122092136.GJ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <0a9e016b-4ee3-1f1c-0222-74180f130e6c@gmail.com>
On Thu, Nov 21, 2019 at 07:36:44PM -0800, Florian Fainelli wrote:
>
>
> On 11/21/2019 7:14 PM, David Miller wrote:
> > From: Russell King <rmk+kernel@armlinux.org.uk>
> > Date: Thu, 21 Nov 2019 00:36:22 +0000
> >
> >> Rename the mac_link_state() method to mac_pcs_get_state() to make it
> >> clear that it should be returning the MACs PCS current state, which
> >> is used for inband negotiation rather than just reading back what the
> >> MAC has been configured for. Update the documentation to explicitly
> >> mention that this is for inband.
> >>
> >> We drop the return value as well; most of phylink doesn't check the
> >> return value and it is not clear what it should do on error - instead
> >> arrange for state->link to be false.
> >>
> >> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> >> ---
> >> This is something I'd like to do to make it clearer what phylink
> >> expects of this function, and that it shouldn't just read-back how
> >> the MAC was configured.
> >>
> >> This version drops the deeper changes, concentrating just on the
> >> phylink API rather than delving deeper into drivers, as I haven't
> >> received any feedback on that patch.
> >>
> >> It would be nice to see all these drivers tested with this change.
> >
> > I'm tempted to just apply this, any objections?
> >
>
> Russell, which of this patch or: http://patchwork.ozlabs.org/patch/1197425/
>
> would you consider worthy of merging?
Let's go with v2 for now - it gets the rename done with less risk that
there'll be a problem. I can always do the remainder in a separate
patch after the merge window as a separate patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: David Miller <davem@davemloft.net>,
andrew@lunn.ch, nbd@openwrt.org, radhey.shyam.pandey@xilinx.com,
alexandre.torgue@st.com, netdev@vger.kernel.org,
sean.wang@mediatek.com, linux-stm32@st-md-mailman.stormreply.com,
vivien.didelot@gmail.com, michal.simek@xilinx.com,
joabreu@synopsys.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@bootlin.com, john@phrozen.org,
matthias.bgg@gmail.com, peppe.cavallaro@st.com,
Mark-MC.Lee@mediatek.com, mcoquelin.stm32@gmail.com,
hkallweit1@gmail.com
Subject: Re: [CFT PATCH net-next v2] net: phylink: rename mac_link_state() op to mac_pcs_get_state()
Date: Fri, 22 Nov 2019 09:21:37 +0000 [thread overview]
Message-ID: <20191122092136.GJ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <0a9e016b-4ee3-1f1c-0222-74180f130e6c@gmail.com>
On Thu, Nov 21, 2019 at 07:36:44PM -0800, Florian Fainelli wrote:
>
>
> On 11/21/2019 7:14 PM, David Miller wrote:
> > From: Russell King <rmk+kernel@armlinux.org.uk>
> > Date: Thu, 21 Nov 2019 00:36:22 +0000
> >
> >> Rename the mac_link_state() method to mac_pcs_get_state() to make it
> >> clear that it should be returning the MACs PCS current state, which
> >> is used for inband negotiation rather than just reading back what the
> >> MAC has been configured for. Update the documentation to explicitly
> >> mention that this is for inband.
> >>
> >> We drop the return value as well; most of phylink doesn't check the
> >> return value and it is not clear what it should do on error - instead
> >> arrange for state->link to be false.
> >>
> >> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> >> ---
> >> This is something I'd like to do to make it clearer what phylink
> >> expects of this function, and that it shouldn't just read-back how
> >> the MAC was configured.
> >>
> >> This version drops the deeper changes, concentrating just on the
> >> phylink API rather than delving deeper into drivers, as I haven't
> >> received any feedback on that patch.
> >>
> >> It would be nice to see all these drivers tested with this change.
> >
> > I'm tempted to just apply this, any objections?
> >
>
> Russell, which of this patch or: http://patchwork.ozlabs.org/patch/1197425/
>
> would you consider worthy of merging?
Let's go with v2 for now - it gets the rename done with less risk that
there'll be a problem. I can always do the remainder in a separate
patch after the merge window as a separate patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-11-22 9:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 0:36 [CFT PATCH net-next v2] net: phylink: rename mac_link_state() op to mac_pcs_get_state() Russell King
2019-11-21 0:36 ` Russell King
2019-11-21 0:36 ` Russell King
2019-11-22 3:14 ` David Miller
2019-11-22 3:14 ` David Miller
2019-11-22 3:14 ` David Miller
2019-11-22 3:36 ` Florian Fainelli
2019-11-22 3:36 ` Florian Fainelli
2019-11-22 3:36 ` Florian Fainelli
2019-11-22 9:21 ` Russell King - ARM Linux admin [this message]
2019-11-22 9:21 ` Russell King - ARM Linux admin
2019-11-22 9:21 ` Russell King - ARM Linux admin
2019-11-23 18:38 ` Jakub Kicinski
2019-11-23 18:38 ` Jakub Kicinski
2019-11-23 18:38 ` Jakub Kicinski
2019-11-23 20:30 ` Florian Fainelli
2019-11-23 20:30 ` Florian Fainelli
2019-11-23 20:30 ` Florian Fainelli
2019-11-24 0:15 ` Jakub Kicinski
2019-11-24 0:15 ` Jakub Kicinski
2019-11-24 0:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122092136.GJ25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Mark-MC.Lee@mediatek.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=sean.wang@mediatek.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.