From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 011FDC432C0 for ; Fri, 22 Nov 2019 10:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4FB420637 for ; Fri, 22 Nov 2019 10:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574419301; bh=7t+zd6ApZDLHyDBXxaHnsvqdU5V0/DfKsl898ThufDs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qs6lUtmiTrQ4Lyy1yeqnFGddNfyk7jAHpA5lgklmqzg4pWhdcCCPqPCc99nfferwX E5ssACmc5/LU4kBL8sxH8veom8ra5KFFGVaXW6LRB7CiYD8TGgjdLSRedVmxSmW55Z QFVNU7N5e936TglWnuL40yDrgQHd52L5CknArJgk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727835AbfKVKlk (ORCPT ); Fri, 22 Nov 2019 05:41:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:46244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727107AbfKVKlh (ORCPT ); Fri, 22 Nov 2019 05:41:37 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A417C20637; Fri, 22 Nov 2019 10:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574419297; bh=7t+zd6ApZDLHyDBXxaHnsvqdU5V0/DfKsl898ThufDs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YsE9+aAuhH25peo2UuI0fxv4yM95aFL3GV1cXYQHsUbLRiX5yhYFgeJvJzSXnGxAi sW2matM3XsHdnFVhx5pT3M+pwc75YW3VV3aCHXDtjtcjNFc8cmUpIH08v9qu3sRvPk 4jYtqgLrGRu+D3nsSW3uqbu9ms1iKr+u5jqI/FGA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lao Wei , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.9 062/222] media: fix: media: pci: meye: validate offset to avoid arbitrary access Date: Fri, 22 Nov 2019 11:26:42 +0100 Message-Id: <20191122100859.905517569@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100830.874290814@linuxfoundation.org> References: <20191122100830.874290814@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lao Wei [ Upstream commit eac7230fdb4672c2cb56f6a01a1744f562c01f80 ] Motion eye video4linux driver for Sony Vaio PictureBook desn't validate user-controlled parameter 'vma->vm_pgoff', a malicious process might access all of kernel memory from user space by trying pass different arbitrary address. Discussion: http://www.openwall.com/lists/oss-security/2018/07/06/1 Signed-off-by: Lao Wei Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/meye/meye.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci/meye/meye.c index ba887e8e1b171..a85c5199ccd30 100644 --- a/drivers/media/pci/meye/meye.c +++ b/drivers/media/pci/meye/meye.c @@ -1469,7 +1469,7 @@ static int meye_mmap(struct file *file, struct vm_area_struct *vma) unsigned long page, pos; mutex_lock(&meye.lock); - if (size > gbuffers * gbufsize) { + if (size > gbuffers * gbufsize || offset > gbuffers * gbufsize - size) { mutex_unlock(&meye.lock); return -EINVAL; } -- 2.20.1