From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: david.marchand@redhat.com, ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: disable automatic probing in null testing
Date: Fri, 22 Nov 2019 15:03:47 +0100 [thread overview]
Message-ID: <20191122140347.GE28445@bidouze.6wind.com> (raw)
In-Reply-To: <20191122134808.7639-1-thomas@monjalon.net>
Hi Thomas,
On Fri, Nov 22, 2019 at 02:48:08PM +0100, Thomas Monjalon wrote:
> The script test-null.sh is supposed to do a quick and simple
> run of testpmd with null PMD only, for sanity check.
> As it is not supposed to test probing of any other PMD,
> physical device probing is switched to whitelist mode
> by using a fake PCI address (0:0.0).
> It will also help to keep memory usage stable across platforms.
>
With https://patchwork.dpdk.org/patch/62014/, --manual-probe could be
used as a more standard way of workarounding the PCI bus.
This is a common issue, we should have cleaner way of addressing it than
using hacks relying on the PCI bus not panicking up upon finding an
inexistant address. Which is a questionable behavior, users should not
be encouraged to rely on it.
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> devtools/test-null.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/test-null.sh b/devtools/test-null.sh
> index 9f9a459f76..d82c6ad193 100755
> --- a/devtools/test-null.sh
> +++ b/devtools/test-null.sh
> @@ -26,5 +26,5 @@ fi
>
> (sleep 1 && echo stop) |
> $testpmd -c $coremask --no-huge -m 150 \
> - $libs --vdev net_null1 --vdev net_null2 $eal_options -- \
> + $libs -w 0:0.0 --vdev net_null1 --vdev net_null2 $eal_options -- \
> --no-mlockall --total-num-mbufs=2048 $testpmd_options -ia
> --
> 2.23.0
>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2019-11-22 14:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 15:12 [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption David Marchand
2019-11-21 15:36 ` Ferruh Yigit
2019-11-21 16:17 ` David Marchand
2019-11-21 16:23 ` David Marchand
2019-11-21 21:22 ` Thomas Monjalon
2019-11-21 16:45 ` Stephen Hemminger
2019-11-21 20:32 ` David Marchand
2019-11-21 21:25 ` Thomas Monjalon
2019-11-21 21:55 ` Thomas Monjalon
2019-11-22 10:43 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-11-22 12:24 ` Ferruh Yigit
2019-11-22 13:12 ` Thomas Monjalon
2019-11-22 13:14 ` Ferruh Yigit
2019-11-22 13:48 ` [dpdk-dev] [PATCH] devtools: disable automatic probing in null testing Thomas Monjalon
2019-11-22 13:56 ` Ferruh Yigit
2019-11-22 15:56 ` David Marchand
2019-11-24 22:52 ` Thomas Monjalon
2019-11-22 14:03 ` Gaëtan Rivet [this message]
2019-11-22 14:36 ` Thomas Monjalon
2019-11-22 14:14 ` [dpdk-dev] [PATCH v2] app/testpmd: reduce memory consumption Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122140347.GE28445@bidouze.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.