From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2018AC432C0 for ; Fri, 22 Nov 2019 23:57:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E77832064B for ; Fri, 22 Nov 2019 23:57:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N9zdRg+c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E77832064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZUX35/mPRC+iitCQ21getlTNGNp0mpOZ4x5/JvOTnmQ=; b=N9zdRg+cM0LaoK Eak7tubLiQQqLRZE8RqMpBqtuu8fwbe+7FgJMzW1XY1ephH5XV5RLAfX99RL1vRfowzXfDs4AO03r 4cgD65ZOKhFmeZ0mHm63BcGtd78F84+XOqzAf2mWX6KV9F+fYc9OJ6H/1Z9Mh1vWwj6T+cpkbjL7a A9maiO+r2Io1F2RHQot8ZRyoHAQgyhzIpDoNpXFr+Y4qnaxAVpZklXLfkbOqP2tqths1/ogmtXrXF DZUKqXY0ZYyXcBv5ana2t5FFj3JthtpRhqwQCESsFP3188r42VgYtQuGfWFYEXdx6am9JMV9r0I9w bWUKNFV0wWQvqQqeZPXg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYIo9-00075B-JS; Fri, 22 Nov 2019 23:57:49 +0000 Received: from mail-ot1-f66.google.com ([209.85.210.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYIo7-00074K-3B; Fri, 22 Nov 2019 23:57:48 +0000 Received: by mail-ot1-f66.google.com with SMTP id w24so7731784otk.6; Fri, 22 Nov 2019 15:57:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=frUbXg9HVcTRfaaxELwHERf+lloS19EI1WW6S+yHA38=; b=dMVmnzioXZqGqMXwJ+TmEGPDMwx0xmFv8AfKrnlXKsre0z/3UMVI2ac+he2Y6e/C0R 8NbSmQv8WYmmo5f1eG7pdrcGlPDYMha53d1gLEV0z8qHkTRChhWtl6sdf+EzXvcOi+cx OO7XPd8xerwWAlTuPgZDrhoKljVg+NcXDtQ8CbyT8+MEOMonc9u3IQ2MY0AxF/HBU/s0 S8+AkIzoksiQIu2R9eahQBy2XJ5oQtk2c2mDWVulKRNywbMzYNKMKJ/CUE3NtK0uZnaI 1wGmJIDOTtTSVMLBzCczveYQEJyAaO9rKPNfKHUeaw8V30iuM9j9EHvlG3RGgSS1H5AW J9Xg== X-Gm-Message-State: APjAAAXHiUMo3c/uRrbX/9roM8B3/CIvOKi7NY7+Bn0EmfMe5kLDRc2L FCQe/V30BTQdsvC2SZdKpA== X-Google-Smtp-Source: APXvYqwHRHTMvmyvayb6oZ7vqTCt5okUxjvzyr/SweEAZ3HXsEH7Y8guZbnlyFulghfXVoQpjJozjw== X-Received: by 2002:a9d:12d2:: with SMTP id g76mr13180792otg.232.1574467066059; Fri, 22 Nov 2019 15:57:46 -0800 (PST) Received: from localhost ([2607:fb90:bd7:3743:c9ec:246b:67b7:9768]) by smtp.gmail.com with ESMTPSA id b135sm2608451oii.1.2019.11.22.15.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 15:57:45 -0800 (PST) Date: Fri, 22 Nov 2019 17:57:31 -0600 From: Rob Herring To: allen Subject: Re: [PATCH v4 3/4] dt-bindings: Add binding for IT6505. Message-ID: <20191122235731.GB7738@bogus> References: <1573811564-320-1-git-send-email-allen.chen@ite.com.tw> <1573811564-320-4-git-send-email-allen.chen@ite.com.tw> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1573811564-320-4-git-send-email-allen.chen@ite.com.tw> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_155747_138817_F8DB690A X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Daniel Vetter , Jau-Chih Tseng , David Airlie , open list , "open list:DRM DRIVERS" , "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Nov 15, 2019 at 05:52:19PM +0800, allen wrote: > From: Allen Chen > > Add a DT binding documentation for IT6505. > > Signed-off-by: Allen Chen > Signed-off-by: Pi-Hsun Shih > --- > .../bindings/display/bridge/ite,it6505.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.txt Please make this a DT schema. See Documentation/devicetree/writing-schema.rst. > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt > new file mode 100644 > index 00000000..72da0c4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt > @@ -0,0 +1,28 @@ > +iTE it6505 DP bridge bindings > + > +Required properties: > + - compatible: "ite,it6505" > + - reg: i2c address of the bridge > + - ovdd-supply: I/O voltage > + - pwr18-supply: Core voltage > + - interrupts: interrupt specifier of INT pin > + - reset-gpios: gpio specifier of RESET pin > + - hpd-gpios: > + Hotplug detect GPIO. > + Indicates which GPIO should be used for hotplug detection Indentation is not consistent. > + - port@[x]: SoC specific port nodes with endpoint definitions as defined > + in Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt You need to define what each port is. With the schema, that will be 'port@0' and 'port@1' properties. > + > +Example: > + dp-bridge@5c { > + compatible = "ite,it6505"; > + interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>; > + reg = <0x5c>; > + pinctrl-names = "default"; > + pinctrl-0 = <&it6505_pins>; > + ovdd-supply = <&mt6358_vsim1_reg>; > + pwr18-supply = <&it6505_pp18_reg>; > + reset-gpios = <&pio 179 1>; > + hpd-gpios = <&pio 9 0>; > + extcon = <&usbc_extcon>; Not documented plus it's deprecated. You're missing ports here and they are required. Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66101C432C3 for ; Fri, 22 Nov 2019 23:57:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A6D72064B for ; Fri, 22 Nov 2019 23:57:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="clnkDw0c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A6D72064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q99qsmNqg1EjAQn75DUPzkCM6w4Qfc7eiHuPnsj41q4=; b=clnkDw0cHrcWdJ +ZFhhxNIcAYy/jKGRYk3c4IyZ6APn1ll3WBNXXUHoaqPGLHFOsnN7vCac0EfkdrUJmPhe4dm7q7AP paDZbOfrC1qLuQeQgQbkh1neHnUiXF38YnwLCU+NB78pGOELVAW1bdhavzboX/DOftMgKHEjZtS+p qn0XS6JvXKWEctDBz6P/6+o+Wfzo8YNaTTePtJSmO6Jx3PRRHJdxr2LHK2dsGgJsCKipjkyRsGfs7 DJIN3l2P+V4HtEaqxLX9ERvpJ9R4ZpMCkbNcAsEYs7ULgXDGQbOAeTIFL7NPfvv+l8rT9PJbzvRpI c+nd9GJ1vj7wZAwVVXMw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYIoA-00075w-Bl; Fri, 22 Nov 2019 23:57:50 +0000 Received: from mail-ot1-f66.google.com ([209.85.210.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYIo7-00074K-3B; Fri, 22 Nov 2019 23:57:48 +0000 Received: by mail-ot1-f66.google.com with SMTP id w24so7731784otk.6; Fri, 22 Nov 2019 15:57:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=frUbXg9HVcTRfaaxELwHERf+lloS19EI1WW6S+yHA38=; b=dMVmnzioXZqGqMXwJ+TmEGPDMwx0xmFv8AfKrnlXKsre0z/3UMVI2ac+he2Y6e/C0R 8NbSmQv8WYmmo5f1eG7pdrcGlPDYMha53d1gLEV0z8qHkTRChhWtl6sdf+EzXvcOi+cx OO7XPd8xerwWAlTuPgZDrhoKljVg+NcXDtQ8CbyT8+MEOMonc9u3IQ2MY0AxF/HBU/s0 S8+AkIzoksiQIu2R9eahQBy2XJ5oQtk2c2mDWVulKRNywbMzYNKMKJ/CUE3NtK0uZnaI 1wGmJIDOTtTSVMLBzCczveYQEJyAaO9rKPNfKHUeaw8V30iuM9j9EHvlG3RGgSS1H5AW J9Xg== X-Gm-Message-State: APjAAAXHiUMo3c/uRrbX/9roM8B3/CIvOKi7NY7+Bn0EmfMe5kLDRc2L FCQe/V30BTQdsvC2SZdKpA== X-Google-Smtp-Source: APXvYqwHRHTMvmyvayb6oZ7vqTCt5okUxjvzyr/SweEAZ3HXsEH7Y8guZbnlyFulghfXVoQpjJozjw== X-Received: by 2002:a9d:12d2:: with SMTP id g76mr13180792otg.232.1574467066059; Fri, 22 Nov 2019 15:57:46 -0800 (PST) Received: from localhost ([2607:fb90:bd7:3743:c9ec:246b:67b7:9768]) by smtp.gmail.com with ESMTPSA id b135sm2608451oii.1.2019.11.22.15.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 15:57:45 -0800 (PST) Date: Fri, 22 Nov 2019 17:57:31 -0600 From: Rob Herring To: allen Subject: Re: [PATCH v4 3/4] dt-bindings: Add binding for IT6505. Message-ID: <20191122235731.GB7738@bogus> References: <1573811564-320-1-git-send-email-allen.chen@ite.com.tw> <1573811564-320-4-git-send-email-allen.chen@ite.com.tw> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1573811564-320-4-git-send-email-allen.chen@ite.com.tw> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_155747_138817_F8DB690A X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Daniel Vetter , Jau-Chih Tseng , David Airlie , open list , "open list:DRM DRIVERS" , "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 15, 2019 at 05:52:19PM +0800, allen wrote: > From: Allen Chen > > Add a DT binding documentation for IT6505. > > Signed-off-by: Allen Chen > Signed-off-by: Pi-Hsun Shih > --- > .../bindings/display/bridge/ite,it6505.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.txt Please make this a DT schema. See Documentation/devicetree/writing-schema.rst. > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt > new file mode 100644 > index 00000000..72da0c4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt > @@ -0,0 +1,28 @@ > +iTE it6505 DP bridge bindings > + > +Required properties: > + - compatible: "ite,it6505" > + - reg: i2c address of the bridge > + - ovdd-supply: I/O voltage > + - pwr18-supply: Core voltage > + - interrupts: interrupt specifier of INT pin > + - reset-gpios: gpio specifier of RESET pin > + - hpd-gpios: > + Hotplug detect GPIO. > + Indicates which GPIO should be used for hotplug detection Indentation is not consistent. > + - port@[x]: SoC specific port nodes with endpoint definitions as defined > + in Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt You need to define what each port is. With the schema, that will be 'port@0' and 'port@1' properties. > + > +Example: > + dp-bridge@5c { > + compatible = "ite,it6505"; > + interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>; > + reg = <0x5c>; > + pinctrl-names = "default"; > + pinctrl-0 = <&it6505_pins>; > + ovdd-supply = <&mt6358_vsim1_reg>; > + pwr18-supply = <&it6505_pp18_reg>; > + reset-gpios = <&pio 179 1>; > + hpd-gpios = <&pio 9 0>; > + extcon = <&usbc_extcon>; Not documented plus it's deprecated. You're missing ports here and they are required. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0FC0C432C0 for ; Fri, 22 Nov 2019 23:57:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CE2A2064B for ; Fri, 22 Nov 2019 23:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574467067; bh=MpLjFUoVtyelVVDiJZBxklDh+WVhZauvPngcioECS2M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IaNf9RazHcP6WclAsjqL7mRxYjzhfVPsvbCiOY8rAArTlXKpkTPLFTQUGPhPpU6EJ l8MUMEjWHphHkJwJxQ44HWFNpn40Or8xUL10bwxnpMtc0t7YpXe+TivDbY+oKRtznX b5iV5lc95Cuj9evPUi0y0bBh+jA54Ylod40mbRbU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726721AbfKVX5r (ORCPT ); Fri, 22 Nov 2019 18:57:47 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:33695 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726705AbfKVX5q (ORCPT ); Fri, 22 Nov 2019 18:57:46 -0500 Received: by mail-ot1-f68.google.com with SMTP id q23so1884008otn.0; Fri, 22 Nov 2019 15:57:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=frUbXg9HVcTRfaaxELwHERf+lloS19EI1WW6S+yHA38=; b=Mtgn6Hp0Wb8ozbW6eCvPfqphsPvVvTYy1Fq3/CYe6r+0mw/UOpReaIPi4ZJQSvv+W/ W767UhB/9K7qM2sWHST2WAu5AxnYA4SU1LZyG30qI9xvUxZSMmZNr3ABuwx0z9Z6tqUe elgQ9ANq2IHXvOVFQO/PaqPgK7aJXCuxUviVF/wlzqme0zvoA3gwKnG9kUuQe2y4Nn3t rirF0qKbJtAKhaRQIr6zuygFdb9+IK5Gs2rK4LMbqU/jNJKw3FQpNWhxrELHMvhPWDc1 fgAwoZVBO4/sXNEC+pONenSDOMIyw5KqrTmTcd1xZo9f7LOHrR0VkDWSha1qaEQtTFOn VfQg== X-Gm-Message-State: APjAAAV1Uo1u7HVhxEx9ClsVj3AUrr+Z5kvVzozFuBqok5SwEvzP6Y9O yRQuiurrOA3xg4lwHYqYmh7Iw7k= X-Google-Smtp-Source: APXvYqwHRHTMvmyvayb6oZ7vqTCt5okUxjvzyr/SweEAZ3HXsEH7Y8guZbnlyFulghfXVoQpjJozjw== X-Received: by 2002:a9d:12d2:: with SMTP id g76mr13180792otg.232.1574467066059; Fri, 22 Nov 2019 15:57:46 -0800 (PST) Received: from localhost ([2607:fb90:bd7:3743:c9ec:246b:67b7:9768]) by smtp.gmail.com with ESMTPSA id b135sm2608451oii.1.2019.11.22.15.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 15:57:45 -0800 (PST) Date: Fri, 22 Nov 2019 17:57:31 -0600 From: Rob Herring To: allen Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Pi-Hsun Shih , Jau-Chih Tseng , David Airlie , open list , "open list:DRM DRIVERS" , "moderated list:ARM/Mediatek SoC support" , Daniel Vetter , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH v4 3/4] dt-bindings: Add binding for IT6505. Message-ID: <20191122235731.GB7738@bogus> References: <1573811564-320-1-git-send-email-allen.chen@ite.com.tw> <1573811564-320-4-git-send-email-allen.chen@ite.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1573811564-320-4-git-send-email-allen.chen@ite.com.tw> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Nov 15, 2019 at 05:52:19PM +0800, allen wrote: > From: Allen Chen > > Add a DT binding documentation for IT6505. > > Signed-off-by: Allen Chen > Signed-off-by: Pi-Hsun Shih > --- > .../bindings/display/bridge/ite,it6505.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.txt Please make this a DT schema. See Documentation/devicetree/writing-schema.rst. > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt > new file mode 100644 > index 00000000..72da0c4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt > @@ -0,0 +1,28 @@ > +iTE it6505 DP bridge bindings > + > +Required properties: > + - compatible: "ite,it6505" > + - reg: i2c address of the bridge > + - ovdd-supply: I/O voltage > + - pwr18-supply: Core voltage > + - interrupts: interrupt specifier of INT pin > + - reset-gpios: gpio specifier of RESET pin > + - hpd-gpios: > + Hotplug detect GPIO. > + Indicates which GPIO should be used for hotplug detection Indentation is not consistent. > + - port@[x]: SoC specific port nodes with endpoint definitions as defined > + in Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt You need to define what each port is. With the schema, that will be 'port@0' and 'port@1' properties. > + > +Example: > + dp-bridge@5c { > + compatible = "ite,it6505"; > + interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>; > + reg = <0x5c>; > + pinctrl-names = "default"; > + pinctrl-0 = <&it6505_pins>; > + ovdd-supply = <&mt6358_vsim1_reg>; > + pwr18-supply = <&it6505_pp18_reg>; > + reset-gpios = <&pio 179 1>; > + hpd-gpios = <&pio 9 0>; > + extcon = <&usbc_extcon>; Not documented plus it's deprecated. You're missing ports here and they are required. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7C9C43215 for ; Fri, 22 Nov 2019 23:57:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18C412064B for ; Fri, 22 Nov 2019 23:57:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18C412064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 565156F568; Fri, 22 Nov 2019 23:57:48 +0000 (UTC) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id D25606F568 for ; Fri, 22 Nov 2019 23:57:46 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id d5so7734440otp.4 for ; Fri, 22 Nov 2019 15:57:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=frUbXg9HVcTRfaaxELwHERf+lloS19EI1WW6S+yHA38=; b=KdCIYHVyO8poZesZ9Q2JMan8wn+OVC9NnFOWqmQumF9R3DPidXmUFTrk8Bf1yTQECY T/mhXBrC2OUcDu77oXrAUDTK52LzaBvvQcnEPuLigJhyZC4AHyI/KZTQBgT3jkxYc/2q W178r47NzilQVFlGaD3VuzpdVSlq98uiHwZqD7LpVuEdtplVJR3vNG2amfEmnnGNeN6c 9I8PkDn0TKn44wYd28iva7rwydGYg2Epl7z1nGfb1UNuV9WoJZl4lSAG8bTn18a1lRWu HGkM+OwmkXDlOENb6PBxX72yN+4ENCNWlEbjj2VRzC6Mn/BGJc9+BquALd9E5do4cZpe bQ0A== X-Gm-Message-State: APjAAAWNEgMAroZ32vhz6RchZGRl8ZVBpRFM1eZniHLw+EySWGeLzxH9 Sn6mcNw+cp/KGcSdQhOy7g== X-Google-Smtp-Source: APXvYqwHRHTMvmyvayb6oZ7vqTCt5okUxjvzyr/SweEAZ3HXsEH7Y8guZbnlyFulghfXVoQpjJozjw== X-Received: by 2002:a9d:12d2:: with SMTP id g76mr13180792otg.232.1574467066059; Fri, 22 Nov 2019 15:57:46 -0800 (PST) Received: from localhost ([2607:fb90:bd7:3743:c9ec:246b:67b7:9768]) by smtp.gmail.com with ESMTPSA id b135sm2608451oii.1.2019.11.22.15.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 15:57:45 -0800 (PST) Date: Fri, 22 Nov 2019 17:57:31 -0600 From: Rob Herring To: allen Subject: Re: [PATCH v4 3/4] dt-bindings: Add binding for IT6505. Message-ID: <20191122235731.GB7738@bogus> References: <1573811564-320-1-git-send-email-allen.chen@ite.com.tw> <1573811564-320-4-git-send-email-allen.chen@ite.com.tw> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1573811564-320-4-git-send-email-allen.chen@ite.com.tw> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jau-Chih Tseng , David Airlie , open list , "open list:DRM DRIVERS" , "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191122235731.BJ6QkOSKCBWSlMIYk3SqcMTjimqUYYSqSyPQpglbH70@z> T24gRnJpLCBOb3YgMTUsIDIwMTkgYXQgMDU6NTI6MTlQTSArMDgwMCwgYWxsZW4gd3JvdGU6Cj4g RnJvbTogQWxsZW4gQ2hlbiA8YWxsZW4uY2hlbkBpdGUuY29tLnR3Pgo+IAo+IEFkZCBhIERUIGJp bmRpbmcgZG9jdW1lbnRhdGlvbiBmb3IgSVQ2NTA1Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFsbGVu IENoZW4gPGFsbGVuLmNoZW5AaXRlLmNvbS50dz4KPiBTaWduZWQtb2ZmLWJ5OiBQaS1Ic3VuIFNo aWggPHBpaHN1bkBjaHJvbWl1bS5vcmc+Cj4gLS0tCj4gIC4uLi9iaW5kaW5ncy9kaXNwbGF5L2Jy aWRnZS9pdGUsaXQ2NTA1LnR4dCAgICAgICAgIHwgMjggKysrKysrKysrKysrKysrKysrKysrKwo+ ICAxIGZpbGUgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQg RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2l0ZSxpdDY1 MDUudHh0CgpQbGVhc2UgbWFrZSB0aGlzIGEgRFQgc2NoZW1hLiBTZWUgCkRvY3VtZW50YXRpb24v ZGV2aWNldHJlZS93cml0aW5nLXNjaGVtYS5yc3QuCiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2l0ZSxpdDY1MDUudHh0IGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2l0ZSxpdDY1 MDUudHh0Cj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMC4uNzJkYTBjNAo+ IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv ZGlzcGxheS9icmlkZ2UvaXRlLGl0NjUwNS50eHQKPiBAQCAtMCwwICsxLDI4IEBACj4gK2lURSBp dDY1MDUgRFAgYnJpZGdlIGJpbmRpbmdzCj4gKwo+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICsg ICAgICAgIC0gY29tcGF0aWJsZTogIml0ZSxpdDY1MDUiCj4gKyAgICAgICAgLSByZWc6IGkyYyBh ZGRyZXNzIG9mIHRoZSBicmlkZ2UKPiArICAgICAgICAtIG92ZGQtc3VwcGx5OiBJL08gdm9sdGFn ZQo+ICsgICAgICAgIC0gcHdyMTgtc3VwcGx5OiBDb3JlIHZvbHRhZ2UKPiArICAgICAgICAtIGlu dGVycnVwdHM6IGludGVycnVwdCBzcGVjaWZpZXIgb2YgSU5UIHBpbgo+ICsgICAgICAgIC0gcmVz ZXQtZ3Bpb3M6IGdwaW8gc3BlY2lmaWVyIG9mIFJFU0VUIHBpbgo+ICsJLSBocGQtZ3Bpb3M6Cj4g KwkJSG90cGx1ZyBkZXRlY3QgR1BJTy4KPiArCQlJbmRpY2F0ZXMgd2hpY2ggR1BJTyBzaG91bGQg YmUgdXNlZCBmb3IgaG90cGx1ZyBkZXRlY3Rpb24KCkluZGVudGF0aW9uIGlzIG5vdCBjb25zaXN0 ZW50LgoKPiArCS0gcG9ydEBbeF06IFNvQyBzcGVjaWZpYyBwb3J0IG5vZGVzIHdpdGggZW5kcG9p bnQgZGVmaW5pdGlvbnMgYXMgZGVmaW5lZAo+ICsJCWluIERvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L21lZGlhdGVrL21lZGlhdGVrLGRwaS50eHQKCllvdSBuZWVkIHRv IGRlZmluZSB3aGF0IGVhY2ggcG9ydCBpcy4gV2l0aCB0aGUgc2NoZW1hLCB0aGF0IHdpbGwgYmUg Cidwb3J0QDAnIGFuZCAncG9ydEAxJyBwcm9wZXJ0aWVzLgoKPiArCj4gK0V4YW1wbGU6Cj4gKwlk cC1icmlkZ2VANWMgewo+ICsgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJpdGUsaXQ2NTA1 IjsKPiArICAgICAgICAgICAgICAgIGludGVycnVwdHMgPSA8MTUyIElSUV9UWVBFX0VER0VfUklT SU5HIDE1MiAwPjsKPiArICAgICAgICAgICAgICAgIHJlZyA9IDwweDVjPjsKPiArICAgICAgICAg ICAgICAgIHBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4gKyAgICAgICAgICAgICAgICBwaW5j dHJsLTAgPSA8Jml0NjUwNV9waW5zPjsKPiArICAgICAgICAgICAgICAgIG92ZGQtc3VwcGx5ID0g PCZtdDYzNThfdnNpbTFfcmVnPjsKPiArICAgICAgICAgICAgICAgIHB3cjE4LXN1cHBseSA9IDwm aXQ2NTA1X3BwMThfcmVnPjsKPiArICAgICAgICAgICAgICAgIHJlc2V0LWdwaW9zID0gPCZwaW8g MTc5IDE+Owo+ICsgICAgICAgICAgICAgICAgaHBkLWdwaW9zID0gPCZwaW8gOSAwPjsKPiArICAg ICAgICAgICAgICAgIGV4dGNvbiA9IDwmdXNiY19leHRjb24+OwoKTm90IGRvY3VtZW50ZWQgcGx1 cyBpdCdzIGRlcHJlY2F0ZWQuCgpZb3UncmUgbWlzc2luZyBwb3J0cyBoZXJlIGFuZCB0aGV5IGFy ZSByZXF1aXJlZC4KClJvYgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWw=