From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26278C432C3 for ; Sun, 24 Nov 2019 07:32:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F294E2071A for ; Sun, 24 Nov 2019 07:32:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbfKXHc1 (ORCPT ); Sun, 24 Nov 2019 02:32:27 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36194 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfKXHc1 (ORCPT ); Sun, 24 Nov 2019 02:32:27 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id BF78727E7AF; Sun, 24 Nov 2019 07:32:24 +0000 (GMT) Date: Sun, 24 Nov 2019 08:32:22 +0100 From: Boris Brezillon To: Ezequiel Garcia Cc: dri-devel@lists.freedesktop.org, Mark Rutland , Neil Armstrong , Thierry Reding , Laurent Pinchart , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim Subject: Re: [PATCH v3 00/21] drm: Add support for bus-format negotiation Message-ID: <20191124083222.657619ee@collabora.com> In-Reply-To: <947ed9253bf501636e035698336c80c8af0743e0.camel@collabora.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <947ed9253bf501636e035698336c80c8af0743e0.camel@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 24 Nov 2019 09:46:41 +0900 Ezequiel Garcia wrote: > Hi Boris, Neil, > > On Wed, 2019-10-23 at 17:44 +0200, Boris Brezillon wrote: > > This patch series aims at adding support for runtime bus-format > > negotiation between all elements of the > > 'encoder -> bridges -> connector/display' section of the pipeline. > > > > In order to support that, we need drm bridges to fully take part in the > > atomic state validation process, which requires adding a > > drm_bridge_state and a new drm_bridge_funcs.atomic_check() hook. > > Once those basic building blocks are in place, we can add new hooks to > > allow bus format negotiation (those are called just before > > ->atomic_check()). The bus format selection is done at runtime by > > testing all possible combinations across the whole bridge chain until > > one is reported to work. > > > > Major changes since v2: > > * Get rid of the dummy bridge embedded in drm_encoder and let encoder > > drivers provide their own bridge element > > * Clarify APIs and improve the doc > > * Propagate bus flags by default > > > > Major changes since the RFC: > > > > * Add a dummy bridge to the drm_encoder object so that vc4 and exynos > > DSI drivers can implement the pre_enable/post_disable hooks instead > > of manually setting encoder->bridge to NULL to control the > > enable/disable sequence. This change is also a first step towards > > drm_bridge/drm_encoder unification. New encoder drivers should > > stop implementing drm_encoder_helper_funcs and switch to > > drm_bridge_funcs. Existing drivers can be converted progressively > > (already have a branch where I started converting some of them [1]) > > * rework the bus format negotiation to give more control to bridge > > drivers in the selection process (driver can select at runtime which > > input bus format they support for a specific output bus format based > > on any information available in the connector, crtc and bridge state. > > > > A more detailed changelog is provided in each patch. > > > > This patch series is also available here [2]. > > > > Thanks, > > > > Boris > > > > [1]https://github.com/bbrezillon/linux-0day/commits/drm-encoder-bridge > > [2]https://github.com/bbrezillon/linux-0day/commits/drm-bridge-busfmt-v3 > > > > *** BLURB HERE *** > > > > Boris Brezillon (21): > > drm/vc4: Declare the DSI encoder as a bridge element > > drm/exynos: Don't reset bridge->next > > drm/exynos: Declare the DSI encoder as a bridge element > > drm/bridge: Rename bridge helpers targeting a bridge chain > > drm/bridge: Introduce drm_bridge_chain_get_next_bridge() > > drm: Stop accessing encoder->bridge directly > > Patches 1 to 6 seem to be reviewed, and appear as a good > step forward. AFAICT, patch 1 and 3 are not reviewed, which is kind of blocking me for patch 4-6. I can (and plan to) apply patch 2. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v3 00/21] drm: Add support for bus-format negotiation Date: Sun, 24 Nov 2019 08:32:22 +0100 Message-ID: <20191124083222.657619ee@collabora.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <947ed9253bf501636e035698336c80c8af0743e0.camel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id A40046E06E for ; Sun, 24 Nov 2019 07:32:26 +0000 (UTC) In-Reply-To: <947ed9253bf501636e035698336c80c8af0743e0.camel@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ezequiel Garcia Cc: Mark Rutland , Nikita Yushchenko , devicetree@vger.kernel.org, Neil Armstrong , Andrey Smirnov , Jonas Karlman , Seung-Woo Kim , Jernej Skrabec , dri-devel@lists.freedesktop.org, Rob Herring , Kyungmin Park , Thierry Reding , Laurent Pinchart , kernel@collabora.com, Sam Ravnborg , Chris Healy List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAyNCBOb3YgMjAxOSAwOTo0Njo0MSArMDkwMApFemVxdWllbCBHYXJjaWEgPGV6ZXF1 aWVsQGNvbGxhYm9yYS5jb20+IHdyb3RlOgoKPiBIaSBCb3JpcywgTmVpbCwKPiAKPiBPbiBXZWQs IDIwMTktMTAtMjMgYXQgMTc6NDQgKzAyMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90ZToKPiA+IFRo aXMgcGF0Y2ggc2VyaWVzIGFpbXMgYXQgYWRkaW5nIHN1cHBvcnQgZm9yIHJ1bnRpbWUgYnVzLWZv cm1hdAo+ID4gbmVnb3RpYXRpb24gYmV0d2VlbiBhbGwgZWxlbWVudHMgb2YgdGhlCj4gPiAnZW5j b2RlciAtPiBicmlkZ2VzIC0+IGNvbm5lY3Rvci9kaXNwbGF5JyBzZWN0aW9uIG9mIHRoZSBwaXBl bGluZS4KPiA+IAo+ID4gSW4gb3JkZXIgdG8gc3VwcG9ydCB0aGF0LCB3ZSBuZWVkIGRybSBicmlk Z2VzIHRvIGZ1bGx5IHRha2UgcGFydCBpbiB0aGUKPiA+IGF0b21pYyBzdGF0ZSB2YWxpZGF0aW9u IHByb2Nlc3MsIHdoaWNoIHJlcXVpcmVzIGFkZGluZyBhCj4gPiBkcm1fYnJpZGdlX3N0YXRlIGFu ZCBhIG5ldyBkcm1fYnJpZGdlX2Z1bmNzLmF0b21pY19jaGVjaygpIGhvb2suCj4gPiBPbmNlIHRo b3NlIGJhc2ljIGJ1aWxkaW5nIGJsb2NrcyBhcmUgaW4gcGxhY2UsIHdlIGNhbiBhZGQgbmV3IGhv b2tzIHRvCj4gPiBhbGxvdyBidXMgZm9ybWF0IG5lZ290aWF0aW9uICh0aG9zZSBhcmUgY2FsbGVk IGp1c3QgYmVmb3JlICAKPiA+IC0+YXRvbWljX2NoZWNrKCkpLiBUaGUgYnVzIGZvcm1hdCBzZWxl Y3Rpb24gaXMgZG9uZSBhdCBydW50aW1lIGJ5ICAKPiA+IHRlc3RpbmcgYWxsIHBvc3NpYmxlIGNv bWJpbmF0aW9ucyBhY3Jvc3MgdGhlIHdob2xlIGJyaWRnZSBjaGFpbiB1bnRpbAo+ID4gb25lIGlz IHJlcG9ydGVkIHRvIHdvcmsuCj4gPiAKPiA+IE1ham9yIGNoYW5nZXMgc2luY2UgdjI6Cj4gPiAq IEdldCByaWQgb2YgdGhlIGR1bW15IGJyaWRnZSBlbWJlZGRlZCBpbiBkcm1fZW5jb2RlciBhbmQg bGV0IGVuY29kZXIKPiA+ICAgZHJpdmVycyBwcm92aWRlIHRoZWlyIG93biBicmlkZ2UgZWxlbWVu dAo+ID4gKiBDbGFyaWZ5IEFQSXMgYW5kIGltcHJvdmUgdGhlIGRvYwo+ID4gKiBQcm9wYWdhdGUg YnVzIGZsYWdzIGJ5IGRlZmF1bHQKPiA+IAo+ID4gTWFqb3IgY2hhbmdlcyBzaW5jZSB0aGUgUkZD Ogo+ID4gCj4gPiAqIEFkZCBhIGR1bW15IGJyaWRnZSB0byB0aGUgZHJtX2VuY29kZXIgb2JqZWN0 IHNvIHRoYXQgdmM0IGFuZCBleHlub3MKPiA+ICAgRFNJIGRyaXZlcnMgY2FuIGltcGxlbWVudCB0 aGUgcHJlX2VuYWJsZS9wb3N0X2Rpc2FibGUgaG9va3MgaW5zdGVhZAo+ID4gICBvZiBtYW51YWxs eSBzZXR0aW5nIGVuY29kZXItPmJyaWRnZSB0byBOVUxMIHRvIGNvbnRyb2wgdGhlCj4gPiAgIGVu YWJsZS9kaXNhYmxlIHNlcXVlbmNlLiBUaGlzIGNoYW5nZSBpcyBhbHNvIGEgZmlyc3Qgc3RlcCB0 b3dhcmRzCj4gPiAgIGRybV9icmlkZ2UvZHJtX2VuY29kZXIgdW5pZmljYXRpb24uIE5ldyBlbmNv ZGVyIGRyaXZlcnMgc2hvdWxkCj4gPiAgIHN0b3AgaW1wbGVtZW50aW5nIGRybV9lbmNvZGVyX2hl bHBlcl9mdW5jcyBhbmQgc3dpdGNoIHRvCj4gPiAgIGRybV9icmlkZ2VfZnVuY3MuIEV4aXN0aW5n IGRyaXZlcnMgY2FuIGJlIGNvbnZlcnRlZCBwcm9ncmVzc2l2ZWx5Cj4gPiAgIChhbHJlYWR5IGhh dmUgYSBicmFuY2ggd2hlcmUgSSBzdGFydGVkIGNvbnZlcnRpbmcgc29tZSBvZiB0aGVtIFsxXSkK PiA+ICogcmV3b3JrIHRoZSBidXMgZm9ybWF0IG5lZ290aWF0aW9uIHRvIGdpdmUgbW9yZSBjb250 cm9sIHRvIGJyaWRnZQo+ID4gICBkcml2ZXJzIGluIHRoZSBzZWxlY3Rpb24gcHJvY2VzcyAoZHJp dmVyIGNhbiBzZWxlY3QgYXQgcnVudGltZSB3aGljaAo+ID4gICBpbnB1dCBidXMgZm9ybWF0IHRo ZXkgc3VwcG9ydCBmb3IgYSBzcGVjaWZpYyBvdXRwdXQgYnVzIGZvcm1hdCBiYXNlZAo+ID4gICBv biBhbnkgaW5mb3JtYXRpb24gYXZhaWxhYmxlIGluIHRoZSBjb25uZWN0b3IsIGNydGMgYW5kIGJy aWRnZSBzdGF0ZS4KPiA+IAo+ID4gQSBtb3JlIGRldGFpbGVkIGNoYW5nZWxvZyBpcyBwcm92aWRl ZCBpbiBlYWNoIHBhdGNoLgo+ID4gCj4gPiBUaGlzIHBhdGNoIHNlcmllcyBpcyBhbHNvIGF2YWls YWJsZSBoZXJlIFsyXS4KPiA+IAo+ID4gVGhhbmtzLAo+ID4gCj4gPiBCb3Jpcwo+ID4gCj4gPiBb MV1odHRwczovL2dpdGh1Yi5jb20vYmJyZXppbGxvbi9saW51eC0wZGF5L2NvbW1pdHMvZHJtLWVu Y29kZXItYnJpZGdlCj4gPiBbMl1odHRwczovL2dpdGh1Yi5jb20vYmJyZXppbGxvbi9saW51eC0w ZGF5L2NvbW1pdHMvZHJtLWJyaWRnZS1idXNmbXQtdjMKPiA+IAo+ID4gKioqIEJMVVJCIEhFUkUg KioqCj4gPiAKPiA+IEJvcmlzIEJyZXppbGxvbiAoMjEpOgo+ID4gICBkcm0vdmM0OiBEZWNsYXJl IHRoZSBEU0kgZW5jb2RlciBhcyBhIGJyaWRnZSBlbGVtZW50Cj4gPiAgIGRybS9leHlub3M6IERv bid0IHJlc2V0IGJyaWRnZS0+bmV4dAo+ID4gICBkcm0vZXh5bm9zOiBEZWNsYXJlIHRoZSBEU0kg ZW5jb2RlciBhcyBhIGJyaWRnZSBlbGVtZW50Cj4gPiAgIGRybS9icmlkZ2U6IFJlbmFtZSBicmlk Z2UgaGVscGVycyB0YXJnZXRpbmcgYSBicmlkZ2UgY2hhaW4KPiA+ICAgZHJtL2JyaWRnZTogSW50 cm9kdWNlIGRybV9icmlkZ2VfY2hhaW5fZ2V0X25leHRfYnJpZGdlKCkKPiA+ICAgZHJtOiBTdG9w IGFjY2Vzc2luZyBlbmNvZGVyLT5icmlkZ2UgZGlyZWN0bHkgIAo+IAo+IFBhdGNoZXMgMSB0byA2 IHNlZW0gdG8gYmUgcmV2aWV3ZWQsIGFuZCBhcHBlYXIgYXMgYSBnb29kCj4gc3RlcCBmb3J3YXJk LgoKQUZBSUNULCBwYXRjaCAxIGFuZCAzIGFyZSBub3QgcmV2aWV3ZWQsIHdoaWNoIGlzIGtpbmQg b2YgYmxvY2tpbmcgbWUKZm9yIHBhdGNoIDQtNi4gSSBjYW4gKGFuZCBwbGFuIHRvKSBhcHBseSBw YXRjaCAyLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=