From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 078DEC432C0 for ; Sun, 24 Nov 2019 13:40:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB3EA2071A for ; Sun, 24 Nov 2019 13:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbfKXNkL (ORCPT ); Sun, 24 Nov 2019 08:40:11 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:41184 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726797AbfKXNkL (ORCPT ); Sun, 24 Nov 2019 08:40:11 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 47ED627C12F; Sun, 24 Nov 2019 13:40:09 +0000 (GMT) Date: Sun, 24 Nov 2019 14:40:06 +0100 From: Boris Brezillon To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH v3 06/21] drm: Stop accessing encoder->bridge directly Message-ID: <20191124144006.7e2fc959@collabora.com> In-Reply-To: <20191124103926.GG4727@pendragon.ideasonboard.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <20191023154512.9762-7-boris.brezillon@collabora.com> <20191124103926.GG4727@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 24 Nov 2019 12:39:26 +0200 Laurent Pinchart wrote: > > @@ -1346,7 +1355,7 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev, > > funcs->commit(encoder); > > } > > > > - drm_atomic_bridge_chain_enable(encoder->bridge, old_state); > > + drm_atomic_bridge_chain_enable(bridge, old_state); > > } > > > > drm_atomic_helper_commit_writebacks(dev, old_state); > > diff --git a/drivers/gpu/drm/drm_encoder.c b/drivers/gpu/drm/drm_encoder.c > > index 80d88a55302e..4fe9e723e227 100644 > > --- a/drivers/gpu/drm/drm_encoder.c > > +++ b/drivers/gpu/drm/drm_encoder.c > > @@ -167,9 +167,10 @@ void drm_encoder_cleanup(struct drm_encoder *encoder) > > */ > > > > if (encoder->bridge) { > > - struct drm_bridge *bridge = encoder->bridge; > > + struct drm_bridge *bridge; > > struct drm_bridge *next; > > > > + bridge = drm_bridge_chain_get_first_bridge(encoder); > > while (bridge) { > > next = bridge->next; > > Shouldn't this have been addressed in the previous patch ? > It should and I will update patch 6 accordingly. This being said, it's not a big deal since the code is patched to use list_for_each_entry_safe() in patch 7 ;-). From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v3 06/21] drm: Stop accessing encoder->bridge directly Date: Sun, 24 Nov 2019 14:40:06 +0100 Message-ID: <20191124144006.7e2fc959@collabora.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <20191023154512.9762-7-boris.brezillon@collabora.com> <20191124103926.GG4727@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34C1089F55 for ; Sun, 24 Nov 2019 13:40:11 +0000 (UTC) In-Reply-To: <20191124103926.GG4727@pendragon.ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAyNCBOb3YgMjAxOSAxMjozOToyNiArMDIwMApMYXVyZW50IFBpbmNoYXJ0IDxsYXVy ZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+IHdyb3RlOgoKPiA+IEBAIC0xMzQ2LDcgKzEz NTUsNyBAQCB2b2lkIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXMoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICAJCQkJZnVuY3MtPmNvbW1pdChlbmNvZGVyKTsKPiA+ ICAJCX0KPiA+ICAKPiA+IC0JCWRybV9hdG9taWNfYnJpZGdlX2NoYWluX2VuYWJsZShlbmNvZGVy LT5icmlkZ2UsIG9sZF9zdGF0ZSk7Cj4gPiArCQlkcm1fYXRvbWljX2JyaWRnZV9jaGFpbl9lbmFi bGUoYnJpZGdlLCBvbGRfc3RhdGUpOwo+ID4gIAl9Cj4gPiAgCj4gPiAgCWRybV9hdG9taWNfaGVs cGVyX2NvbW1pdF93cml0ZWJhY2tzKGRldiwgb2xkX3N0YXRlKTsKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2VuY29kZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZW5jb2Rl ci5jCj4gPiBpbmRleCA4MGQ4OGE1NTMwMmUuLjRmZTllNzIzZTIyNyAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZW5jb2Rlci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2VuY29kZXIuYwo+ID4gQEAgLTE2Nyw5ICsxNjcsMTAgQEAgdm9pZCBkcm1fZW5jb2Rlcl9j bGVhbnVwKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcikKPiA+ICAJICovCj4gPiAgCj4gPiAg CWlmIChlbmNvZGVyLT5icmlkZ2UpIHsKPiA+IC0JCXN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2Ug PSBlbmNvZGVyLT5icmlkZ2U7Cj4gPiArCQlzdHJ1Y3QgZHJtX2JyaWRnZSAqYnJpZGdlOwo+ID4g IAkJc3RydWN0IGRybV9icmlkZ2UgKm5leHQ7Cj4gPiAgCj4gPiArCQlicmlkZ2UgPSBkcm1fYnJp ZGdlX2NoYWluX2dldF9maXJzdF9icmlkZ2UoZW5jb2Rlcik7Cj4gPiAgCQl3aGlsZSAoYnJpZGdl KSB7Cj4gPiAgCQkJbmV4dCA9IGJyaWRnZS0+bmV4dDsgIAo+IAo+IFNob3VsZG4ndCB0aGlzIGhh dmUgYmVlbiBhZGRyZXNzZWQgaW4gdGhlIHByZXZpb3VzIHBhdGNoID8KPiAKCkl0IHNob3VsZCBh bmQgSSB3aWxsIHVwZGF0ZSBwYXRjaCA2IGFjY29yZGluZ2x5LiBUaGlzIGJlaW5nIHNhaWQsIGl0 J3MKbm90IGEgYmlnIGRlYWwgc2luY2UgdGhlIGNvZGUgaXMgcGF0Y2hlZCB0byB1c2UKbGlzdF9m b3JfZWFjaF9lbnRyeV9zYWZlKCkgaW4gcGF0Y2ggNyA7LSkuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==