From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71168C432C0 for ; Sun, 24 Nov 2019 17:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51116207FD for ; Sun, 24 Nov 2019 17:48:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbfKXRsn (ORCPT ); Sun, 24 Nov 2019 12:48:43 -0500 Received: from muru.com ([72.249.23.125]:43404 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726803AbfKXRsm (ORCPT ); Sun, 24 Nov 2019 12:48:42 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 738CF80E4; Sun, 24 Nov 2019 17:49:18 +0000 (UTC) Date: Sun, 24 Nov 2019 09:48:37 -0800 From: Tony Lindgren To: Paul Cercueil Cc: "H. Nikolaus Schaller" , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Ralf Baechle , Paul Burton , James Hogan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, openpvrsgx-devgroup@letux.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, linux-mips@vger.kernel.org, Paul Boddie Subject: Re: [PATCH v3 8/8] MIPS: DTS: jz4780: add sgx gpu node Message-ID: <20191124174837.GX35479@atomide.com> References: <1574600246.3.0@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1574600246.3.0@crapouillou.net> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org * Paul Cercueil [191124 12:58]: > Le dim., nov. 24, 2019 at 12:40, H. Nikolaus Schaller a > écrit : > > and add interrupt and clocks. ... > > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > > @@ -46,6 +46,17 @@ > > #clock-cells = <1>; > > }; > > > > + gpu: gpu@13040000 { > > We try to keep the nodes ordered by address, could you move this node where > it belongs? ... > > + compatible = "ingenic,jz4780-sgx540-120", "img,sgx540-120", > > "img,sgx540", "img,sgx5"; > > + reg = <0x13040000 0x4000>; > > + > > + clocks = <&cgu JZ4780_CLK_GPU>; > > + clock-names = "gpu"; Just checking.. Is there something else to configure here potentially in addition to the clocks? That is, do we need to do some interconnect specific configuration etc in addition to the clocks to have runtime PM work for enabling and disabling sgx on jz4780? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBD7C432C3 for ; Mon, 25 Nov 2019 08:08:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAC0F20679 for ; Mon, 25 Nov 2019 08:08:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAC0F20679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A12F89FF6; Mon, 25 Nov 2019 08:08:53 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id C9A2189CF6 for ; Sun, 24 Nov 2019 17:48:46 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 738CF80E4; Sun, 24 Nov 2019 17:49:18 +0000 (UTC) Date: Sun, 24 Nov 2019 09:48:37 -0800 From: Tony Lindgren To: Paul Cercueil Subject: Re: [PATCH v3 8/8] MIPS: DTS: jz4780: add sgx gpu node Message-ID: <20191124174837.GX35479@atomide.com> References: <1574600246.3.0@crapouillou.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1574600246.3.0@crapouillou.net> User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Approved-At: Mon, 25 Nov 2019 08:07:41 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, letux-kernel@openphoenux.org, Paul Burton , David Airlie , "H. Nikolaus Schaller" , kernel@pyra-handheld.com, openpvrsgx-devgroup@letux.org, linux-kernel@vger.kernel.org, Ralf Baechle , linux-mips@vger.kernel.org, Paul Boddie , Rob Herring , dri-devel@lists.freedesktop.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , James Hogan , linux-omap@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191124174837.mnM4VgcY0iVuS6_-WAfXnH-qfDat5GauNiUGbHMsNGc@z> KiBQYXVsIENlcmN1ZWlsIDxwYXVsQGNyYXBvdWlsbG91Lm5ldD4gWzE5MTEyNCAxMjo1OF06Cj4g TGUgZGltLiwgbm92LiAyNCwgMjAxOSBhdCAxMjo0MCwgSC4gTmlrb2xhdXMgU2NoYWxsZXIgPGhu c0Bnb2xkZWxpY28uY29tPiBhCj4gw6ljcml0IDoKPiA+IGFuZCBhZGQgaW50ZXJydXB0IGFuZCBj bG9ja3MuCi4uLgo+ID4gLS0tIGEvYXJjaC9taXBzL2Jvb3QvZHRzL2luZ2VuaWMvano0NzgwLmR0 c2kKPiA+ICsrKyBiL2FyY2gvbWlwcy9ib290L2R0cy9pbmdlbmljL2p6NDc4MC5kdHNpCj4gPiBA QCAtNDYsNiArNDYsMTcgQEAKPiA+ICAJCSNjbG9jay1jZWxscyA9IDwxPjsKPiA+ICAJfTsKPiA+ IAo+ID4gKwlncHU6IGdwdUAxMzA0MDAwMCB7Cj4gCj4gV2UgdHJ5IHRvIGtlZXAgdGhlIG5vZGVz IG9yZGVyZWQgYnkgYWRkcmVzcywgY291bGQgeW91IG1vdmUgdGhpcyBub2RlIHdoZXJlCj4gaXQg YmVsb25ncz8KLi4uCgo+ID4gKwkJY29tcGF0aWJsZSA9ICJpbmdlbmljLGp6NDc4MC1zZ3g1NDAt MTIwIiwgImltZyxzZ3g1NDAtMTIwIiwKPiA+ICJpbWcsc2d4NTQwIiwgImltZyxzZ3g1IjsKPiA+ ICsJCXJlZyA9IDwweDEzMDQwMDAwIDB4NDAwMD47Cj4gPiArCj4gPiArCQljbG9ja3MgPSA8JmNn dSBKWjQ3ODBfQ0xLX0dQVT47Cj4gPiArCQljbG9jay1uYW1lcyA9ICJncHUiOwoKSnVzdCBjaGVj a2luZy4uIElzIHRoZXJlIHNvbWV0aGluZyBlbHNlIHRvIGNvbmZpZ3VyZSBoZXJlCnBvdGVudGlh bGx5IGluIGFkZGl0aW9uIHRvIHRoZSBjbG9ja3M/CgpUaGF0IGlzLCBkbyB3ZSBuZWVkIHRvIGRv IHNvbWUgaW50ZXJjb25uZWN0IHNwZWNpZmljCmNvbmZpZ3VyYXRpb24gZXRjIGluIGFkZGl0aW9u IHRvIHRoZSBjbG9ja3MgdG8gaGF2ZQpydW50aW1lIFBNIHdvcmsgZm9yIGVuYWJsaW5nIGFuZCBk aXNhYmxpbmcgc2d4IG9uCmp6NDc4MD8KClJlZ2FyZHMsCgpUb255Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==