From: Sasha Levin <sashal@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: gregkh@google.com, stable@vger.kernel.org
Subject: Re: [PATCH 4.9 8/8] ext4: avoid unnecessary stalls in ext4_evict_inode()
Date: Mon, 25 Nov 2019 08:48:35 -0500 [thread overview]
Message-ID: <20191125134835.GC5861@sasha-vm> (raw)
In-Reply-To: <20191122105253.11375-8-lee.jones@linaro.org>
On Fri, Nov 22, 2019 at 10:52:53AM +0000, Lee Jones wrote:
>From: Jan Kara <jack@suse.cz>
>
>[ Upstream commit 3abb1a0fc2871f2db52199e1748a1d48a54a3427 ]
>
>These days inode reclaim calls evict_inode() only when it has no pages
>in the mapping. In that case it is not necessary to wait for transaction
>commit in ext4_evict_inode() as there can be no pages waiting to be
>committed. So avoid unnecessary transaction waiting in that case.
>
>We still have to keep the check for the case where ext4_evict_inode()
>gets called from other paths (e.g. umount) where inode still can have
>some page cache pages.
This reads to me like an optimization?
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-11-25 13:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 10:52 [PATCH 4.9 1/8] ARM: 8904/1: skip nomap memblocks while finding the lowmem/highmem boundary Lee Jones
2019-11-22 10:52 ` [PATCH 4.9 2/8] can: dev: can_dellink(): remove return at end of void function Lee Jones
2019-11-22 10:52 ` [PATCH 4.9 3/8] arm64: fix for bad_mode() handler to always result in panic Lee Jones
2019-11-25 13:47 ` Sasha Levin
2019-11-25 14:44 ` Lee Jones
2019-11-25 17:41 ` Greg KH
2019-11-25 18:25 ` Lee Jones
2019-11-26 13:49 ` Lee Jones
2019-11-22 10:52 ` [PATCH 4.9 4/8] cpufreq: Skip cpufreq resume if it's not suspended Lee Jones
2019-11-22 10:52 ` [PATCH 4.9 5/8] bcache: silence static checker warning Lee Jones
2019-11-25 13:47 ` Sasha Levin
2019-11-22 10:52 ` [PATCH 4.9 6/8] dm: use blk_set_queue_dying() in __dm_destroy() Lee Jones
2019-11-22 10:52 ` [PATCH 4.9 7/8] ocfs2: remove ocfs2_is_o2cb_active() Lee Jones
2019-11-22 10:52 ` [PATCH 4.9 8/8] ext4: avoid unnecessary stalls in ext4_evict_inode() Lee Jones
2019-11-25 13:48 ` Sasha Levin [this message]
2019-11-25 14:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125134835.GC5861@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@google.com \
--cc=lee.jones@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.