From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/pkg-kconfig: fix reconfigure for kconfig packages
Date: Tue, 26 Nov 2019 14:18:38 +0100 [thread overview]
Message-ID: <20191126141838.74d804f8@windsurf> (raw)
In-Reply-To: <1574771063-29218-1-git-send-email-angelo@amarulasolutions.com>
On Tue, 26 Nov 2019 13:24:23 +0100
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>
> Commit 4b81badbcc0b25678ac6627548160702731cf393
>
> Currently, calling foo-reconfigure for a kconfig-based package will not
> re-trigger the configuration (kconfig-wise) step for the package.
>
> already solved this problem, but it was lately regressed by
>
> Commit 05fea6e4a60a38a797d9bacbf318a2cd7dbd435f
Are you sure it was regressed ? When I read the code at commit
4b81badbcc0b25678ac6627548160702731cf393, I don't see even back then
how linux-reconfigure would trigger a complete reconfiguration. Have
you actually verified that it was working as expected back at commit
4b81badbcc0b25678ac6627548160702731cf393 ? Indeed, at commit
4b81badbcc0b25678ac6627548160702731cf393, we were already only removing
the stamp_kconfig_fixup_done stamp file, so my understanding is rather
that commit 4b81badbcc0b25678ac6627548160702731cf393 doesn't implement
what the commit log says.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-11-26 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 12:24 [Buildroot] [PATCH v2] package/pkg-kconfig: fix reconfigure for kconfig packages Angelo Compagnucci
2019-11-26 13:18 ` Thomas Petazzoni [this message]
2019-11-26 13:22 ` Angelo Compagnucci
2019-11-26 13:29 ` Thomas Petazzoni
2019-11-26 13:55 ` Angelo Compagnucci
2019-11-26 13:58 ` Thomas Petazzoni
2019-11-26 13:59 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126141838.74d804f8@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.