From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Benjamin Gaignard <benjamin.gaignard@st.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/rect: update kerneldoc for drm_rect_clip_scaled()
Date: Tue, 26 Nov 2019 17:10:14 +0200 [thread overview]
Message-ID: <20191126151014.GB1208@intel.com> (raw)
In-Reply-To: <20191126145213.380079-1-daniel.vetter@ffwll.ch>
On Tue, Nov 26, 2019 at 03:52:13PM +0100, Daniel Vetter wrote:
> This was forgotten in f96bdf564f3e ("drm/rect: Handle rounding errors
> in drm_rect_clip_scaled, v3.")
>
> Spotted while reviewing patches from Ville touching this area.
>
> Fixes: f96bdf564f3e ("drm/rect: Handle rounding errors in drm_rect_clip_scaled, v3.")
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_rect.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_rect.c b/drivers/gpu/drm/drm_rect.c
> index b8363aaa9032..e6e640f2d5e3 100644
> --- a/drivers/gpu/drm/drm_rect.c
> +++ b/drivers/gpu/drm/drm_rect.c
> @@ -73,11 +73,13 @@ static u32 clip_scaled(u32 src, u32 dst, u32 clip)
> * @clip: clip rectangle
> *
> * Clip rectangle @dst by rectangle @clip. Clip rectangle @src by the
> - * same amounts multiplied by @hscale and @vscale.
> + * the corresponding amounts, retaining the vertical and horizontal scaling
> + * factors from @src to @dst.
> *
> * RETURNS:
> + *
> * %true if rectangle @dst is still visible after being clipped,
> - * %false otherwise
> + * %false otherwise.
> */
> bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst,
> const struct drm_rect *clip)
> --
> 2.24.0
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-26 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 14:52 [PATCH] drm/rect: update kerneldoc for drm_rect_clip_scaled() Daniel Vetter
2019-11-26 15:10 ` Ville Syrjälä [this message]
2019-11-28 12:15 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126151014.GB1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=benjamin.gaignard@st.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.