From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 28/30] drm/sti: sti_vdo: Use drm_bridge_init() Date: Tue, 26 Nov 2019 20:37:40 +0100 Message-ID: <20191126193740.GC2044@ravnborg.org> References: <20191126131541.47393-1-mihail.atanassov@arm.com> <20191126131541.47393-29-mihail.atanassov@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191126131541.47393-29-mihail.atanassov@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Mihail Atanassov Cc: "dri-devel@lists.freedesktop.org" , David Airlie , "linux-kernel@vger.kernel.org" , nd , Vincent Abriou List-Id: dri-devel@lists.freedesktop.org Hi Mihail. On Tue, Nov 26, 2019 at 01:16:26PM +0000, Mihail Atanassov wrote: > No functional change. > > Signed-off-by: Mihail Atanassov > --- > drivers/gpu/drm/sti/sti_dvo.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c > index 68289b0b063a..20a3956b33bc 100644 > --- a/drivers/gpu/drm/sti/sti_dvo.c > +++ b/drivers/gpu/drm/sti/sti_dvo.c > @@ -462,9 +462,7 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data) > if (!bridge) > return -ENOMEM; > > - bridge->driver_private = dvo; > - bridge->funcs = &sti_dvo_bridge_funcs; > - bridge->of_node = dvo->dev.of_node; > + drm_bridge_init(bridge, &dvo->dev, &sti_dvo_bridge_funcs, NULL, dvo); > drm_bridge_add(bridge); > > err = drm_bridge_attach(encoder, bridge, NULL); I can see from grepping that bridge.driver_private is used in a couple of other files in sti/ Like sti_hdmi.c: bridge->driver_private = hdmi; bridge->funcs = &sti_hdmi_bridge_funcs; drm_bridge_attach(encoder, bridge, NULL); I wonder if a drm_bridge_init() should be added there. I did not look closely - but it looked suspisiously. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8927C432C0 for ; Tue, 26 Nov 2019 19:37:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8113A2073F for ; Tue, 26 Nov 2019 19:37:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8113A2073F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E0F09893A8; Tue, 26 Nov 2019 19:37:44 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 01193893A8 for ; Tue, 26 Nov 2019 19:37:43 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id A99EE20053; Tue, 26 Nov 2019 20:37:41 +0100 (CET) Date: Tue, 26 Nov 2019 20:37:40 +0100 From: Sam Ravnborg To: Mihail Atanassov Subject: Re: [PATCH 28/30] drm/sti: sti_vdo: Use drm_bridge_init() Message-ID: <20191126193740.GC2044@ravnborg.org> References: <20191126131541.47393-1-mihail.atanassov@arm.com> <20191126131541.47393-29-mihail.atanassov@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191126131541.47393-29-mihail.atanassov@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7CQSdrXTAAAA:8 a=6lCv3_9TmdkNs-__4ugA:9 a=CjuIK1q_8ugA:10 a=a-qgeE7W1pNrGK8U0ZQC:22 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nd , Vincent Abriou , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191126193740.KwYLcsiQ8So6ILAGoqXhrReLtRO8Tb4osiM4fOB2CXk@z> SGkgTWloYWlsLgoKT24gVHVlLCBOb3YgMjYsIDIwMTkgYXQgMDE6MTY6MjZQTSArMDAwMCwgTWlo YWlsIEF0YW5hc3NvdiB3cm90ZToKPiBObyBmdW5jdGlvbmFsIGNoYW5nZS4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBNaWhhaWwgQXRhbmFzc292IDxtaWhhaWwuYXRhbmFzc292QGFybS5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2R2by5jIHwgNCArLS0tCj4gIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL3N0aS9zdGlfZHZvLmMgYi9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9kdm8u Ywo+IGluZGV4IDY4Mjg5YjBiMDYzYS4uMjBhMzk1NmIzM2JjIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9zdGkvc3RpX2R2by5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlf ZHZvLmMKPiBAQCAtNDYyLDkgKzQ2Miw3IEBAIHN0YXRpYyBpbnQgc3RpX2R2b19iaW5kKHN0cnVj dCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLCB2b2lkICpkYXRhKQo+ICAJaWYg KCFicmlkZ2UpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+IC0JYnJpZGdlLT5kcml2ZXJfcHJp dmF0ZSA9IGR2bzsKPiAtCWJyaWRnZS0+ZnVuY3MgPSAmc3RpX2R2b19icmlkZ2VfZnVuY3M7Cj4g LQlicmlkZ2UtPm9mX25vZGUgPSBkdm8tPmRldi5vZl9ub2RlOwo+ICsJZHJtX2JyaWRnZV9pbml0 KGJyaWRnZSwgJmR2by0+ZGV2LCAmc3RpX2R2b19icmlkZ2VfZnVuY3MsIE5VTEwsIGR2byk7Cj4g IAlkcm1fYnJpZGdlX2FkZChicmlkZ2UpOwo+ICAKPiAgCWVyciA9IGRybV9icmlkZ2VfYXR0YWNo KGVuY29kZXIsIGJyaWRnZSwgTlVMTCk7CgpJIGNhbiBzZWUgZnJvbSBncmVwcGluZyB0aGF0IGJy aWRnZS5kcml2ZXJfcHJpdmF0ZSBpcyB1c2VkCmluIGEgY291cGxlIG9mIG90aGVyIGZpbGVzIGlu IHN0aS8KCkxpa2Ugc3RpX2hkbWkuYzoKICAgICAgICBicmlkZ2UtPmRyaXZlcl9wcml2YXRlID0g aGRtaTsKICAgICAgICBicmlkZ2UtPmZ1bmNzID0gJnN0aV9oZG1pX2JyaWRnZV9mdW5jczsKICAg ICAgICBkcm1fYnJpZGdlX2F0dGFjaChlbmNvZGVyLCBicmlkZ2UsIE5VTEwpOwoKCkkgd29uZGVy IGlmIGEgZHJtX2JyaWRnZV9pbml0KCkgc2hvdWxkIGJlIGFkZGVkIHRoZXJlLgpJIGRpZCBub3Qg bG9vayBjbG9zZWx5IC0gYnV0IGl0IGxvb2tlZCBzdXNwaXNpb3VzbHkuCgoJU2FtCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==