From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>
Subject: [GIT PULL] x86/urgent fix for v5.5
Date: Tue, 26 Nov 2019 22:04:43 +0100 [thread overview]
Message-ID: <20191126210443.GA114386@gmail.com> (raw)
In-Reply-To: <20191126094554.GA3017@gmail.com>
* Ingo Molnar <mingo@kernel.org> wrote:
> > Forgot to list the conflicts that may arise if you merge this after the
> > other x86 bits.
> >
> > Firstly the symbol bits would conflict here:
> >
> > arch/x86/entry/entry_32.S
> > arch/x86/kernel/head_32.S
> > arch/x86/xen/xen-asm_32.S
>
> Note that these conflicts will arise once you merge x86-asm-for-linus,
> with an additional semantic conflict in arch/x86/crypto/blake2s-core.S,
> see my merge conflict mail to that pull request.
>
> > There's also a conflict in arch/x86/include/asm/pgtable_32_types.h.
>
> This asm/pgtable_32_types.h conflict will be the only conflict you'll see
> when you merge x86-iopl-for-linus:
>
> <<<<<<< HEAD
> #define CPU_ENTRY_AREA_PAGES (NR_CPUS * 39)
> =======
> #define CPU_ENTRY_AREA_PAGES (NR_CPUS * 41)
> >>>>>>> e3cb0c7102f04c83bf1a7cb1d052e92749310b46
>
> And the correct resolution is to pick the '41' side.
I missed one other semantic conflict that can result in build failures on
certain stripped down x86 32-bit configs, for example 32-bit
"allnoconfig" where CONFIG_X86_IOPL_IOPERM gets turned off.
Here's a (tested) fix for that:
Please pull the latest x86-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus
# HEAD: 0bcd7762727dd8ba9b9b6f828e5a4cbd5da4f725 x86/iopl: Make 'struct tss_struct' constant size again
Thanks,
Ingo
------------------>
Ingo Molnar (1):
x86/iopl: Make 'struct tss_struct' constant size again
arch/x86/include/asm/processor.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index b4e29d8b9e5a..e51afbb0cbfb 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -411,9 +411,7 @@ struct tss_struct {
*/
struct x86_hw_tss x86_tss;
-#ifdef CONFIG_X86_IOPL_IOPERM
struct x86_io_bitmap io_bitmap;
-#endif
} __aligned(PAGE_SIZE);
DECLARE_PER_CPU_PAGE_ALIGNED(struct tss_struct, cpu_tss_rw);
next prev parent reply other threads:[~2019-11-26 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:16 [GIT PULL] x86/iopl changes for v5.5 Ingo Molnar
2019-11-25 19:24 ` Ingo Molnar
2019-11-26 9:45 ` Ingo Molnar
2019-11-26 21:04 ` Ingo Molnar [this message]
2019-11-27 1:30 ` [GIT PULL] x86/urgent fix " pr-tracker-bot
2019-11-26 19:30 ` [GIT PULL] x86/iopl changes " pr-tracker-bot
2019-11-26 19:33 ` Linus Torvalds
2019-11-26 19:50 ` Ingo Molnar
2019-11-26 20:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126210443.GA114386@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.