All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH 1/2] AMD/IOMMU: Always print IOMMU errors
Date: Wed, 27 Nov 2019 10:19:10 +0100	[thread overview]
Message-ID: <20191127091910.GL980@Air-de-Roger> (raw)
In-Reply-To: <20191126150112.12704-2-andrew.cooper3@citrix.com>

On Tue, Nov 26, 2019 at 03:01:11PM +0000, Andrew Cooper wrote:
> Unhandled IOMMU errors (i.e. not IO_PAGE_FAULT) should still be printed, and
> not hidden behind iommu=debug.
> 
> While adjusting this, factor out the symbolic name handling to just one
> location exposing its off-by-one nature.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.comi>

LGTM:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I wonder however whether XENLOG_G_ERR should be used instead of
XENLOG_ERR in order to rate limit IOMMU faults triggered by guests.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-11-27  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 15:01 [Xen-devel] [PATCH for-4.13 0/2] Fixes to AMD IOMMU logging Andrew Cooper
2019-11-26 15:01 ` [Xen-devel] [PATCH 1/2] AMD/IOMMU: Always print IOMMU errors Andrew Cooper
2019-11-27  9:19   ` Roger Pau Monné [this message]
2019-11-27 16:58     ` Jan Beulich
2019-11-26 15:01 ` [Xen-devel] [PATCH 2/2] AMD/IOMMU: Render IO_PAGE_FAULT errors in a more useful manner Andrew Cooper
2019-11-27  9:40   ` Roger Pau Monné
2019-11-27 17:38     ` Andrew Cooper
2019-11-27 17:02   ` Jan Beulich
2019-11-27 17:03     ` Andrew Cooper
2019-11-26 15:36 ` [Xen-devel] [PATCH for-4.13 0/2] Fixes to AMD IOMMU logging Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127091910.GL980@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jgross@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.