From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: fix HDR static metadata type field numbering Date: Wed, 27 Nov 2019 17:17:03 +0200 Message-ID: <20191127151703.GJ1208@intel.com> References: <1574865719-24490-1-git-send-email-laurentiu.palcu@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1574865719-24490-1-git-send-email-laurentiu.palcu@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Laurentiu Palcu Cc: Uma Shankar , "dri-devel@lists.freedesktop.org" , Daniel Vetter , "linux-kernel@vger.kernel.org" , dl-linux-imx List-Id: dri-devel@lists.freedesktop.org On Wed, Nov 27, 2019 at 02:42:35PM +0000, Laurentiu Palcu wrote: > According to CTA-861 specification, HDR static metadata data block allows a > sink to indicate which HDR metadata types it supports by setting the SM_0 to > SM_7 bits. Currently, only Static Metadata Type 1 is supported and this is > indicated by setting the SM_0 bit to 1. > > However, the connector->hdr_sink_metadata.hdmi_type1.metadata_type is always > 0, because hdr_metadata_type() in drm_edid.c checks the wrong bit. > > This patch corrects the HDMI_STATIC_METADATA_TYPE1 bit position. Was confused for a while why this has even been workning, but I guess that's due to userspace populating the metadata infoframe blob correctly even if we misreported the metadata types in the parsed EDID metadata blob. Hmm. Actually on further inspection this all seems to be dead code. The only thing we seem to use from the parsed EDID metadata stuff is eotf bitmask. We check that in drm_hdmi_infoframe_set_hdr_metadata() but we don't check the metadata type. Maybe we should just nuke this EDID parsing stuff entirely? Seems pretty much pointless. > > Signed-off-by: Laurentiu Palcu > --- > include/linux/hdmi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h > index 9918a6c..216e25e 100644 > --- a/include/linux/hdmi.h > +++ b/include/linux/hdmi.h > @@ -155,7 +155,7 @@ enum hdmi_content_type { > }; > > enum hdmi_metadata_type { > - HDMI_STATIC_METADATA_TYPE1 = 1, > + HDMI_STATIC_METADATA_TYPE1 = 0, > }; > > enum hdmi_eotf { > -- > 2.7.4 -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80BB3C432C3 for ; Wed, 27 Nov 2019 15:17:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FAB62075C for ; Wed, 27 Nov 2019 15:17:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FAB62075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBA906E31D; Wed, 27 Nov 2019 15:17:09 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB6596E31D for ; Wed, 27 Nov 2019 15:17:07 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2019 07:17:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,249,1571727600"; d="scan'208";a="221009990" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 27 Nov 2019 07:17:03 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 27 Nov 2019 17:17:03 +0200 Date: Wed, 27 Nov 2019 17:17:03 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Laurentiu Palcu Subject: Re: [PATCH] drm: fix HDR static metadata type field numbering Message-ID: <20191127151703.GJ1208@intel.com> References: <1574865719-24490-1-git-send-email-laurentiu.palcu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1574865719-24490-1-git-send-email-laurentiu.palcu@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Uma Shankar , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , dl-linux-imx Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191127151703.hZmnS3UnHTgceuQ4wGsGKZ2Y9OVoTjXSOUw99HX77bo@z> T24gV2VkLCBOb3YgMjcsIDIwMTkgYXQgMDI6NDI6MzVQTSArMDAwMCwgTGF1cmVudGl1IFBhbGN1 IHdyb3RlOgo+IEFjY29yZGluZyB0byBDVEEtODYxIHNwZWNpZmljYXRpb24sIEhEUiBzdGF0aWMg bWV0YWRhdGEgZGF0YSBibG9jayBhbGxvd3MgYQo+IHNpbmsgdG8gaW5kaWNhdGUgd2hpY2ggSERS IG1ldGFkYXRhIHR5cGVzIGl0IHN1cHBvcnRzIGJ5IHNldHRpbmcgdGhlIFNNXzAgdG8KPiBTTV83 IGJpdHMuIEN1cnJlbnRseSwgb25seSBTdGF0aWMgTWV0YWRhdGEgVHlwZSAxIGlzIHN1cHBvcnRl ZCBhbmQgdGhpcyBpcwo+IGluZGljYXRlZCBieSBzZXR0aW5nIHRoZSBTTV8wIGJpdCB0byAxLgo+ IAo+IEhvd2V2ZXIsIHRoZSBjb25uZWN0b3ItPmhkcl9zaW5rX21ldGFkYXRhLmhkbWlfdHlwZTEu bWV0YWRhdGFfdHlwZSBpcyBhbHdheXMKPiAwLCBiZWNhdXNlIGhkcl9tZXRhZGF0YV90eXBlKCkg aW4gZHJtX2VkaWQuYyBjaGVja3MgdGhlIHdyb25nIGJpdC4KPiAKPiBUaGlzIHBhdGNoIGNvcnJl Y3RzIHRoZSBIRE1JX1NUQVRJQ19NRVRBREFUQV9UWVBFMSBiaXQgcG9zaXRpb24uCgpXYXMgY29u ZnVzZWQgZm9yIGEgd2hpbGUgd2h5IHRoaXMgaGFzIGV2ZW4gYmVlbiB3b3JrbmluZywgYnV0IEkg Z3Vlc3MgCnRoYXQncyBkdWUgdG8gdXNlcnNwYWNlIHBvcHVsYXRpbmcgdGhlIG1ldGFkYXRhIGlu Zm9mcmFtZSBibG9iIGNvcnJlY3RseQpldmVuIGlmIHdlIG1pc3JlcG9ydGVkIHRoZSBtZXRhZGF0 YSB0eXBlcyBpbiB0aGUgcGFyc2VkIEVESUQgbWV0YWRhdGEKYmxvYi4KCkhtbS4gQWN0dWFsbHkg b24gZnVydGhlciBpbnNwZWN0aW9uIHRoaXMgYWxsIHNlZW1zIHRvIGJlIGRlYWQgY29kZS4gVGhl Cm9ubHkgdGhpbmcgd2Ugc2VlbSB0byB1c2UgZnJvbSB0aGUgcGFyc2VkIEVESUQgbWV0YWRhdGEg c3R1ZmYgaXMKZW90ZiBiaXRtYXNrLiBXZSBjaGVjayB0aGF0IGluIGRybV9oZG1pX2luZm9mcmFt ZV9zZXRfaGRyX21ldGFkYXRhKCkKYnV0IHdlIGRvbid0IGNoZWNrIHRoZSBtZXRhZGF0YSB0eXBl LgoKTWF5YmUgd2Ugc2hvdWxkIGp1c3QgbnVrZSB0aGlzIEVESUQgcGFyc2luZyBzdHVmZiBlbnRp cmVseT8gU2VlbXMKcHJldHR5IG11Y2ggcG9pbnRsZXNzLgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBM YXVyZW50aXUgUGFsY3UgPGxhdXJlbnRpdS5wYWxjdUBueHAuY29tPgo+IC0tLQo+ICBpbmNsdWRl L2xpbnV4L2hkbWkuaCB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaGRtaS5oIGIvaW5j bHVkZS9saW51eC9oZG1pLmgKPiBpbmRleCA5OTE4YTZjLi4yMTZlMjVlIDEwMDY0NAo+IC0tLSBh L2luY2x1ZGUvbGludXgvaGRtaS5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9oZG1pLmgKPiBAQCAt MTU1LDcgKzE1NSw3IEBAIGVudW0gaGRtaV9jb250ZW50X3R5cGUgewo+ICB9Owo+ICAKPiAgZW51 bSBoZG1pX21ldGFkYXRhX3R5cGUgewo+IC0JSERNSV9TVEFUSUNfTUVUQURBVEFfVFlQRTEgPSAx LAo+ICsJSERNSV9TVEFUSUNfTUVUQURBVEFfVFlQRTEgPSAwLAo+ICB9Owo+ICAKPiAgZW51bSBo ZG1pX2VvdGYgewo+IC0tIAo+IDIuNy40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==