From: Ard Biesheuvel <ardb@kernel.org>
To: linux-usb@vger.kernel.org
Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org,
Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH] xhci: enable XHCI_TRUST_TX_LENGTH quirk for ThunderX2 builtin hosts
Date: Wed, 27 Nov 2019 16:30:15 +0100 [thread overview]
Message-ID: <20191127153015.58171-1-ardb@kernel.org> (raw)
When using a USB webcam on a ThunderX2 workstation, the kernel log
gets flooded with messages like
xhci_hcd 0000:00:0f.0:
WARN Successful completion on short TX for slot 7 ep 2: needs XHCI_TRUST_TX_LENGTH quirk?
Enabling the quirk manually makes the issue go away, so let's enable
it unconditionally for this hardware.
Cc: <stable@vger.kernel.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
drivers/usb/host/xhci-pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 1e0236e90687..331b5900dd72 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -256,7 +256,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
if ((pdev->vendor == PCI_VENDOR_ID_BROADCOM ||
pdev->vendor == PCI_VENDOR_ID_CAVIUM) &&
pdev->device == 0x9026)
- xhci->quirks |= XHCI_RESET_PLL_ON_DISCONNECT;
+ xhci->quirks |= XHCI_RESET_PLL_ON_DISCONNECT |
+ XHCI_TRUST_TX_LENGTH;
if (xhci->quirks & XHCI_RESET_ON_RESUME)
xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
--
2.20.1
next reply other threads:[~2019-11-27 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 15:30 Ard Biesheuvel [this message]
2019-11-27 15:58 ` [PATCH] xhci: enable XHCI_TRUST_TX_LENGTH quirk for ThunderX2 builtin hosts Mathias Nyman
2019-11-27 16:16 ` Ard Biesheuvel
2019-11-28 14:36 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127153015.58171-1-ardb@kernel.org \
--to=ardb@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.