From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9103C432C0 for ; Wed, 27 Nov 2019 15:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA1B520665 for ; Wed, 27 Nov 2019 15:46:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbfK0PqB (ORCPT ); Wed, 27 Nov 2019 10:46:01 -0500 Received: from muru.com ([72.249.23.125]:43714 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfK0PqB (ORCPT ); Wed, 27 Nov 2019 10:46:01 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5BF508102; Wed, 27 Nov 2019 15:46:37 +0000 (UTC) Date: Wed, 27 Nov 2019 07:45:56 -0800 From: Tony Lindgren To: Tomi Valkeinen Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Thierry Reding , Laurent Pinchart , Jyri Sarha , Peter Ujfalusi Subject: Re: [PATCH 0/3] drm/omap: fix am4 evm lcd Message-ID: <20191127154556.GI43123@atomide.com> References: <20191114093950.4101-1-tomi.valkeinen@ti.com> <52608d4e-dd67-1232-41e7-e6d0cba58783@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52608d4e-dd67-1232-41e7-e6d0cba58783@ti.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi * Tomi Valkeinen [191127 12:59]: > Hi Tony, Thierry, Laurent, > > Any thoughts on the below points? > I think yet another option is to write some omap boot time quirks code, > which looks at the DT data, and changes the panel compatible string (for 1), > and removes the timings node (for 2). Nah, seems we can just update the compatible. > On 14/11/2019 11:39, Tomi Valkeinen wrote: > > 1) Panel driver is not probed. With omapdrm's panel-dpi, the match > > happened with "panel-dpi" compatible string. Now with panel-simple, the > > match should happen with the panel model compatible string, which is > > "osddisplays,osd057T0559-34ts" in the DT file. However, no such > > compatible exists in panel-simple. > > > > Interestingly, the actual panel at least on my EVMs and ePOSes is not > > osd057T0559-34ts, but osd070t1718-19ts. Also, I was unable to find any > > information about osd057T0559-34ts. I don't know the history with this, > > so it is possible that the early versions of the boards did have > > osd057T0559-34ts, but was later changed to osd070t1718-19ts. I guess you could keep the old compatible there too if really needed. But then again if the old compatible is known to be incorrect, it should be just updated. So it looks good to me for the dts changes. Do you want me to pick them into fixes as it seems that the panel driver fix is a separate issue? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 0/3] drm/omap: fix am4 evm lcd Date: Wed, 27 Nov 2019 07:45:56 -0800 Message-ID: <20191127154556.GI43123@atomide.com> References: <20191114093950.4101-1-tomi.valkeinen@ti.com> <52608d4e-dd67-1232-41e7-e6d0cba58783@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FF716E31E for ; Wed, 27 Nov 2019 15:46:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <52608d4e-dd67-1232-41e7-e6d0cba58783@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Jyri Sarha , Peter Ujfalusi , Thierry Reding , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org SGkKCiogVG9taSBWYWxrZWluZW4gPHRvbWkudmFsa2VpbmVuQHRpLmNvbT4gWzE5MTEyNyAxMjo1 OV06Cj4gSGkgVG9ueSwgVGhpZXJyeSwgTGF1cmVudCwKPiAKPiBBbnkgdGhvdWdodHMgb24gdGhl IGJlbG93IHBvaW50cz8KCj4gSSB0aGluayB5ZXQgYW5vdGhlciBvcHRpb24gaXMgdG8gd3JpdGUg c29tZSBvbWFwIGJvb3QgdGltZSBxdWlya3MgY29kZSwKPiB3aGljaCBsb29rcyBhdCB0aGUgRFQg ZGF0YSwgYW5kIGNoYW5nZXMgdGhlIHBhbmVsIGNvbXBhdGlibGUgc3RyaW5nIChmb3IgMSksCj4g YW5kIHJlbW92ZXMgdGhlIHRpbWluZ3Mgbm9kZSAoZm9yIDIpLgoKTmFoLCBzZWVtcyB3ZSBjYW4g anVzdCB1cGRhdGUgdGhlIGNvbXBhdGlibGUuCgo+IE9uIDE0LzExLzIwMTkgMTE6MzksIFRvbWkg VmFsa2VpbmVuIHdyb3RlOgo+ID4gMSkgUGFuZWwgZHJpdmVyIGlzIG5vdCBwcm9iZWQuIFdpdGgg b21hcGRybSdzIHBhbmVsLWRwaSwgdGhlIG1hdGNoCj4gPiBoYXBwZW5lZCB3aXRoICJwYW5lbC1k cGkiIGNvbXBhdGlibGUgc3RyaW5nLiBOb3cgd2l0aCBwYW5lbC1zaW1wbGUsIHRoZQo+ID4gbWF0 Y2ggc2hvdWxkIGhhcHBlbiB3aXRoIHRoZSBwYW5lbCBtb2RlbCBjb21wYXRpYmxlIHN0cmluZywg d2hpY2ggaXMKPiA+ICJvc2RkaXNwbGF5cyxvc2QwNTdUMDU1OS0zNHRzIiBpbiB0aGUgRFQgZmls ZS4gSG93ZXZlciwgbm8gc3VjaAo+ID4gY29tcGF0aWJsZSBleGlzdHMgaW4gcGFuZWwtc2ltcGxl Lgo+ID4KPiA+IEludGVyZXN0aW5nbHksIHRoZSBhY3R1YWwgcGFuZWwgYXQgbGVhc3Qgb24gbXkg RVZNcyBhbmQgZVBPU2VzIGlzIG5vdAo+ID4gb3NkMDU3VDA1NTktMzR0cywgYnV0IG9zZDA3MHQx NzE4LTE5dHMuIEFsc28sIEkgd2FzIHVuYWJsZSB0byBmaW5kIGFueQo+ID4gaW5mb3JtYXRpb24g YWJvdXQgb3NkMDU3VDA1NTktMzR0cy4gSSBkb24ndCBrbm93IHRoZSBoaXN0b3J5IHdpdGggdGhp cywKPiA+IHNvIGl0IGlzIHBvc3NpYmxlIHRoYXQgdGhlIGVhcmx5IHZlcnNpb25zIG9mIHRoZSBi b2FyZHMgZGlkIGhhdmUKPiA+IG9zZDA1N1QwNTU5LTM0dHMsIGJ1dCB3YXMgbGF0ZXIgY2hhbmdl ZCB0byBvc2QwNzB0MTcxOC0xOXRzLgoKSSBndWVzcyB5b3UgY291bGQga2VlcCB0aGUgb2xkIGNv bXBhdGlibGUgdGhlcmUgdG9vIGlmIHJlYWxseSBuZWVkZWQuCkJ1dCB0aGVuIGFnYWluIGlmIHRo ZSBvbGQgY29tcGF0aWJsZSBpcyBrbm93biB0byBiZSBpbmNvcnJlY3QsIGl0CnNob3VsZCBiZSBq dXN0IHVwZGF0ZWQuCgpTbyBpdCBsb29rcyBnb29kIHRvIG1lIGZvciB0aGUgZHRzIGNoYW5nZXMu IERvIHlvdSB3YW50IG1lIHRvIHBpY2sKdGhlbSBpbnRvIGZpeGVzIGFzIGl0IHNlZW1zIHRoYXQg dGhlIHBhbmVsIGRyaXZlciBmaXggaXMgYSBzZXBhcmF0ZQppc3N1ZT8KClJlZ2FyZHMsCgpUb255 Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==