From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 28/30] drm/sti: sti_vdo: Use drm_bridge_init() Date: Wed, 27 Nov 2019 17:19:07 +0100 Message-ID: <20191127161907.GA17176@ravnborg.org> References: <20191126131541.47393-1-mihail.atanassov@arm.com> <20191126131541.47393-29-mihail.atanassov@arm.com> <20191126193740.GC2044@ravnborg.org> <2161383.jsAorMfJJG@e123338-lin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2161383.jsAorMfJJG@e123338-lin> Sender: linux-kernel-owner@vger.kernel.org To: Mihail Atanassov Cc: nd , "dri-devel@lists.freedesktop.org" , David Airlie , "linux-kernel@vger.kernel.org" , Vincent Abriou List-Id: dri-devel@lists.freedesktop.org Hi Mihail. > > > > I can see from grepping that bridge.driver_private is used > > in a couple of other files in sti/ > > > > Like sti_hdmi.c: > > bridge->driver_private = hdmi; > > bridge->funcs = &sti_hdmi_bridge_funcs; > > drm_bridge_attach(encoder, bridge, NULL); > > > > > > I wonder if a drm_bridge_init() should be added there. > > I did not look closely - but it looked suspisiously. > > My goal with drm_bridge_init() was to get devlinks sorted out for > cross-module uses of a drm_bridge (via of_drm_find_bridge()), so I only > considered locations where drm_bridge_add/remove() were used. > > Would you be okay with a promise to push a cleanup of this one and the > one in sti_hda.c after patch 1/30 lands in some form? I'd rather not > make this series much longer, it's already pushing it at 30 :). Absolutely - my drive-by comment was more out of concern if this was missing. A clean-up later souns good. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D85EC432C3 for ; Wed, 27 Nov 2019 16:19:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 676C620684 for ; Wed, 27 Nov 2019 16:19:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 676C620684 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD1CD6E0EA; Wed, 27 Nov 2019 16:19:14 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id C04CD6E0EA for ; Wed, 27 Nov 2019 16:19:12 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 562EA80503; Wed, 27 Nov 2019 17:19:09 +0100 (CET) Date: Wed, 27 Nov 2019 17:19:07 +0100 From: Sam Ravnborg To: Mihail Atanassov Subject: Re: [PATCH 28/30] drm/sti: sti_vdo: Use drm_bridge_init() Message-ID: <20191127161907.GA17176@ravnborg.org> References: <20191126131541.47393-1-mihail.atanassov@arm.com> <20191126131541.47393-29-mihail.atanassov@arm.com> <20191126193740.GC2044@ravnborg.org> <2161383.jsAorMfJJG@e123338-lin> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2161383.jsAorMfJJG@e123338-lin> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=anWFpgVYN7cw7xR4DrkA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nd , Vincent Abriou , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191127161907.zqlWNgQikoBBGZDGR_rYaKouW6IqmN6BNQYVqh4EsUY@z> SGkgTWloYWlsLgoKPiA+IAo+ID4gSSBjYW4gc2VlIGZyb20gZ3JlcHBpbmcgdGhhdCBicmlkZ2Uu ZHJpdmVyX3ByaXZhdGUgaXMgdXNlZAo+ID4gaW4gYSBjb3VwbGUgb2Ygb3RoZXIgZmlsZXMgaW4g c3RpLwo+ID4gCj4gPiBMaWtlIHN0aV9oZG1pLmM6Cj4gPiAgICAgICAgIGJyaWRnZS0+ZHJpdmVy X3ByaXZhdGUgPSBoZG1pOwo+ID4gICAgICAgICBicmlkZ2UtPmZ1bmNzID0gJnN0aV9oZG1pX2Jy aWRnZV9mdW5jczsKPiA+ICAgICAgICAgZHJtX2JyaWRnZV9hdHRhY2goZW5jb2RlciwgYnJpZGdl LCBOVUxMKTsKPiA+IAo+ID4gCj4gPiBJIHdvbmRlciBpZiBhIGRybV9icmlkZ2VfaW5pdCgpIHNo b3VsZCBiZSBhZGRlZCB0aGVyZS4KPiA+IEkgZGlkIG5vdCBsb29rIGNsb3NlbHkgLSBidXQgaXQg bG9va2VkIHN1c3Bpc2lvdXNseS4KPiAKPiBNeSBnb2FsIHdpdGggZHJtX2JyaWRnZV9pbml0KCkg d2FzIHRvIGdldCBkZXZsaW5rcyBzb3J0ZWQgb3V0IGZvcgo+IGNyb3NzLW1vZHVsZSB1c2VzIG9m IGEgZHJtX2JyaWRnZSAodmlhIG9mX2RybV9maW5kX2JyaWRnZSgpKSwgc28gSSBvbmx5Cj4gY29u c2lkZXJlZCBsb2NhdGlvbnMgd2hlcmUgZHJtX2JyaWRnZV9hZGQvcmVtb3ZlKCkgd2VyZSB1c2Vk Lgo+IAo+IFdvdWxkIHlvdSBiZSBva2F5IHdpdGggYSBwcm9taXNlIHRvIHB1c2ggYSBjbGVhbnVw IG9mIHRoaXMgb25lIGFuZCB0aGUKPiBvbmUgaW4gc3RpX2hkYS5jIGFmdGVyIHBhdGNoIDEvMzAg bGFuZHMgaW4gc29tZSBmb3JtPyBJJ2QgcmF0aGVyIG5vdAo+IG1ha2UgdGhpcyBzZXJpZXMgbXVj aCBsb25nZXIsIGl0J3MgYWxyZWFkeSBwdXNoaW5nIGl0IGF0IDMwIDopLgoKQWJzb2x1dGVseSAt IG15IGRyaXZlLWJ5IGNvbW1lbnQgd2FzIG1vcmUgb3V0IG9mIGNvbmNlcm4gaWYgdGhpcwp3YXMg bWlzc2luZy4gQSBjbGVhbi11cCBsYXRlciBzb3VucyBnb29kLgoKCVNhbQpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=