From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Date: Wed, 27 Nov 2019 17:01:16 +0000 Subject: Re: [PATCH 01/13] video: fb_defio: preserve user fb_ops Message-Id: <20191127170116.GK1208@intel.com> List-Id: References: <448995ffd954e0cd2287089cb686e351cc095834.1574871797.git.jani.nikula@intel.com> In-Reply-To: <448995ffd954e0cd2287089cb686e351cc095834.1574871797.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Jani Nikula Cc: linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Jaya Kumar On Wed, Nov 27, 2019 at 06:31:57PM +0200, Jani Nikula wrote: > Modifying fb_ops directly to override fb_mmap with fb_deferred_io_mmap > and then resetting it to NULL afterwards causes problems all over the > place. First, it prevents making the fbops member of struct fb_info a > const pointer, which means we can't make struct fb_ops const > anywhere. Second, a few places have to go out of their way to restore > the original fb_mmap pointer that gets reset to NULL. >=20 > Preserve the passed in fb_ops by making a copy of it and modifying that > instead. Add a deferred_io_private member to struct fb_info to store the > pointer to the old fb_ops, and restore that at cleanup. Quite the horror show. I wonder how hard it would be to just have each driver that can use defio provide a mmap hook that either dispatches to the defio one or the native one depending if defio is used or not... A few drivers at least seem to always use defio so those should be trivial. Some others seem to make the decision dynamically, which would require custom .mmap(). Though I suppose all of them could just be of the form foo_mmap_wrap{) { if (info->defio) defio_mmap() else foo_mmap(); } Hmm. Actually is .fb_mmap() called from anywhere but fb_mmap()? If not we could just shove the defio check there? Or if it's called from several places we could try to wrap all calls in _fb_mmap() or somesuch. >=20 > Cc: Jaya Kumar > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Jani Nikula >=20 > --- >=20 > Note: If the approach is acceptable, we'll also need to handle the error > returns on memory allocation failures at fb_deferred_io_init() call > sites. There are 13. > --- > drivers/video/fbdev/core/fb_defio.c | 25 ++++++++++++++++++++++--- > include/linux/fb.h | 3 ++- > 2 files changed, 24 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/co= re/fb_defio.c > index 82c20c6047b0..36697844c1e0 100644 > --- a/drivers/video/fbdev/core/fb_defio.c > +++ b/drivers/video/fbdev/core/fb_defio.c > @@ -200,13 +200,23 @@ static void fb_deferred_io_work(struct work_struct = *work) > mutex_unlock(&fbdefio->lock); > } > =20 > -void fb_deferred_io_init(struct fb_info *info) > +int fb_deferred_io_init(struct fb_info *info) > { > struct fb_deferred_io *fbdefio =3D info->fbdefio; > + struct fb_ops *fbops; > =20 > BUG_ON(!fbdefio); > + > + fbops =3D kmemdup(info->fbops, sizeof(*fbops), GFP_KERNEL); > + if (!fbops) > + return -ENOMEM; > + > + fbops->fb_mmap =3D fb_deferred_io_mmap; > + info->deferred_io_private =3D info->fbops; > + info->fbops =3D fbops; > + > mutex_init(&fbdefio->lock); > - info->fbops->fb_mmap =3D fb_deferred_io_mmap; > + > INIT_DELAYED_WORK(&info->deferred_work, fb_deferred_io_work); > INIT_LIST_HEAD(&fbdefio->pagelist); > if (fbdefio->delay =3D 0) /* set a default of 1 s */ > @@ -229,6 +239,12 @@ void fb_deferred_io_cleanup(struct fb_info *info) > int i; > =20 > BUG_ON(!fbdefio); > + > + /* sanity check against misuse */ > + if (WARN_ON(!info->deferred_io_private || > + info->fbops->fb_mmap !=3D fb_deferred_io_mmap)) > + return; > + > cancel_delayed_work_sync(&info->deferred_work); > =20 > /* clear out the mapping that we setup */ > @@ -237,7 +253,10 @@ void fb_deferred_io_cleanup(struct fb_info *info) > page->mapping =3D NULL; > } > =20 > - info->fbops->fb_mmap =3D NULL; > + kfree(info->fbops); > + info->fbops =3D info->deferred_io_private; > + info->deferred_io_private =3D NULL; > + > mutex_destroy(&fbdefio->lock); > } > EXPORT_SYMBOL_GPL(fb_deferred_io_cleanup); > diff --git a/include/linux/fb.h b/include/linux/fb.h > index a6ad528990de..65f2abd47745 100644 > --- a/include/linux/fb.h > +++ b/include/linux/fb.h > @@ -470,6 +470,7 @@ struct fb_info { > #ifdef CONFIG_FB_DEFERRED_IO > struct delayed_work deferred_work; > struct fb_deferred_io *fbdefio; > + void *deferred_io_private; > #endif > =20 > struct fb_ops *fbops; > @@ -658,7 +659,7 @@ static inline void __fb_pad_aligned_buffer(u8 *dst, u= 32 d_pitch, > =20 > /* drivers/video/fb_defio.c */ > int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma= ); > -extern void fb_deferred_io_init(struct fb_info *info); > +extern int fb_deferred_io_init(struct fb_info *info); > extern void fb_deferred_io_open(struct fb_info *info, > struct inode *inode, > struct file *file); > --=20 > 2.20.1 --=20 Ville Syrj=E4l=E4 Intel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 01/13] video: fb_defio: preserve user fb_ops Date: Wed, 27 Nov 2019 19:01:16 +0200 Message-ID: <20191127170116.GK1208@intel.com> References: <448995ffd954e0cd2287089cb686e351cc095834.1574871797.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <448995ffd954e0cd2287089cb686e351cc095834.1574871797.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Jaya Kumar List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMjcsIDIwMTkgYXQgMDY6MzE6NTdQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gTW9kaWZ5aW5nIGZiX29wcyBkaXJlY3RseSB0byBvdmVycmlkZSBmYl9tbWFwIHdpdGgg ZmJfZGVmZXJyZWRfaW9fbW1hcAo+IGFuZCB0aGVuIHJlc2V0dGluZyBpdCB0byBOVUxMIGFmdGVy d2FyZHMgY2F1c2VzIHByb2JsZW1zIGFsbCBvdmVyIHRoZQo+IHBsYWNlLiBGaXJzdCwgaXQgcHJl dmVudHMgbWFraW5nIHRoZSBmYm9wcyBtZW1iZXIgb2Ygc3RydWN0IGZiX2luZm8gYQo+IGNvbnN0 IHBvaW50ZXIsIHdoaWNoIG1lYW5zIHdlIGNhbid0IG1ha2Ugc3RydWN0IGZiX29wcyBjb25zdAo+ IGFueXdoZXJlLiBTZWNvbmQsIGEgZmV3IHBsYWNlcyBoYXZlIHRvIGdvIG91dCBvZiB0aGVpciB3 YXkgdG8gcmVzdG9yZQo+IHRoZSBvcmlnaW5hbCBmYl9tbWFwIHBvaW50ZXIgdGhhdCBnZXRzIHJl c2V0IHRvIE5VTEwuCj4gCj4gUHJlc2VydmUgdGhlIHBhc3NlZCBpbiBmYl9vcHMgYnkgbWFraW5n IGEgY29weSBvZiBpdCBhbmQgbW9kaWZ5aW5nIHRoYXQKPiBpbnN0ZWFkLiBBZGQgYSBkZWZlcnJl ZF9pb19wcml2YXRlIG1lbWJlciB0byBzdHJ1Y3QgZmJfaW5mbyB0byBzdG9yZSB0aGUKPiBwb2lu dGVyIHRvIHRoZSBvbGQgZmJfb3BzLCBhbmQgcmVzdG9yZSB0aGF0IGF0IGNsZWFudXAuCgpRdWl0 ZSB0aGUgaG9ycm9yIHNob3cuIEkgd29uZGVyIGhvdyBoYXJkIGl0IHdvdWxkIGJlIHRvIGp1c3Qg aGF2ZSBlYWNoCmRyaXZlciB0aGF0IGNhbiB1c2UgZGVmaW8gcHJvdmlkZSBhIG1tYXAgaG9vayB0 aGF0IGVpdGhlciBkaXNwYXRjaGVzCnRvIHRoZSBkZWZpbyBvbmUgb3IgdGhlIG5hdGl2ZSBvbmUg ZGVwZW5kaW5nIGlmIGRlZmlvIGlzIHVzZWQgb3Igbm90Li4uCgpBIGZldyBkcml2ZXJzIGF0IGxl YXN0IHNlZW0gdG8gYWx3YXlzIHVzZSBkZWZpbyBzbyB0aG9zZSBzaG91bGQgYmUKdHJpdmlhbC4g U29tZSBvdGhlcnMgc2VlbSB0byBtYWtlIHRoZSBkZWNpc2lvbiBkeW5hbWljYWxseSwgd2hpY2gK d291bGQgcmVxdWlyZSBjdXN0b20gLm1tYXAoKS4gVGhvdWdoIEkgc3VwcG9zZSBhbGwgb2YgdGhl bSBjb3VsZCBqdXN0CmJlIG9mIHRoZSBmb3JtCmZvb19tbWFwX3dyYXB7KQp7CglpZiAoaW5mby0+ ZGVmaW8pCgkJZGVmaW9fbW1hcCgpCgllbHNlCgkJZm9vX21tYXAoKTsKfQoKSG1tLiBBY3R1YWxs eSBpcyAuZmJfbW1hcCgpIGNhbGxlZCBmcm9tIGFueXdoZXJlIGJ1dCBmYl9tbWFwKCk/IElmIG5v dAp3ZSBjb3VsZCBqdXN0IHNob3ZlIHRoZSBkZWZpbyBjaGVjayB0aGVyZT8gT3IgaWYgaXQncyBj YWxsZWQgZnJvbQpzZXZlcmFsIHBsYWNlcyB3ZSBjb3VsZCB0cnkgdG8gd3JhcCBhbGwgY2FsbHMg aW4gX2ZiX21tYXAoKSBvciBzb21lc3VjaC4KCj4gCj4gQ2M6IEpheWEgS3VtYXIgPGpheWFsa0Bp bnR3b3Jrcy5iaXo+Cj4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZwo+IFNpZ25lZC1v ZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gCj4gLS0tCj4gCj4g Tm90ZTogSWYgdGhlIGFwcHJvYWNoIGlzIGFjY2VwdGFibGUsIHdlJ2xsIGFsc28gbmVlZCB0byBo YW5kbGUgdGhlIGVycm9yCj4gcmV0dXJucyBvbiBtZW1vcnkgYWxsb2NhdGlvbiBmYWlsdXJlcyBh dCBmYl9kZWZlcnJlZF9pb19pbml0KCkgY2FsbAo+IHNpdGVzLiBUaGVyZSBhcmUgMTMuCj4gLS0t Cj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jIHwgMjUgKysrKysrKysrKysr KysrKysrKysrKy0tLQo+ICBpbmNsdWRlL2xpbnV4L2ZiLmggICAgICAgICAgICAgICAgICB8ICAz ICsrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jIGIv ZHJpdmVycy92aWRlby9mYmRldi9jb3JlL2ZiX2RlZmlvLmMKPiBpbmRleCA4MmMyMGM2MDQ3YjAu LjM2Njk3ODQ0YzFlMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJf ZGVmaW8uYwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jCj4gQEAg LTIwMCwxMyArMjAwLDIzIEBAIHN0YXRpYyB2b2lkIGZiX2RlZmVycmVkX2lvX3dvcmsoc3RydWN0 IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJbXV0ZXhfdW5sb2NrKCZmYmRlZmlvLT5sb2NrKTsKPiAg fQo+ICAKPiAtdm9pZCBmYl9kZWZlcnJlZF9pb19pbml0KHN0cnVjdCBmYl9pbmZvICppbmZvKQo+ ICtpbnQgZmJfZGVmZXJyZWRfaW9faW5pdChzdHJ1Y3QgZmJfaW5mbyAqaW5mbykKPiAgewo+ICAJ c3RydWN0IGZiX2RlZmVycmVkX2lvICpmYmRlZmlvID0gaW5mby0+ZmJkZWZpbzsKPiArCXN0cnVj dCBmYl9vcHMgKmZib3BzOwo+ICAKPiAgCUJVR19PTighZmJkZWZpbyk7Cj4gKwo+ICsJZmJvcHMg PSBrbWVtZHVwKGluZm8tPmZib3BzLCBzaXplb2YoKmZib3BzKSwgR0ZQX0tFUk5FTCk7Cj4gKwlp ZiAoIWZib3BzKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCWZib3BzLT5mYl9tbWFwID0g ZmJfZGVmZXJyZWRfaW9fbW1hcDsKPiArCWluZm8tPmRlZmVycmVkX2lvX3ByaXZhdGUgPSBpbmZv LT5mYm9wczsKPiArCWluZm8tPmZib3BzID0gZmJvcHM7Cj4gKwo+ICAJbXV0ZXhfaW5pdCgmZmJk ZWZpby0+bG9jayk7Cj4gLQlpbmZvLT5mYm9wcy0+ZmJfbW1hcCA9IGZiX2RlZmVycmVkX2lvX21t YXA7Cj4gKwo+ICAJSU5JVF9ERUxBWUVEX1dPUksoJmluZm8tPmRlZmVycmVkX3dvcmssIGZiX2Rl ZmVycmVkX2lvX3dvcmspOwo+ICAJSU5JVF9MSVNUX0hFQUQoJmZiZGVmaW8tPnBhZ2VsaXN0KTsK PiAgCWlmIChmYmRlZmlvLT5kZWxheSA9PSAwKSAvKiBzZXQgYSBkZWZhdWx0IG9mIDEgcyAqLwo+ IEBAIC0yMjksNiArMjM5LDEyIEBAIHZvaWQgZmJfZGVmZXJyZWRfaW9fY2xlYW51cChzdHJ1Y3Qg ZmJfaW5mbyAqaW5mbykKPiAgCWludCBpOwo+ICAKPiAgCUJVR19PTighZmJkZWZpbyk7Cj4gKwo+ ICsJLyogc2FuaXR5IGNoZWNrIGFnYWluc3QgbWlzdXNlICovCj4gKwlpZiAoV0FSTl9PTighaW5m by0+ZGVmZXJyZWRfaW9fcHJpdmF0ZSB8fAo+ICsJCSAgICBpbmZvLT5mYm9wcy0+ZmJfbW1hcCAh PSBmYl9kZWZlcnJlZF9pb19tbWFwKSkKPiArCQlyZXR1cm47Cj4gKwo+ICAJY2FuY2VsX2RlbGF5 ZWRfd29ya19zeW5jKCZpbmZvLT5kZWZlcnJlZF93b3JrKTsKPiAgCj4gIAkvKiBjbGVhciBvdXQg dGhlIG1hcHBpbmcgdGhhdCB3ZSBzZXR1cCAqLwo+IEBAIC0yMzcsNyArMjUzLDEwIEBAIHZvaWQg ZmJfZGVmZXJyZWRfaW9fY2xlYW51cChzdHJ1Y3QgZmJfaW5mbyAqaW5mbykKPiAgCQlwYWdlLT5t YXBwaW5nID0gTlVMTDsKPiAgCX0KPiAgCj4gLQlpbmZvLT5mYm9wcy0+ZmJfbW1hcCA9IE5VTEw7 Cj4gKwlrZnJlZShpbmZvLT5mYm9wcyk7Cj4gKwlpbmZvLT5mYm9wcyA9IGluZm8tPmRlZmVycmVk X2lvX3ByaXZhdGU7Cj4gKwlpbmZvLT5kZWZlcnJlZF9pb19wcml2YXRlID0gTlVMTDsKPiArCj4g IAltdXRleF9kZXN0cm95KCZmYmRlZmlvLT5sb2NrKTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MX0dQ TChmYl9kZWZlcnJlZF9pb19jbGVhbnVwKTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9m Yi5oIGIvaW5jbHVkZS9saW51eC9mYi5oCj4gaW5kZXggYTZhZDUyODk5MGRlLi42NWYyYWJkNDc3 NDUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9mYi5oCj4gKysrIGIvaW5jbHVkZS9saW51 eC9mYi5oCj4gQEAgLTQ3MCw2ICs0NzAsNyBAQCBzdHJ1Y3QgZmJfaW5mbyB7Cj4gICNpZmRlZiBD T05GSUdfRkJfREVGRVJSRURfSU8KPiAgCXN0cnVjdCBkZWxheWVkX3dvcmsgZGVmZXJyZWRfd29y azsKPiAgCXN0cnVjdCBmYl9kZWZlcnJlZF9pbyAqZmJkZWZpbzsKPiArCXZvaWQgKmRlZmVycmVk X2lvX3ByaXZhdGU7Cj4gICNlbmRpZgo+ICAKPiAgCXN0cnVjdCBmYl9vcHMgKmZib3BzOwo+IEBA IC02NTgsNyArNjU5LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIF9fZmJfcGFkX2FsaWduZWRfYnVm ZmVyKHU4ICpkc3QsIHUzMiBkX3BpdGNoLAo+ICAKPiAgLyogZHJpdmVycy92aWRlby9mYl9kZWZp by5jICovCj4gIGludCBmYl9kZWZlcnJlZF9pb19tbWFwKHN0cnVjdCBmYl9pbmZvICppbmZvLCBz dHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSk7Cj4gLWV4dGVybiB2b2lkIGZiX2RlZmVycmVkX2lv X2luaXQoc3RydWN0IGZiX2luZm8gKmluZm8pOwo+ICtleHRlcm4gaW50IGZiX2RlZmVycmVkX2lv X2luaXQoc3RydWN0IGZiX2luZm8gKmluZm8pOwo+ICBleHRlcm4gdm9pZCBmYl9kZWZlcnJlZF9p b19vcGVuKHN0cnVjdCBmYl9pbmZvICppbmZvLAo+ICAJCQkJc3RydWN0IGlub2RlICppbm9kZSwK PiAgCQkJCXN0cnVjdCBmaWxlICpmaWxlKTsKPiAtLSAKPiAyLjIwLjEKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B239DC432C3 for ; Wed, 27 Nov 2019 17:01:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9203020665 for ; Wed, 27 Nov 2019 17:01:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9203020665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C782B6E550; Wed, 27 Nov 2019 17:01:21 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 725866E37F; Wed, 27 Nov 2019 17:01:20 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2019 09:01:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,250,1571727600"; d="scan'208";a="221039347" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 27 Nov 2019 09:01:16 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 27 Nov 2019 19:01:16 +0200 Date: Wed, 27 Nov 2019 19:01:16 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Subject: Re: [PATCH 01/13] video: fb_defio: preserve user fb_ops Message-ID: <20191127170116.GK1208@intel.com> References: <448995ffd954e0cd2287089cb686e351cc095834.1574871797.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <448995ffd954e0cd2287089cb686e351cc095834.1574871797.git.jani.nikula@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Jaya Kumar Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191127170116.4AxxZepBqe6QDQaGPY5Mzdo0SyKMMJURIFx7232BLzo@z> T24gV2VkLCBOb3YgMjcsIDIwMTkgYXQgMDY6MzE6NTdQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gTW9kaWZ5aW5nIGZiX29wcyBkaXJlY3RseSB0byBvdmVycmlkZSBmYl9tbWFwIHdpdGgg ZmJfZGVmZXJyZWRfaW9fbW1hcAo+IGFuZCB0aGVuIHJlc2V0dGluZyBpdCB0byBOVUxMIGFmdGVy d2FyZHMgY2F1c2VzIHByb2JsZW1zIGFsbCBvdmVyIHRoZQo+IHBsYWNlLiBGaXJzdCwgaXQgcHJl dmVudHMgbWFraW5nIHRoZSBmYm9wcyBtZW1iZXIgb2Ygc3RydWN0IGZiX2luZm8gYQo+IGNvbnN0 IHBvaW50ZXIsIHdoaWNoIG1lYW5zIHdlIGNhbid0IG1ha2Ugc3RydWN0IGZiX29wcyBjb25zdAo+ IGFueXdoZXJlLiBTZWNvbmQsIGEgZmV3IHBsYWNlcyBoYXZlIHRvIGdvIG91dCBvZiB0aGVpciB3 YXkgdG8gcmVzdG9yZQo+IHRoZSBvcmlnaW5hbCBmYl9tbWFwIHBvaW50ZXIgdGhhdCBnZXRzIHJl c2V0IHRvIE5VTEwuCj4gCj4gUHJlc2VydmUgdGhlIHBhc3NlZCBpbiBmYl9vcHMgYnkgbWFraW5n IGEgY29weSBvZiBpdCBhbmQgbW9kaWZ5aW5nIHRoYXQKPiBpbnN0ZWFkLiBBZGQgYSBkZWZlcnJl ZF9pb19wcml2YXRlIG1lbWJlciB0byBzdHJ1Y3QgZmJfaW5mbyB0byBzdG9yZSB0aGUKPiBwb2lu dGVyIHRvIHRoZSBvbGQgZmJfb3BzLCBhbmQgcmVzdG9yZSB0aGF0IGF0IGNsZWFudXAuCgpRdWl0 ZSB0aGUgaG9ycm9yIHNob3cuIEkgd29uZGVyIGhvdyBoYXJkIGl0IHdvdWxkIGJlIHRvIGp1c3Qg aGF2ZSBlYWNoCmRyaXZlciB0aGF0IGNhbiB1c2UgZGVmaW8gcHJvdmlkZSBhIG1tYXAgaG9vayB0 aGF0IGVpdGhlciBkaXNwYXRjaGVzCnRvIHRoZSBkZWZpbyBvbmUgb3IgdGhlIG5hdGl2ZSBvbmUg ZGVwZW5kaW5nIGlmIGRlZmlvIGlzIHVzZWQgb3Igbm90Li4uCgpBIGZldyBkcml2ZXJzIGF0IGxl YXN0IHNlZW0gdG8gYWx3YXlzIHVzZSBkZWZpbyBzbyB0aG9zZSBzaG91bGQgYmUKdHJpdmlhbC4g U29tZSBvdGhlcnMgc2VlbSB0byBtYWtlIHRoZSBkZWNpc2lvbiBkeW5hbWljYWxseSwgd2hpY2gK d291bGQgcmVxdWlyZSBjdXN0b20gLm1tYXAoKS4gVGhvdWdoIEkgc3VwcG9zZSBhbGwgb2YgdGhl bSBjb3VsZCBqdXN0CmJlIG9mIHRoZSBmb3JtCmZvb19tbWFwX3dyYXB7KQp7CglpZiAoaW5mby0+ ZGVmaW8pCgkJZGVmaW9fbW1hcCgpCgllbHNlCgkJZm9vX21tYXAoKTsKfQoKSG1tLiBBY3R1YWxs eSBpcyAuZmJfbW1hcCgpIGNhbGxlZCBmcm9tIGFueXdoZXJlIGJ1dCBmYl9tbWFwKCk/IElmIG5v dAp3ZSBjb3VsZCBqdXN0IHNob3ZlIHRoZSBkZWZpbyBjaGVjayB0aGVyZT8gT3IgaWYgaXQncyBj YWxsZWQgZnJvbQpzZXZlcmFsIHBsYWNlcyB3ZSBjb3VsZCB0cnkgdG8gd3JhcCBhbGwgY2FsbHMg aW4gX2ZiX21tYXAoKSBvciBzb21lc3VjaC4KCj4gCj4gQ2M6IEpheWEgS3VtYXIgPGpheWFsa0Bp bnR3b3Jrcy5iaXo+Cj4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZwo+IFNpZ25lZC1v ZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gCj4gLS0tCj4gCj4g Tm90ZTogSWYgdGhlIGFwcHJvYWNoIGlzIGFjY2VwdGFibGUsIHdlJ2xsIGFsc28gbmVlZCB0byBo YW5kbGUgdGhlIGVycm9yCj4gcmV0dXJucyBvbiBtZW1vcnkgYWxsb2NhdGlvbiBmYWlsdXJlcyBh dCBmYl9kZWZlcnJlZF9pb19pbml0KCkgY2FsbAo+IHNpdGVzLiBUaGVyZSBhcmUgMTMuCj4gLS0t Cj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jIHwgMjUgKysrKysrKysrKysr KysrKysrKysrKy0tLQo+ICBpbmNsdWRlL2xpbnV4L2ZiLmggICAgICAgICAgICAgICAgICB8ICAz ICsrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jIGIv ZHJpdmVycy92aWRlby9mYmRldi9jb3JlL2ZiX2RlZmlvLmMKPiBpbmRleCA4MmMyMGM2MDQ3YjAu LjM2Njk3ODQ0YzFlMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJf ZGVmaW8uYwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jCj4gQEAg LTIwMCwxMyArMjAwLDIzIEBAIHN0YXRpYyB2b2lkIGZiX2RlZmVycmVkX2lvX3dvcmsoc3RydWN0 IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJbXV0ZXhfdW5sb2NrKCZmYmRlZmlvLT5sb2NrKTsKPiAg fQo+ICAKPiAtdm9pZCBmYl9kZWZlcnJlZF9pb19pbml0KHN0cnVjdCBmYl9pbmZvICppbmZvKQo+ ICtpbnQgZmJfZGVmZXJyZWRfaW9faW5pdChzdHJ1Y3QgZmJfaW5mbyAqaW5mbykKPiAgewo+ICAJ c3RydWN0IGZiX2RlZmVycmVkX2lvICpmYmRlZmlvID0gaW5mby0+ZmJkZWZpbzsKPiArCXN0cnVj dCBmYl9vcHMgKmZib3BzOwo+ICAKPiAgCUJVR19PTighZmJkZWZpbyk7Cj4gKwo+ICsJZmJvcHMg PSBrbWVtZHVwKGluZm8tPmZib3BzLCBzaXplb2YoKmZib3BzKSwgR0ZQX0tFUk5FTCk7Cj4gKwlp ZiAoIWZib3BzKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCWZib3BzLT5mYl9tbWFwID0g ZmJfZGVmZXJyZWRfaW9fbW1hcDsKPiArCWluZm8tPmRlZmVycmVkX2lvX3ByaXZhdGUgPSBpbmZv LT5mYm9wczsKPiArCWluZm8tPmZib3BzID0gZmJvcHM7Cj4gKwo+ICAJbXV0ZXhfaW5pdCgmZmJk ZWZpby0+bG9jayk7Cj4gLQlpbmZvLT5mYm9wcy0+ZmJfbW1hcCA9IGZiX2RlZmVycmVkX2lvX21t YXA7Cj4gKwo+ICAJSU5JVF9ERUxBWUVEX1dPUksoJmluZm8tPmRlZmVycmVkX3dvcmssIGZiX2Rl ZmVycmVkX2lvX3dvcmspOwo+ICAJSU5JVF9MSVNUX0hFQUQoJmZiZGVmaW8tPnBhZ2VsaXN0KTsK PiAgCWlmIChmYmRlZmlvLT5kZWxheSA9PSAwKSAvKiBzZXQgYSBkZWZhdWx0IG9mIDEgcyAqLwo+ IEBAIC0yMjksNiArMjM5LDEyIEBAIHZvaWQgZmJfZGVmZXJyZWRfaW9fY2xlYW51cChzdHJ1Y3Qg ZmJfaW5mbyAqaW5mbykKPiAgCWludCBpOwo+ICAKPiAgCUJVR19PTighZmJkZWZpbyk7Cj4gKwo+ ICsJLyogc2FuaXR5IGNoZWNrIGFnYWluc3QgbWlzdXNlICovCj4gKwlpZiAoV0FSTl9PTighaW5m by0+ZGVmZXJyZWRfaW9fcHJpdmF0ZSB8fAo+ICsJCSAgICBpbmZvLT5mYm9wcy0+ZmJfbW1hcCAh PSBmYl9kZWZlcnJlZF9pb19tbWFwKSkKPiArCQlyZXR1cm47Cj4gKwo+ICAJY2FuY2VsX2RlbGF5 ZWRfd29ya19zeW5jKCZpbmZvLT5kZWZlcnJlZF93b3JrKTsKPiAgCj4gIAkvKiBjbGVhciBvdXQg dGhlIG1hcHBpbmcgdGhhdCB3ZSBzZXR1cCAqLwo+IEBAIC0yMzcsNyArMjUzLDEwIEBAIHZvaWQg ZmJfZGVmZXJyZWRfaW9fY2xlYW51cChzdHJ1Y3QgZmJfaW5mbyAqaW5mbykKPiAgCQlwYWdlLT5t YXBwaW5nID0gTlVMTDsKPiAgCX0KPiAgCj4gLQlpbmZvLT5mYm9wcy0+ZmJfbW1hcCA9IE5VTEw7 Cj4gKwlrZnJlZShpbmZvLT5mYm9wcyk7Cj4gKwlpbmZvLT5mYm9wcyA9IGluZm8tPmRlZmVycmVk X2lvX3ByaXZhdGU7Cj4gKwlpbmZvLT5kZWZlcnJlZF9pb19wcml2YXRlID0gTlVMTDsKPiArCj4g IAltdXRleF9kZXN0cm95KCZmYmRlZmlvLT5sb2NrKTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MX0dQ TChmYl9kZWZlcnJlZF9pb19jbGVhbnVwKTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9m Yi5oIGIvaW5jbHVkZS9saW51eC9mYi5oCj4gaW5kZXggYTZhZDUyODk5MGRlLi42NWYyYWJkNDc3 NDUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9mYi5oCj4gKysrIGIvaW5jbHVkZS9saW51 eC9mYi5oCj4gQEAgLTQ3MCw2ICs0NzAsNyBAQCBzdHJ1Y3QgZmJfaW5mbyB7Cj4gICNpZmRlZiBD T05GSUdfRkJfREVGRVJSRURfSU8KPiAgCXN0cnVjdCBkZWxheWVkX3dvcmsgZGVmZXJyZWRfd29y azsKPiAgCXN0cnVjdCBmYl9kZWZlcnJlZF9pbyAqZmJkZWZpbzsKPiArCXZvaWQgKmRlZmVycmVk X2lvX3ByaXZhdGU7Cj4gICNlbmRpZgo+ICAKPiAgCXN0cnVjdCBmYl9vcHMgKmZib3BzOwo+IEBA IC02NTgsNyArNjU5LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIF9fZmJfcGFkX2FsaWduZWRfYnVm ZmVyKHU4ICpkc3QsIHUzMiBkX3BpdGNoLAo+ICAKPiAgLyogZHJpdmVycy92aWRlby9mYl9kZWZp by5jICovCj4gIGludCBmYl9kZWZlcnJlZF9pb19tbWFwKHN0cnVjdCBmYl9pbmZvICppbmZvLCBz dHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSk7Cj4gLWV4dGVybiB2b2lkIGZiX2RlZmVycmVkX2lv X2luaXQoc3RydWN0IGZiX2luZm8gKmluZm8pOwo+ICtleHRlcm4gaW50IGZiX2RlZmVycmVkX2lv X2luaXQoc3RydWN0IGZiX2luZm8gKmluZm8pOwo+ICBleHRlcm4gdm9pZCBmYl9kZWZlcnJlZF9p b19vcGVuKHN0cnVjdCBmYl9pbmZvICppbmZvLAo+ICAJCQkJc3RydWN0IGlub2RlICppbm9kZSwK PiAgCQkJCXN0cnVjdCBmaWxlICpmaWxlKTsKPiAtLSAKPiAyLjIwLjEKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA32C432C0 for ; Wed, 27 Nov 2019 17:01:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAD7920665 for ; Wed, 27 Nov 2019 17:01:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAD7920665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45C566E37F; Wed, 27 Nov 2019 17:01:21 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 725866E37F; Wed, 27 Nov 2019 17:01:20 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2019 09:01:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,250,1571727600"; d="scan'208";a="221039347" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 27 Nov 2019 09:01:16 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 27 Nov 2019 19:01:16 +0200 Date: Wed, 27 Nov 2019 19:01:16 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: <20191127170116.GK1208@intel.com> References: <448995ffd954e0cd2287089cb686e351cc095834.1574871797.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <448995ffd954e0cd2287089cb686e351cc095834.1574871797.git.jani.nikula@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 01/13] video: fb_defio: preserve user fb_ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Jaya Kumar Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191127170116.bX6JdgPzDoI4OFiOQZNa5O8gnHIDyrnN6d1t9R2MWf4@z> T24gV2VkLCBOb3YgMjcsIDIwMTkgYXQgMDY6MzE6NTdQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gTW9kaWZ5aW5nIGZiX29wcyBkaXJlY3RseSB0byBvdmVycmlkZSBmYl9tbWFwIHdpdGgg ZmJfZGVmZXJyZWRfaW9fbW1hcAo+IGFuZCB0aGVuIHJlc2V0dGluZyBpdCB0byBOVUxMIGFmdGVy d2FyZHMgY2F1c2VzIHByb2JsZW1zIGFsbCBvdmVyIHRoZQo+IHBsYWNlLiBGaXJzdCwgaXQgcHJl dmVudHMgbWFraW5nIHRoZSBmYm9wcyBtZW1iZXIgb2Ygc3RydWN0IGZiX2luZm8gYQo+IGNvbnN0 IHBvaW50ZXIsIHdoaWNoIG1lYW5zIHdlIGNhbid0IG1ha2Ugc3RydWN0IGZiX29wcyBjb25zdAo+ IGFueXdoZXJlLiBTZWNvbmQsIGEgZmV3IHBsYWNlcyBoYXZlIHRvIGdvIG91dCBvZiB0aGVpciB3 YXkgdG8gcmVzdG9yZQo+IHRoZSBvcmlnaW5hbCBmYl9tbWFwIHBvaW50ZXIgdGhhdCBnZXRzIHJl c2V0IHRvIE5VTEwuCj4gCj4gUHJlc2VydmUgdGhlIHBhc3NlZCBpbiBmYl9vcHMgYnkgbWFraW5n IGEgY29weSBvZiBpdCBhbmQgbW9kaWZ5aW5nIHRoYXQKPiBpbnN0ZWFkLiBBZGQgYSBkZWZlcnJl ZF9pb19wcml2YXRlIG1lbWJlciB0byBzdHJ1Y3QgZmJfaW5mbyB0byBzdG9yZSB0aGUKPiBwb2lu dGVyIHRvIHRoZSBvbGQgZmJfb3BzLCBhbmQgcmVzdG9yZSB0aGF0IGF0IGNsZWFudXAuCgpRdWl0 ZSB0aGUgaG9ycm9yIHNob3cuIEkgd29uZGVyIGhvdyBoYXJkIGl0IHdvdWxkIGJlIHRvIGp1c3Qg aGF2ZSBlYWNoCmRyaXZlciB0aGF0IGNhbiB1c2UgZGVmaW8gcHJvdmlkZSBhIG1tYXAgaG9vayB0 aGF0IGVpdGhlciBkaXNwYXRjaGVzCnRvIHRoZSBkZWZpbyBvbmUgb3IgdGhlIG5hdGl2ZSBvbmUg ZGVwZW5kaW5nIGlmIGRlZmlvIGlzIHVzZWQgb3Igbm90Li4uCgpBIGZldyBkcml2ZXJzIGF0IGxl YXN0IHNlZW0gdG8gYWx3YXlzIHVzZSBkZWZpbyBzbyB0aG9zZSBzaG91bGQgYmUKdHJpdmlhbC4g U29tZSBvdGhlcnMgc2VlbSB0byBtYWtlIHRoZSBkZWNpc2lvbiBkeW5hbWljYWxseSwgd2hpY2gK d291bGQgcmVxdWlyZSBjdXN0b20gLm1tYXAoKS4gVGhvdWdoIEkgc3VwcG9zZSBhbGwgb2YgdGhl bSBjb3VsZCBqdXN0CmJlIG9mIHRoZSBmb3JtCmZvb19tbWFwX3dyYXB7KQp7CglpZiAoaW5mby0+ ZGVmaW8pCgkJZGVmaW9fbW1hcCgpCgllbHNlCgkJZm9vX21tYXAoKTsKfQoKSG1tLiBBY3R1YWxs eSBpcyAuZmJfbW1hcCgpIGNhbGxlZCBmcm9tIGFueXdoZXJlIGJ1dCBmYl9tbWFwKCk/IElmIG5v dAp3ZSBjb3VsZCBqdXN0IHNob3ZlIHRoZSBkZWZpbyBjaGVjayB0aGVyZT8gT3IgaWYgaXQncyBj YWxsZWQgZnJvbQpzZXZlcmFsIHBsYWNlcyB3ZSBjb3VsZCB0cnkgdG8gd3JhcCBhbGwgY2FsbHMg aW4gX2ZiX21tYXAoKSBvciBzb21lc3VjaC4KCj4gCj4gQ2M6IEpheWEgS3VtYXIgPGpheWFsa0Bp bnR3b3Jrcy5iaXo+Cj4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZwo+IFNpZ25lZC1v ZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gCj4gLS0tCj4gCj4g Tm90ZTogSWYgdGhlIGFwcHJvYWNoIGlzIGFjY2VwdGFibGUsIHdlJ2xsIGFsc28gbmVlZCB0byBo YW5kbGUgdGhlIGVycm9yCj4gcmV0dXJucyBvbiBtZW1vcnkgYWxsb2NhdGlvbiBmYWlsdXJlcyBh dCBmYl9kZWZlcnJlZF9pb19pbml0KCkgY2FsbAo+IHNpdGVzLiBUaGVyZSBhcmUgMTMuCj4gLS0t Cj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jIHwgMjUgKysrKysrKysrKysr KysrKysrKysrKy0tLQo+ICBpbmNsdWRlL2xpbnV4L2ZiLmggICAgICAgICAgICAgICAgICB8ICAz ICsrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jIGIv ZHJpdmVycy92aWRlby9mYmRldi9jb3JlL2ZiX2RlZmlvLmMKPiBpbmRleCA4MmMyMGM2MDQ3YjAu LjM2Njk3ODQ0YzFlMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJf ZGVmaW8uYwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jCj4gQEAg LTIwMCwxMyArMjAwLDIzIEBAIHN0YXRpYyB2b2lkIGZiX2RlZmVycmVkX2lvX3dvcmsoc3RydWN0 IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJbXV0ZXhfdW5sb2NrKCZmYmRlZmlvLT5sb2NrKTsKPiAg fQo+ICAKPiAtdm9pZCBmYl9kZWZlcnJlZF9pb19pbml0KHN0cnVjdCBmYl9pbmZvICppbmZvKQo+ ICtpbnQgZmJfZGVmZXJyZWRfaW9faW5pdChzdHJ1Y3QgZmJfaW5mbyAqaW5mbykKPiAgewo+ICAJ c3RydWN0IGZiX2RlZmVycmVkX2lvICpmYmRlZmlvID0gaW5mby0+ZmJkZWZpbzsKPiArCXN0cnVj dCBmYl9vcHMgKmZib3BzOwo+ICAKPiAgCUJVR19PTighZmJkZWZpbyk7Cj4gKwo+ICsJZmJvcHMg PSBrbWVtZHVwKGluZm8tPmZib3BzLCBzaXplb2YoKmZib3BzKSwgR0ZQX0tFUk5FTCk7Cj4gKwlp ZiAoIWZib3BzKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCWZib3BzLT5mYl9tbWFwID0g ZmJfZGVmZXJyZWRfaW9fbW1hcDsKPiArCWluZm8tPmRlZmVycmVkX2lvX3ByaXZhdGUgPSBpbmZv LT5mYm9wczsKPiArCWluZm8tPmZib3BzID0gZmJvcHM7Cj4gKwo+ICAJbXV0ZXhfaW5pdCgmZmJk ZWZpby0+bG9jayk7Cj4gLQlpbmZvLT5mYm9wcy0+ZmJfbW1hcCA9IGZiX2RlZmVycmVkX2lvX21t YXA7Cj4gKwo+ICAJSU5JVF9ERUxBWUVEX1dPUksoJmluZm8tPmRlZmVycmVkX3dvcmssIGZiX2Rl ZmVycmVkX2lvX3dvcmspOwo+ICAJSU5JVF9MSVNUX0hFQUQoJmZiZGVmaW8tPnBhZ2VsaXN0KTsK PiAgCWlmIChmYmRlZmlvLT5kZWxheSA9PSAwKSAvKiBzZXQgYSBkZWZhdWx0IG9mIDEgcyAqLwo+ IEBAIC0yMjksNiArMjM5LDEyIEBAIHZvaWQgZmJfZGVmZXJyZWRfaW9fY2xlYW51cChzdHJ1Y3Qg ZmJfaW5mbyAqaW5mbykKPiAgCWludCBpOwo+ICAKPiAgCUJVR19PTighZmJkZWZpbyk7Cj4gKwo+ ICsJLyogc2FuaXR5IGNoZWNrIGFnYWluc3QgbWlzdXNlICovCj4gKwlpZiAoV0FSTl9PTighaW5m by0+ZGVmZXJyZWRfaW9fcHJpdmF0ZSB8fAo+ICsJCSAgICBpbmZvLT5mYm9wcy0+ZmJfbW1hcCAh PSBmYl9kZWZlcnJlZF9pb19tbWFwKSkKPiArCQlyZXR1cm47Cj4gKwo+ICAJY2FuY2VsX2RlbGF5 ZWRfd29ya19zeW5jKCZpbmZvLT5kZWZlcnJlZF93b3JrKTsKPiAgCj4gIAkvKiBjbGVhciBvdXQg dGhlIG1hcHBpbmcgdGhhdCB3ZSBzZXR1cCAqLwo+IEBAIC0yMzcsNyArMjUzLDEwIEBAIHZvaWQg ZmJfZGVmZXJyZWRfaW9fY2xlYW51cChzdHJ1Y3QgZmJfaW5mbyAqaW5mbykKPiAgCQlwYWdlLT5t YXBwaW5nID0gTlVMTDsKPiAgCX0KPiAgCj4gLQlpbmZvLT5mYm9wcy0+ZmJfbW1hcCA9IE5VTEw7 Cj4gKwlrZnJlZShpbmZvLT5mYm9wcyk7Cj4gKwlpbmZvLT5mYm9wcyA9IGluZm8tPmRlZmVycmVk X2lvX3ByaXZhdGU7Cj4gKwlpbmZvLT5kZWZlcnJlZF9pb19wcml2YXRlID0gTlVMTDsKPiArCj4g IAltdXRleF9kZXN0cm95KCZmYmRlZmlvLT5sb2NrKTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MX0dQ TChmYl9kZWZlcnJlZF9pb19jbGVhbnVwKTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9m Yi5oIGIvaW5jbHVkZS9saW51eC9mYi5oCj4gaW5kZXggYTZhZDUyODk5MGRlLi42NWYyYWJkNDc3 NDUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9mYi5oCj4gKysrIGIvaW5jbHVkZS9saW51 eC9mYi5oCj4gQEAgLTQ3MCw2ICs0NzAsNyBAQCBzdHJ1Y3QgZmJfaW5mbyB7Cj4gICNpZmRlZiBD T05GSUdfRkJfREVGRVJSRURfSU8KPiAgCXN0cnVjdCBkZWxheWVkX3dvcmsgZGVmZXJyZWRfd29y azsKPiAgCXN0cnVjdCBmYl9kZWZlcnJlZF9pbyAqZmJkZWZpbzsKPiArCXZvaWQgKmRlZmVycmVk X2lvX3ByaXZhdGU7Cj4gICNlbmRpZgo+ICAKPiAgCXN0cnVjdCBmYl9vcHMgKmZib3BzOwo+IEBA IC02NTgsNyArNjU5LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIF9fZmJfcGFkX2FsaWduZWRfYnVm ZmVyKHU4ICpkc3QsIHUzMiBkX3BpdGNoLAo+ICAKPiAgLyogZHJpdmVycy92aWRlby9mYl9kZWZp by5jICovCj4gIGludCBmYl9kZWZlcnJlZF9pb19tbWFwKHN0cnVjdCBmYl9pbmZvICppbmZvLCBz dHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSk7Cj4gLWV4dGVybiB2b2lkIGZiX2RlZmVycmVkX2lv X2luaXQoc3RydWN0IGZiX2luZm8gKmluZm8pOwo+ICtleHRlcm4gaW50IGZiX2RlZmVycmVkX2lv X2luaXQoc3RydWN0IGZiX2luZm8gKmluZm8pOwo+ICBleHRlcm4gdm9pZCBmYl9kZWZlcnJlZF9p b19vcGVuKHN0cnVjdCBmYl9pbmZvICppbmZvLAo+ICAJCQkJc3RydWN0IGlub2RlICppbm9kZSwK PiAgCQkJCXN0cnVjdCBmaWxlICpmaWxlKTsKPiAtLSAKPiAyLjIwLjEKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4