From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Vidya Sagar <vidyas@nvidia.com>, Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: Issue with 395f121e6199 ("PCI/PM: Wait for device to become ready after power-on")
Date: Thu, 28 Nov 2019 10:23:14 +0200 [thread overview]
Message-ID: <20191128082314.GD2665@lahna.fi.intel.com> (raw)
In-Reply-To: <20191127153433.GA2665@lahna.fi.intel.com>
Hi,
For some reason I don't see this in linux-pci archives. Maybe it was not
accepted because of the attachment? In any case the full dmesg can be
found here as well:
https://gist.github.com/westeri/ca2574a4e48dc6e3eb76184922e103e5
On Wed, Nov 27, 2019 at 05:34:37PM +0200, Mika Westerberg wrote:
> Hi,
>
> I noticed that latest Bjorn's pci/pm branch breaks native PCIe hotplug
> so that when I unplug a device (connected over TBT) the pciehp notices
> it but then the core PCI code starts waiting for all the devices that
> are now gone:
>
> [ 160.344476] pcieport 0000:04:04.0: pciehp: pciehp_check_link_active: lnk_status = 5041
> [ 160.344531] pcieport 0000:04:04.0: pciehp: Slot(4): Card not present
> [ 160.346004] pcieport 0000:04:04.0: pciehp: pciehp_unconfigure_device: domain:bus:dev = 0000:3a:00
> [ 161.421569] pcieport 0000:3a:00.0: not ready 1023ms after Switch to D0; waiting
> [ 162.509610] pcieport 0000:3a:00.0: not ready 2047ms after Switch to D0; waiting
> [ 164.621620] pcieport 0000:3a:00.0: not ready 4095ms after Switch to D0; waiting
> [ 169.165529] pcieport 0000:3a:00.0: not ready 8191ms after Switch to D0; waiting
> [ 177.869521] pcieport 0000:3a:00.0: not ready 16383ms after Switch to D0; waiting
> [ 194.765581] pcieport 0000:3a:00.0: not ready 32767ms after Switch to D0; waiting
> ...
>
> It seems to continue forever so the devices are not removed from the
> system.
>
> The test system used here is Dell XPS 9380 but it happens also on other
> systems that support native PCIe hotplug.
>
> Reverting 395f121e6199 ("PCI/PM: Wait for device to become ready after
> power-on") makes the problem go away.
>
> I've attached full dmesg from the system. The way I reproduce this is
> that I boot the system up (no device connected yet), the I connect TBT
> dock that includes the PCIe switch etc. Then I unplug the dock. The
> unplug happens around 160.335355 in the dmesg.
next parent reply other threads:[~2019-11-28 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191127153433.GA2665@lahna.fi.intel.com>
2019-11-28 8:23 ` Mika Westerberg [this message]
2019-11-28 14:59 ` Issue with 395f121e6199 ("PCI/PM: Wait for device to become ready after power-on") Bjorn Helgaas
2019-11-28 15:01 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128082314.GD2665@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.