From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDAFC432C3 for ; Thu, 28 Nov 2019 13:11:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4600C2071F for ; Thu, 28 Nov 2019 13:11:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ps1WIjJs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4600C2071F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaJa4-0006Lf-F9 for qemu-devel@archiver.kernel.org; Thu, 28 Nov 2019 08:11:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55157) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaJJI-0004kk-F4 for qemu-devel@nongnu.org; Thu, 28 Nov 2019 07:54:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaJJB-0003dv-6R for qemu-devel@nongnu.org; Thu, 28 Nov 2019 07:54:13 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:38412 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iaJJA-0003bL-Pe for qemu-devel@nongnu.org; Thu, 28 Nov 2019 07:54:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574945646; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O5MissD6UpYoefUjL/KaXoUYh7RfI6mXyjAkCcwaMQs=; b=Ps1WIjJsOLDNx0nYwt3OvEn/5pud2Y6X6DNYpqq89fmG4UnSxof5am0vHgorKDR9EQp9CP YkU34TeUqPNwS9iMIreteDTaIxuT1Yv/L2B73uepngYsyew7KLAdCbamvSBZRcKV62FJkt LaToKYRDdPveGqrykh9RGR5az4dyixQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-DGcmvXhwOZGTVsMqdjr0MA-1; Thu, 28 Nov 2019 07:54:02 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CFDD9801E5E; Thu, 28 Nov 2019 12:54:01 +0000 (UTC) Received: from redhat.com (unknown [10.42.16.105]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7FAAA5C1B0; Thu, 28 Nov 2019 12:53:58 +0000 (UTC) Date: Thu, 28 Nov 2019 12:53:56 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?B?VG9tw6HFoSBHb2xlbWJpb3Zza8O9?= Subject: Re: [PATCH v5] qga: add command guest-get-devices for reporting VirtIO devices Message-ID: <20191128125356.GH248361@redhat.com> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: DGcmvXhwOZGTVsMqdjr0MA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-devel@nongnu.org, Michael Roth Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Nov 28, 2019 at 01:45:13PM +0100, Tom=C3=A1=C5=A1 Golembiovsk=C3=BD= wrote: > Add command for reporting devices on Windows guest. The intent is not so > much to report the devices but more importantly the driver (and its > version) that is assigned to the device. This gives caller the > information whether VirtIO drivers are installed and/or whether > inadequate driver is used on a device (e.g. QXL device with base VGA > driver). >=20 > Signed-off-by: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD > --- >=20 > changes in v5: > - updated version in schema >=20 > changes in v4: > - making check-patch happy >=20 > qga/commands-posix.c | 9 ++ > qga/commands-win32.c | 204 ++++++++++++++++++++++++++++++++++++++++++- > qga/qapi-schema.json | 32 +++++++ > 3 files changed, 244 insertions(+), 1 deletion(-) > +## > +# @GuestDeviceInfo: > +# > +# @vendor-id: vendor ID > +# @device-id: device ID Presumably these are PCI device IDs ? If so, this schema is not portable to all architectures, because they don't all use PCI and on s390x PCI there's some extra device IDs. > +# @driver-name: name of the associated driver > +# @driver-date: driver release date in format YYYY-MM-DD > +# @driver-version: driver version > +# > +# Since: 4.3 > +## > +{ 'struct': 'GuestDeviceInfo', > + 'data': { > + 'vendor-id': 'uint16', > + 'device-id': 'uint16', > + 'driver-name': 'str', > + 'driver-date': 'str', Should be optional as not all OS will have dates for individual drivers > + 'driver-version': 'str' Should be optional again. > + } } I think this ought to be a structured differently though. GuestDeviceInfo should just contain the driver name, date + version, then it should point to an GuestDeviceAddress which is a union, initially only holding a "GuestDevicePCI" struct, but which we can extend to other types of device address later. > + > +## > +# @guest-get-devices: > +# > +# Retrieve information about device drivers in Windows guest > +# > +# Returns: @GuestDeviceInfo > +# > +# Since: 4.3 The next version is 5.0 > +## > +{ 'command': 'guest-get-devices', > + 'returns': ['GuestDeviceInfo'] } > --=20 > 2.24.0 >=20 >=20 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|