From: Cornelia Huck <cohuck@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: thuth@redhat.com, pmorel@linux.ibm.com,
David Hildenbrand <david@redhat.com>,
qemu-devel@nongnu.org, borntraeger@de.ibm.com,
qemu-s390x@nongnu.org, mihajlov@linux.ibm.com
Subject: Re: [PATCH v4 6/6] s390x: kvm: Make kvm_sclp_service_call void
Date: Fri, 29 Nov 2019 10:01:55 +0100 [thread overview]
Message-ID: <20191129100155.331ae2f0.cohuck@redhat.com> (raw)
In-Reply-To: <346131a4-4dfe-897c-0ddd-a81f8f3f4d6f@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
On Fri, 29 Nov 2019 09:16:21 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:
> On 11/28/19 6:34 PM, Cornelia Huck wrote:
> > On Wed, 27 Nov 2019 19:38:06 +0100
> > Janosch Frank <frankja@linux.ibm.com> wrote:
> >
> >> On 11/27/19 7:25 PM, Janosch Frank wrote:
> >>>
> >>> There's 0 (initiated), busy and operational and as far as I know we
> >>> implement neither.
> >>
> >> That came out wrong...
> >> s/operational/not operational/
> >>
> >> We only implement "command initiated" / cc = 0
> >> We can never have busy, because we handle sclp calls synchronously.
> >> The spec does not give any indication when we could return "not
> >> operational". I guess that's just a free pass for hypervisors.
> >
> > Regardless, setcc(cpu, r) also feels a bit cleaner to me...
>
> Ok, do you want to change that while picking the patches up or shall I
> send a new version?
New version (of this patch), please :) Easier for me...
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-11-29 9:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 17:50 [PATCH v4 0/6] s390x: Cleanup Janosch Frank
2019-11-27 17:50 ` [PATCH v4 1/6] s390x: Don't do a normal reset on the initial cpu Janosch Frank
2019-11-27 17:50 ` [PATCH v4 2/6] s390x: Move reset normal to shared reset handler Janosch Frank
2019-11-28 6:32 ` Thomas Huth
2019-11-28 17:27 ` Cornelia Huck
2019-11-27 17:50 ` [PATCH v4 3/6] s390x: Move initial reset Janosch Frank
2019-11-28 7:00 ` Thomas Huth
2019-11-28 7:22 ` Janosch Frank
2019-11-28 8:37 ` [PATCH v5] " Janosch Frank
2019-11-28 9:13 ` Thomas Huth
2019-11-27 17:50 ` [PATCH v4 4/6] s390x: Move clear reset Janosch Frank
2019-11-27 18:15 ` David Hildenbrand
2019-11-27 18:28 ` Janosch Frank
2019-11-28 7:09 ` Thomas Huth
2019-11-28 8:35 ` Janosch Frank
2019-11-28 8:38 ` David Hildenbrand
2019-11-27 17:50 ` [PATCH v4 5/6] s390x: Beautify diag308 handling Janosch Frank
2019-11-27 17:50 ` [PATCH v4 6/6] s390x: kvm: Make kvm_sclp_service_call void Janosch Frank
2019-11-27 18:07 ` David Hildenbrand
2019-11-27 18:17 ` David Hildenbrand
2019-11-27 18:25 ` Janosch Frank
2019-11-27 18:38 ` Janosch Frank
2019-11-28 17:34 ` Cornelia Huck
2019-11-29 8:16 ` Janosch Frank
2019-11-29 9:01 ` Cornelia Huck [this message]
2019-11-29 9:17 ` [PATCH v5] " Janosch Frank
2019-11-29 9:18 ` David Hildenbrand
2019-11-28 7:48 ` [PATCH v4 6/6] " Thomas Huth
2019-11-29 10:03 ` [PATCH v4 0/6] s390x: Cleanup Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129100155.331ae2f0.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=mihajlov@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.