From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56496C432C3 for ; Sat, 30 Nov 2019 18:37:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3884B2084E for ; Sat, 30 Nov 2019 18:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727312AbfK3Shd (ORCPT ); Sat, 30 Nov 2019 13:37:33 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:38546 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726799AbfK3Shd (ORCPT ); Sat, 30 Nov 2019 13:37:33 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7FBE880563; Sat, 30 Nov 2019 19:37:30 +0100 (CET) Date: Sat, 30 Nov 2019 19:37:29 +0100 From: Sam Ravnborg To: Paul Cercueil Cc: Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel Message-ID: <20191130183729.GD24722@ravnborg.org> References: <20191120171027.1102250-1-paul@crapouillou.net> <20191120171027.1102250-3-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191120171027.1102250-3-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=4eiu5t_5MPiKWv0nutYA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Paul. I am not sure if I already wrote this... On Wed, Nov 20, 2019 at 06:10:27PM +0100, Paul Cercueil wrote: > The FRD350H54004 is a simple 3.5" 320x240 24-bit TFT panel, found for > instance inside the Anbernic RG-350 handheld gaming console. > > Signed-off-by: Paul Cercueil > --- > drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 28fa6ba7b767..8c03f7fe461c 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1378,6 +1378,32 @@ static const struct panel_desc evervision_vgg804821 = { > .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE, > }; > > +static const struct drm_display_mode frida_frd350h54004_mode = { > + .clock = 6777, > + .hdisplay = 320, > + .hsync_start = 320 + 70, > + .hsync_end = 320 + 70 + 50, > + .htotal = 320 + 70 + 50 + 10, > + .vdisplay = 240, > + .vsync_start = 240 + 5, > + .vsync_end = 240 + 5 + 1, > + .vtotal = 240 + 5 + 1 + 5, > + .vrefresh = 60, > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, > +}; > + > +static const struct panel_desc frida_frd350h54004 = { > + .modes = &frida_frd350h54004_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 77, > + .height = 64, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE, > +}; > + > static const struct drm_display_mode foxlink_fl500wvr00_a0t_mode = { > .clock = 32260, > .hdisplay = 800, In alphabetic order. frida comes after foxlink. > @@ -3186,6 +3212,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "evervision,vgg804821", > .data = &evervision_vgg804821, > + }, { > + .compatible = "frida,frd350h54004", > + .data = &frida_frd350h54004, > }, { > .compatible = "foxlink,fl500wvr00-a0t", > .data = &foxlink_fl500wvr00_a0t, In alphabetic order. frida comes after foxlink. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9542C432C0 for ; Sat, 30 Nov 2019 18:37:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94A072075C for ; Sat, 30 Nov 2019 18:37:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94A072075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1694E6E170; Sat, 30 Nov 2019 18:37:33 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D93F890B9 for ; Sat, 30 Nov 2019 18:37:32 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7FBE880563; Sat, 30 Nov 2019 19:37:30 +0100 (CET) Date: Sat, 30 Nov 2019 19:37:29 +0100 From: Sam Ravnborg To: Paul Cercueil Subject: Re: [PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel Message-ID: <20191130183729.GD24722@ravnborg.org> References: <20191120171027.1102250-1-paul@crapouillou.net> <20191120171027.1102250-3-paul@crapouillou.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191120171027.1102250-3-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=4eiu5t_5MPiKWv0nutYA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, od@zcrc.me, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191130183729.AiTFP1bSdHxKRwCkKO3XcOig9mcpAFje0cMoBNSmKko@z> SGkgUGF1bC4KCkkgYW0gbm90IHN1cmUgaWYgSSBhbHJlYWR5IHdyb3RlIHRoaXMuLi4KCk9uIFdl ZCwgTm92IDIwLCAyMDE5IGF0IDA2OjEwOjI3UE0gKzAxMDAsIFBhdWwgQ2VyY3VlaWwgd3JvdGU6 Cj4gVGhlIEZSRDM1MEg1NDAwNCBpcyBhIHNpbXBsZSAzLjUiIDMyMHgyNDAgMjQtYml0IFRGVCBw YW5lbCwgZm91bmQgZm9yCj4gaW5zdGFuY2UgaW5zaWRlIHRoZSBBbmJlcm5pYyBSRy0zNTAgaGFu ZGhlbGQgZ2FtaW5nIGNvbnNvbGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogUGF1bCBDZXJjdWVpbCA8 cGF1bEBjcmFwb3VpbGxvdS5uZXQ+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5l bC1zaW1wbGUuYyB8IDI5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNo YW5nZWQsIDI5IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3BhbmVsL3BhbmVsLXNpbXBsZS5jIGIvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBs ZS5jCj4gaW5kZXggMjhmYTZiYTdiNzY3Li44YzAzZjdmZTQ2MWMgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3BhbmVsL3BhbmVsLXNpbXBsZS5jCj4gQEAgLTEzNzgsNiArMTM3OCwzMiBAQCBzdGF0aWMgY29u c3Qgc3RydWN0IHBhbmVsX2Rlc2MgZXZlcnZpc2lvbl92Z2c4MDQ4MjEgPSB7Cj4gIAkuYnVzX2Zs YWdzID0gRFJNX0JVU19GTEFHX0RFX0hJR0ggfCBEUk1fQlVTX0ZMQUdfUElYREFUQV9ORUdFREdF LAo+ICB9Owo+ICAKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlIGZyaWRh X2ZyZDM1MGg1NDAwNF9tb2RlID0gewo+ICsJLmNsb2NrID0gNjc3NywKPiArCS5oZGlzcGxheSA9 IDMyMCwKPiArCS5oc3luY19zdGFydCA9IDMyMCArIDcwLAo+ICsJLmhzeW5jX2VuZCA9IDMyMCAr IDcwICsgNTAsCj4gKwkuaHRvdGFsID0gMzIwICsgNzAgKyA1MCArIDEwLAo+ICsJLnZkaXNwbGF5 ID0gMjQwLAo+ICsJLnZzeW5jX3N0YXJ0ID0gMjQwICsgNSwKPiArCS52c3luY19lbmQgPSAyNDAg KyA1ICsgMSwKPiArCS52dG90YWwgPSAyNDAgKyA1ICsgMSArIDUsCj4gKwkudnJlZnJlc2ggPSA2 MCwKPiArCS5mbGFncyA9IERSTV9NT0RFX0ZMQUdfUEhTWU5DIHwgRFJNX01PREVfRkxBR19QVlNZ TkMsCj4gK307Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2MgZnJpZGFfZnJk MzUwaDU0MDA0ID0gewo+ICsJLm1vZGVzID0gJmZyaWRhX2ZyZDM1MGg1NDAwNF9tb2RlLAo+ICsJ Lm51bV9tb2RlcyA9IDEsCj4gKwkuYnBjID0gOCwKPiArCS5zaXplID0gewo+ICsJCS53aWR0aCA9 IDc3LAo+ICsJCS5oZWlnaHQgPSA2NCwKPiArCX0sCj4gKwkuYnVzX2Zvcm1hdCA9IE1FRElBX0JV U19GTVRfUkdCODg4XzFYMjQsCj4gKwkuYnVzX2ZsYWdzID0gRFJNX0JVU19GTEFHX0RFX0hJR0gg fCBEUk1fQlVTX0ZMQUdfUElYREFUQV9QT1NFREdFLAo+ICt9Owo+ICsKPiAgc3RhdGljIGNvbnN0 IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlIGZveGxpbmtfZmw1MDB3dnIwMF9hMHRfbW9kZSA9IHsK PiAgCS5jbG9jayA9IDMyMjYwLAo+ICAJLmhkaXNwbGF5ID0gODAwLAoKSW4gYWxwaGFiZXRpYyBv cmRlci4gZnJpZGEgY29tZXMgYWZ0ZXIgZm94bGluay4KCj4gQEAgLTMxODYsNiArMzIxMiw5IEBA IHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHBsYXRmb3JtX29mX21hdGNoW10gPSB7 Cj4gIAl9LCB7Cj4gIAkJLmNvbXBhdGlibGUgPSAiZXZlcnZpc2lvbix2Z2c4MDQ4MjEiLAo+ICAJ CS5kYXRhID0gJmV2ZXJ2aXNpb25fdmdnODA0ODIxLAo+ICsJfSwgewo+ICsJCS5jb21wYXRpYmxl ID0gImZyaWRhLGZyZDM1MGg1NDAwNCIsCj4gKwkJLmRhdGEgPSAmZnJpZGFfZnJkMzUwaDU0MDA0 LAo+ICAJfSwgewo+ICAJCS5jb21wYXRpYmxlID0gImZveGxpbmssZmw1MDB3dnIwMC1hMHQiLAo+ ICAJCS5kYXRhID0gJmZveGxpbmtfZmw1MDB3dnIwMF9hMHQsCkluIGFscGhhYmV0aWMgb3JkZXIu IGZyaWRhIGNvbWVzIGFmdGVyIGZveGxpbmsuCgoJU2FtCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==