From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Sun, 01 Dec 2019 09:09:41 +0000 Subject: Re: [PATCH] drm/panel: clean up indentation issue Message-Id: <20191201090941.GA8753@ravnborg.org> List-Id: References: <20190925120357.10408-1-colin.king@canonical.com> In-Reply-To: <20190925120357.10408-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Stefan Mavrodiev , David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding Hi Colin. On Wed, Sep 25, 2019 at 01:03:57PM +0100, Colin King wrote: > From: Colin Ian King > > There is a continue statement that is indented one level too deeply, > remove the extraneous tab. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c b/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c > index 2bae1db3ff34..7dd67262a2ed 100644 > --- a/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c > +++ b/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c > @@ -161,7 +161,7 @@ static int lcd_olinuxino_get_modes(struct drm_panel *panel) > lcd_mode->hactive, > lcd_mode->vactive, > lcd_mode->refresh); > - continue; > + continue; > } > > mode->clock = lcd_mode->pixelclock; Thanks, this is the kind of issues that can fool one or take focus away when reading code. Applied to drm-misc-next. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] drm/panel: clean up indentation issue Date: Sun, 1 Dec 2019 10:09:41 +0100 Message-ID: <20191201090941.GA8753@ravnborg.org> References: <20190925120357.10408-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CE946E02D for ; Sun, 1 Dec 2019 09:10:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190925120357.10408-1-colin.king@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Colin King Cc: Stefan Mavrodiev , David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding List-Id: dri-devel@lists.freedesktop.org SGkgQ29saW4uCgpPbiBXZWQsIFNlcCAyNSwgMjAxOSBhdCAwMTowMzo1N1BNICswMTAwLCBDb2xp biBLaW5nIHdyb3RlOgo+IEZyb206IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNh bC5jb20+Cj4gCj4gVGhlcmUgaXMgYSBjb250aW51ZSBzdGF0ZW1lbnQgdGhhdCBpcyBpbmRlbnRl ZCBvbmUgbGV2ZWwgdG9vIGRlZXBseSwKPiByZW1vdmUgdGhlIGV4dHJhbmVvdXMgdGFiLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1vbGltZXgtbGNkLW9saW51eGlu by5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24o LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLW9saW1leC1s Y2Qtb2xpbnV4aW5vLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtb2xpbWV4LWxjZC1v bGludXhpbm8uYwo+IGluZGV4IDJiYWUxZGIzZmYzNC4uN2RkNjcyNjJhMmVkIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1vbGltZXgtbGNkLW9saW51eGluby5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLW9saW1leC1sY2Qtb2xpbnV4aW5vLmMK PiBAQCAtMTYxLDcgKzE2MSw3IEBAIHN0YXRpYyBpbnQgbGNkX29saW51eGlub19nZXRfbW9kZXMo c3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4gIAkJCQlsY2RfbW9kZS0+aGFjdGl2ZSwKPiAgCQkJ CWxjZF9tb2RlLT52YWN0aXZlLAo+ICAJCQkJbGNkX21vZGUtPnJlZnJlc2gpOwo+IC0JCQkJY29u dGludWU7Cj4gKwkJCWNvbnRpbnVlOwo+ICAJCX0KPiAgCj4gIAkJbW9kZS0+Y2xvY2sgPSBsY2Rf bW9kZS0+cGl4ZWxjbG9jazsKClRoYW5rcywgdGhpcyBpcyB0aGUga2luZCBvZiBpc3N1ZXMgdGhh dCBjYW4gZm9vbCBvbmUgb3IgdGFrZQpmb2N1cyBhd2F5IHdoZW4gcmVhZGluZyBjb2RlLgoKQXBw bGllZCB0byBkcm0tbWlzYy1uZXh0LgoKCVNhbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45553C432C0 for ; Sun, 1 Dec 2019 09:10:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 109F520715 for ; Sun, 1 Dec 2019 09:10:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726155AbfLAJKC (ORCPT ); Sun, 1 Dec 2019 04:10:02 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:34604 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725847AbfLAJKC (ORCPT ); Sun, 1 Dec 2019 04:10:02 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id A87B980656; Sun, 1 Dec 2019 10:09:43 +0100 (CET) Date: Sun, 1 Dec 2019 10:09:41 +0100 From: Sam Ravnborg To: Colin King Cc: Stefan Mavrodiev , Thierry Reding , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel: clean up indentation issue Message-ID: <20191201090941.GA8753@ravnborg.org> References: <20190925120357.10408-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925120357.10408-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=DfNHnWVPAAAA:8 a=X4VG-in_caqo2OVBQ50A:9 a=CjuIK1q_8ugA:10 a=rjTVMONInIDnV1a_A2c_:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin. On Wed, Sep 25, 2019 at 01:03:57PM +0100, Colin King wrote: > From: Colin Ian King > > There is a continue statement that is indented one level too deeply, > remove the extraneous tab. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c b/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c > index 2bae1db3ff34..7dd67262a2ed 100644 > --- a/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c > +++ b/drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c > @@ -161,7 +161,7 @@ static int lcd_olinuxino_get_modes(struct drm_panel *panel) > lcd_mode->hactive, > lcd_mode->vactive, > lcd_mode->refresh); > - continue; > + continue; > } > > mode->clock = lcd_mode->pixelclock; Thanks, this is the kind of issues that can fool one or take focus away when reading code. Applied to drm-misc-next. Sam