From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= Date: Mon, 02 Dec 2019 08:40:47 +0000 Subject: Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops Message-Id: <20191202094047.34525a7d@aether.lan.sysophe.eu> List-Id: References: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> In-Reply-To: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Jani Nikula Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , intel-gfx@lists.freedesktop.org, Jiri Kosina , dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org Hi Jani, On Fri, 29 Nov 2019 12:29:41 Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > v2: fix typo (Christophe de Dinechin) Fine with me. I don't think going through drm-misc would trigger any conflict, but adding Jiri to CC for the case there was any preference. Acked-by: Bruno Prémont > Cc: Bruno Prémont > Cc: linux-input@vger.kernel.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula > --- > drivers/hid/hid-picolcd_fb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c > index e162a668fb7e..a549c42e8c90 100644 > --- a/drivers/hid/hid-picolcd_fb.c > +++ b/drivers/hid/hid-picolcd_fb.c > @@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info) > return 0; > } > > -/* Note this can't be const because of struct fb_info definition */ > -static struct fb_ops picolcdfb_ops = { > +static const struct fb_ops picolcdfb_ops = { > .owner = THIS_MODULE, > .fb_destroy = picolcd_fb_destroy, > .fb_read = fb_sys_read, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBEBBC432C0 for ; Mon, 2 Dec 2019 08:49:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9994A218AC for ; Mon, 2 Dec 2019 08:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725977AbfLBItU convert rfc822-to-8bit (ORCPT ); Mon, 2 Dec 2019 03:49:20 -0500 Received: from hygieia.sysophe.eu ([138.201.91.14]:42623 "EHLO hygieia.sysophe.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbfLBItU (ORCPT ); Mon, 2 Dec 2019 03:49:20 -0500 X-Greylist: delayed 504 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Dec 2019 03:49:19 EST Received: from aether.lan.sysophe.eu (unknown [IPv6:2001:a18:24b:8201:e8b:fdff:fea0:3408]) by smtp.sysophe.eu (Postfix) with ESMTPSA id B0DE6103DF1E1; Mon, 2 Dec 2019 09:35:27 +0100 (CET) Date: Mon, 2 Dec 2019 09:40:47 +0100 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Jani Nikula Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com, linux-input@vger.kernel.org, Daniel Vetter , Jiri Kosina Subject: Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops Message-ID: <20191202094047.34525a7d@aether.lan.sysophe.eu> In-Reply-To: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> References: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> X-Mailer: Claws Mail 3.17.4git3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Jani, On Fri, 29 Nov 2019 12:29:41 Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > v2: fix typo (Christophe de Dinechin) Fine with me. I don't think going through drm-misc would trigger any conflict, but adding Jiri to CC for the case there was any preference. Acked-by: Bruno Prémont > Cc: Bruno Prémont > Cc: linux-input@vger.kernel.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula > --- > drivers/hid/hid-picolcd_fb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c > index e162a668fb7e..a549c42e8c90 100644 > --- a/drivers/hid/hid-picolcd_fb.c > +++ b/drivers/hid/hid-picolcd_fb.c > @@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info) > return 0; > } > > -/* Note this can't be const because of struct fb_info definition */ > -static struct fb_ops picolcdfb_ops = { > +static const struct fb_ops picolcdfb_ops = { > .owner = THIS_MODULE, > .fb_destroy = picolcd_fb_destroy, > .fb_read = fb_sys_read, From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= Subject: Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops Date: Mon, 2 Dec 2019 09:40:47 +0100 Message-ID: <20191202094047.34525a7d@aether.lan.sysophe.eu> References: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , intel-gfx@lists.freedesktop.org, Jiri Kosina , dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgSmFuaSwKCk9uIEZyaSwgMjkgTm92IDIwMTkgMTI6Mjk6NDEgSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGludGVsLmNvbT4gd3JvdGU6Cj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBz dHJ1Y3QgZmJfaW5mbyBpcyBjb25zdCwgd2UgY2FuIHN0YXJ0Cj4gbWFraW5nIHRoZSBvcHMgY29u c3QgYXMgd2VsbC4KPgo+IHYyOiBmaXgJdHlwbyAoQ2hyaXN0b3BoZSBkZSBEaW5lY2hpbikKCkZp bmUgd2l0aCBtZS4KSSBkb24ndCB0aGluayBnb2luZyB0aHJvdWdoIGRybS1taXNjIHdvdWxkIHRy aWdnZXIgYW55IGNvbmZsaWN0LCBidXQKYWRkaW5nIEppcmkgdG8gQ0MgZm9yIHRoZSBjYXNlIHRo ZXJlIHdhcyBhbnkgcHJlZmVyZW5jZS4KCkFja2VkLWJ5OiBCcnVubyBQcsOpbW9udCA8Ym9uYm9u c0BsaW51eC12c2VydmVyLm9yZz4KCj4gQ2M6IEJydW5vIFByw6ltb250IDxib25ib25zQGxpbnV4 LXZzZXJ2ZXIub3JnPgo+IENjOiBsaW51eC1pbnB1dEB2Z2VyLmtlcm5lbC5vcmcKPiBSZXZpZXdl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQtb2Zm LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2hpZC9oaWQtcGljb2xjZF9mYi5jIHwgMyArLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2hpZC9oaWQt cGljb2xjZF9mYi5jIGIvZHJpdmVycy9oaWQvaGlkLXBpY29sY2RfZmIuYwo+IGluZGV4IGUxNjJh NjY4ZmI3ZS4uYTU0OWM0MmU4YzkwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaGlkL2hpZC1waWNv bGNkX2ZiLmMKPiArKysgYi9kcml2ZXJzL2hpZC9oaWQtcGljb2xjZF9mYi5jCj4gQEAgLTQxNyw4 ICs0MTcsNyBAQCBzdGF0aWMgaW50IHBpY29sY2Rfc2V0X3BhcihzdHJ1Y3QgZmJfaW5mbyAqaW5m bykKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC0vKiBOb3RlIHRoaXMgY2FuJ3QgYmUgY29uc3Qg YmVjYXVzZSBvZiBzdHJ1Y3QgZmJfaW5mbyBkZWZpbml0aW9uICovCj4gLXN0YXRpYyBzdHJ1Y3Qg ZmJfb3BzIHBpY29sY2RmYl9vcHMgPSB7Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZmJfb3BzIHBp Y29sY2RmYl9vcHMgPSB7Cj4gIAkub3duZXIgICAgICAgID0gVEhJU19NT0RVTEUsCj4gIAkuZmJf ZGVzdHJveSAgID0gcGljb2xjZF9mYl9kZXN0cm95LAo+ICAJLmZiX3JlYWQgICAgICA9IGZiX3N5 c19yZWFkLAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7054DC43215 for ; Mon, 2 Dec 2019 08:49:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F7E521774 for ; Mon, 2 Dec 2019 08:49:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F7E521774 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-vserver.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E04C489CB2; Mon, 2 Dec 2019 08:49:20 +0000 (UTC) X-Greylist: delayed 500 seconds by postgrey-1.36 at gabe; Mon, 02 Dec 2019 08:49:19 UTC Received: from hygieia.sysophe.eu (hygieia.sysophe.eu [138.201.91.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAFFE89CB2; Mon, 2 Dec 2019 08:49:19 +0000 (UTC) Received: from aether.lan.sysophe.eu (unknown [IPv6:2001:a18:24b:8201:e8b:fdff:fea0:3408]) by smtp.sysophe.eu (Postfix) with ESMTPSA id B0DE6103DF1E1; Mon, 2 Dec 2019 09:35:27 +0100 (CET) Date: Mon, 2 Dec 2019 09:40:47 +0100 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Jani Nikula Message-ID: <20191202094047.34525a7d@aether.lan.sysophe.eu> In-Reply-To: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> References: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> X-Mailer: Claws Mail 3.17.4git3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 11/14] HID: picoLCD: constify fb ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , intel-gfx@lists.freedesktop.org, Jiri Kosina , dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191202084047.1aEvjGhtSYmr4RzuVRWKBN4Yo7_75bl89X-Im4wr9-g@z> SGkgSmFuaSwKCk9uIEZyaSwgMjkgTm92IDIwMTkgMTI6Mjk6NDEgSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGludGVsLmNvbT4gd3JvdGU6Cj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBz dHJ1Y3QgZmJfaW5mbyBpcyBjb25zdCwgd2UgY2FuIHN0YXJ0Cj4gbWFraW5nIHRoZSBvcHMgY29u c3QgYXMgd2VsbC4KPgo+IHYyOiBmaXgJdHlwbyAoQ2hyaXN0b3BoZSBkZSBEaW5lY2hpbikKCkZp bmUgd2l0aCBtZS4KSSBkb24ndCB0aGluayBnb2luZyB0aHJvdWdoIGRybS1taXNjIHdvdWxkIHRy aWdnZXIgYW55IGNvbmZsaWN0LCBidXQKYWRkaW5nIEppcmkgdG8gQ0MgZm9yIHRoZSBjYXNlIHRo ZXJlIHdhcyBhbnkgcHJlZmVyZW5jZS4KCkFja2VkLWJ5OiBCcnVubyBQcsOpbW9udCA8Ym9uYm9u c0BsaW51eC12c2VydmVyLm9yZz4KCj4gQ2M6IEJydW5vIFByw6ltb250IDxib25ib25zQGxpbnV4 LXZzZXJ2ZXIub3JnPgo+IENjOiBsaW51eC1pbnB1dEB2Z2VyLmtlcm5lbC5vcmcKPiBSZXZpZXdl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQtb2Zm LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2hpZC9oaWQtcGljb2xjZF9mYi5jIHwgMyArLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2hpZC9oaWQt cGljb2xjZF9mYi5jIGIvZHJpdmVycy9oaWQvaGlkLXBpY29sY2RfZmIuYwo+IGluZGV4IGUxNjJh NjY4ZmI3ZS4uYTU0OWM0MmU4YzkwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaGlkL2hpZC1waWNv bGNkX2ZiLmMKPiArKysgYi9kcml2ZXJzL2hpZC9oaWQtcGljb2xjZF9mYi5jCj4gQEAgLTQxNyw4 ICs0MTcsNyBAQCBzdGF0aWMgaW50IHBpY29sY2Rfc2V0X3BhcihzdHJ1Y3QgZmJfaW5mbyAqaW5m bykKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC0vKiBOb3RlIHRoaXMgY2FuJ3QgYmUgY29uc3Qg YmVjYXVzZSBvZiBzdHJ1Y3QgZmJfaW5mbyBkZWZpbml0aW9uICovCj4gLXN0YXRpYyBzdHJ1Y3Qg ZmJfb3BzIHBpY29sY2RmYl9vcHMgPSB7Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZmJfb3BzIHBp Y29sY2RmYl9vcHMgPSB7Cj4gIAkub3duZXIgICAgICAgID0gVEhJU19NT0RVTEUsCj4gIAkuZmJf ZGVzdHJveSAgID0gcGljb2xjZF9mYl9kZXN0cm95LAo+ICAJLmZiX3JlYWQgICAgICA9IGZiX3N5 c19yZWFkLAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4