From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD253C432C0 for ; Mon, 2 Dec 2019 09:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C07B20705 for ; Mon, 2 Dec 2019 09:42:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="V4EK0qUs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727312AbfLBJmZ (ORCPT ); Mon, 2 Dec 2019 04:42:25 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:55688 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbfLBJmZ (ORCPT ); Mon, 2 Dec 2019 04:42:25 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 81932DD; Mon, 2 Dec 2019 10:42:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575279741; bh=CJ9EKy9GD3pmgiuuqszs9TmlcNonnvP01gpT9zZMShw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V4EK0qUsUWrspiB9A+zbhzHJgijD2tv2xBmg6vK0ZyUTrE55SygjtWGVe9qs1XXPV Wr61yGx4Bon9ZNPPhIu9c7vA9UC4eslIyMhDCimsqn/JUewYnOoDvpphYucf4xs+GL xMkd2GW6+g3EVAmCpGEEhns8KJ3IY7RItlmXE3fw= Date: Mon, 2 Dec 2019 11:42:13 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Geert Uytterhoeven , Geert Uytterhoeven , Neil Armstrong , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Andrzej Hajda , Simon Horman , Magnus Damm , Peter Rosin , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Chris Paterson , Biju Das , Kieran Bingham , Jacopo Mondi Subject: Re: [PATCH v4 12/13] [HACK] drm/bridge: lvds-codec: Enforce device specific compatible strings Message-ID: <20191202094213.GA4929@pendragon.ideasonboard.com> References: <1573660292-10629-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573660292-10629-13-git-send-email-fabrizio.castro@bp.renesas.com> <20191119001616.GL5171@pendragon.ideasonboard.com> <20191119215155.GB17590@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Fabrizio, On Mon, Nov 25, 2019 at 11:17:25AM +0000, Fabrizio Castro wrote: > On 22 November 2019 08:17 Geert Uytterhoeven wrote: > > On Thu, Nov 21, 2019 at 5:00 PM Fabrizio Castro wrote: > >> On 19 November 2019 21:52 Laurent Pinchart wrote: > >>> On Tue, Nov 19, 2019 at 11:17:34AM +0000, Fabrizio Castro wrote: > >>>> On 19 November 2019 00:16 Laurent Pinchart wrote: > >>>>> On Wed, Nov 13, 2019 at 03:51:31PM +0000, Fabrizio Castro wrote: > >>>>>> The lvds-codec driver is a generic stub for transparent LVDS > >>>>>> encoders and decoders. > >>>>>> It's good practice to list a device specific compatible string > >>>>>> before the generic fallback (if any) in the DT node for the relevant > >>>>>> LVDS encoder/decoder, and it's also required by the dt-bindings. > >>>>>> A notable exception to the generic fallback mechanism is the case > >>>>>> of "thine,thc63lvdm83d", as documented in: > >>>>>> Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt > >>>>>> This patch enforces the adoption of a device specific compatible > >>>>>> string (as fist string in the list), by using markers for the > >>>>>> compatible string we match against and the index of the matching > >>>>>> compatible string in the list. > >>>>>> > >>>>>> Signed-off-by: Fabrizio Castro > >>>>>> > >>>>>> --- > >>>>>> Hi Laurent, > >>>>>> > >>>>>> I don't think we need to do anything in the driver to address your > >>>>>> comment, as we can "enforce" this with the bindings (please see the > >>>>>> next patch, as it would help with the "enforcing" of the compatible > >>>>>> string for the thine device). > >>>>>> I am sending this patch only so that you can see what a possible > >>>>>> solution in the driver could look like. > >>>>>> > >>>>>> v3->v4: > >>>>>> * New patch addressing the below comment from Laurent: > >>>>>> "I think the lvds-decoder driver should error out at probe time if only > >>>>>> one compatible string is listed." > >>>>>> > >>>>>> --- a/drivers/gpu/drm/bridge/lvds-codec.c > >>>>>> +++ b/drivers/gpu/drm/bridge/lvds-codec.c > >>>>>> > >>>>>> @@ -65,7 +70,30 @@ static int lvds_codec_probe(struct platform_device *pdev) > >>>>>> if (!lvds_codec) > >>>>>> return -ENOMEM; > >>>>>> > >>>>>> - lvds_codec->connector_type = (u32)of_device_get_match_data(&pdev->dev); > >>>>>> + lvds_codec->data = of_device_get_match_data(&pdev->dev); > >>>>>> + if (!lvds_codec->data) > >>>>>> + return -EINVAL; > >>>>>> + > >>>>>> + /* > >>>>>> + * If we haven't matched a device specific compatible string, we need > >>>>>> + * to work out if the generic compatible string we matched against was > >>>>>> + * listed first in the compatible property. > >>>>>> + */ > >>>>> > >>>>> Can't we do this unconditionally, and thus drop the lvds_codec_data > >>>>> structure ? > >>>> > >>>> I don't think so, and the reason for this is that we have a corner case for > >>>> thine,thc63lvdm83d. Here is what's allowed (according to the documentation) > >>>> from what's supported upstream (+ this series): > >>>> "ti,ds90c185", "lvds-encoder" > >>>> "ti,ds90c187", "lvds-encoder" > >>>> "ti,sn75lvds83", "lvds-encoder" > >>>> "ti,ds90cf384a", "lvds-decoder" > >>>> "thine,thc63lvdm83d" > >>>> > >>>> As you can see from the examples above, in most cases it's enough to say it's > >>>> all good when we match a compatible string with index > 0, but for the thine > >>>> device you _have_ to match the string with index 0 as that's what's currently > >>>> documented (please see thine,thc63lvdm83d.txt) and that's what's supported > >>>> by device trees already (please see arch/arm/boot/dts/r8a7779-marzen.dts). > >>> > >>> How about the following logic ? > >>> > >>> if (match_index("lvds-encoder") == 0 || > >>> match_index("lvds-decoder") == 0) > >>> return -EINVAL; > >>> > >>> > >> > >> Now I see what you mean > >> > >>>> This patch "classifies" compatible strings, and it considers a good match > >>>> device specific compatible strings, or generic compatible strings as long > >>>> as they are not listed first. > >>>> > >>>> These days you can leverage the yaml files to validate the device trees, > >>>> therefore we should be focusing on writing yaml files in such a way we only > >>>> pass the checks we mean to, and by checks I mean: > >>>> make dtbs_check > >>>> > >>>> or more specifically, for this series: > >>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > >>>> > >>>> and that's of course on top of make dt_binding_check. > >>> > >>> Sure, but that doesn't prevent anyone ignoring the validation. > >>> > >>>> It's a very common requirement to have a part number specific compatible > >>>> string first followed by a generic (fallback) compatible string in the device trees, > >>>> most drivers for Renesas SoCs have similar requirements. > >>>> > >>>> If we start doing this here, we'll end up doing it elsewhere as well, and I really > >>>> think we shouldn't, but others may see things differently, so I'll wait for others > >>>> (and yourself with further comments) to jump in before doing any more work > >>>> on this patch. > >>> > >>> I agree with this argument, it would set a precedent, and is probably > >>> not worth duplicating similar code in all drivers. I wonder if this is > >>> something we could handle with core helpers, but maybe it's overkill. > >> > >> I was hoping others would comment as well, but perhaps this topic is not too exciting. > >> > >> Geert, what do you think about this? Is this something we should enforce > >> in drivers? > > > > So IIUIC, you want to enforce the presence of both specific and generic > > compatible values (in that order) in the driver (except for > > "thine,thc63lvdm83d", as that predates the introduction of the generic > > compatible value)? > > Yeah, this is what Laurent would want ideally. > > > However, the driver would not really care about the actual hardware-specific > > value, as it would still match against the generic one, and the > > hardware-specific one may not even be listed in the driver's match table? > > Exactly. > > > By definition, you can have one or more compatible values listed in a > > device node, from most-specific to least-specific. Typically the driver > > cannot know if a more specific value is missing, but YAML DT binding > > validation can. > > > > In this case it is a bit special, as there is a generic one involved, so > > you can assume there should be a more specific one, too. > > If you want to handle this in the core, you probably need to add an > > "is_generic" flag to struct of_device_id. > > That's actually an interesting way of looking at this. > Laurent? I like the idea, it's better than doing it in each driver. > > Rob/Mark? Ping ? > >>>>>> + if (!lvds_codec->data->device_specific) { > >>>>>> + const struct of_device_id *match; > >>>>>> + int compatible_index; > >>>>>> + > >>>>>> + match = of_match_node(dev->driver->of_match_table, > >>>>>> + dev->of_node); > >>>>>> + compatible_index = of_property_match_string(dev->of_node, > >>>>>> + "compatible", > >>>>>> + match->compatible); > >>>>>> + if (compatible_index == 0) { > >>>>>> + dev_err(dev, "Device specific compatible needed\n"); > >>>>>> + return -EINVAL; > > > > -ENODEV? > > So a "more generic" driver can take over? > > > >>>>>> + } > >>>>>> + } > >>>>>> + > >>>>>> lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown", > >>>>>> GPIOD_OUT_HIGH); > >>>>>> if (IS_ERR(lvds_codec->powerdown_gpio)) { > >>>>>> @@ -92,7 +120,7 @@ static int lvds_codec_probe(struct platform_device *pdev) > >>>>>> > >>>>>> lvds_codec->panel_bridge = > >>>>>> devm_drm_panel_bridge_add_typed(dev, panel, > >>>>>> - lvds_codec->connector_type); > >>>>>> + lvds_codec->data->connector_type); > >>>>>> if (IS_ERR(lvds_codec->panel_bridge)) > >>>>>> return PTR_ERR(lvds_codec->panel_bridge); > >>>>>> > >>>>>> @@ -119,18 +147,33 @@ static int lvds_codec_remove(struct platform_device *pdev) > >>>>>> return 0; > >>>>>> } > >>>>>> > >>>>>> +static const struct lvds_codec_data lvds_codec_decoder_data = { > >>>>>> + .connector_type = DRM_MODE_CONNECTOR_DPI, > >>>>>> + .device_specific = false, > >>>>>> +}; > >>>>>> + > >>>>>> +static const struct lvds_codec_data lvds_codec_encoder_data = { > >>>>>> + .connector_type = DRM_MODE_CONNECTOR_LVDS, > >>>>>> + .device_specific = false, > >>>>>> +}; > >>>>>> + > >>>>>> +static const struct lvds_codec_data lvds_codec_thc63lvdm83d_data = { > >>>>>> + .connector_type = DRM_MODE_CONNECTOR_LVDS, > >>>>>> + .device_specific = true, > >>>>>> +}; > >>>>>> + > >>>>>> static const struct of_device_id lvds_codec_match[] = { > >>>>>> { > >>>>>> .compatible = "lvds-decoder", > >>>>>> - .data = (void *)DRM_MODE_CONNECTOR_DPI, > >>>>>> + .data = &lvds_codec_decoder_data, > >>>>>> }, > >>>>>> { > >>>>>> .compatible = "lvds-encoder", > >>>>>> - .data = (void *)DRM_MODE_CONNECTOR_LVDS, > >>>>>> + .data = &lvds_codec_encoder_data, > >>>>>> }, > >>>>>> { > >>>>>> .compatible = "thine,thc63lvdm83d", > >>>>>> - .data = (void *)DRM_MODE_CONNECTOR_LVDS, > >>>>>> + .data = &lvds_codec_thc63lvdm83d_data, > >>>>>> }, > >>>>>> {}, > >>>>>> }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 12/13] [HACK] drm/bridge: lvds-codec: Enforce device specific compatible strings Date: Mon, 2 Dec 2019 11:42:13 +0200 Message-ID: <20191202094213.GA4929@pendragon.ideasonboard.com> References: <1573660292-10629-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573660292-10629-13-git-send-email-fabrizio.castro@bp.renesas.com> <20191119001616.GL5171@pendragon.ideasonboard.com> <20191119215155.GB17590@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 143B889BA5 for ; Mon, 2 Dec 2019 09:42:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Mark Rutland , Simon Horman , Chris Paterson , Geert Uytterhoeven , Neil Armstrong , David Airlie , Kieran Bingham , Magnus Damm , "dri-devel@lists.freedesktop.org" , Biju Das , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , Rob Herring , Geert Uytterhoeven , Jacopo Mondi , Peter Rosin List-Id: dri-devel@lists.freedesktop.org SGkgRmFicml6aW8sCgpPbiBNb24sIE5vdiAyNSwgMjAxOSBhdCAxMToxNzoyNUFNICswMDAwLCBG YWJyaXppbyBDYXN0cm8gd3JvdGU6Cj4gT24gMjIgTm92ZW1iZXIgMjAxOSAwODoxNyBHZWVydCBV eXR0ZXJob2V2ZW4gd3JvdGU6Cj4gPiBPbiBUaHUsIE5vdiAyMSwgMjAxOSBhdCA1OjAwIFBNIEZh YnJpemlvIENhc3RybyB3cm90ZToKPiA+PiBPbiAxOSBOb3ZlbWJlciAyMDE5IDIxOjUyIExhdXJl bnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4+IE9uIFR1ZSwgTm92IDE5LCAyMDE5IGF0IDExOjE3OjM0 QU0gKzAwMDAsIEZhYnJpemlvIENhc3RybyB3cm90ZToKPiA+Pj4+IE9uIDE5IE5vdmVtYmVyIDIw MTkgMDA6MTYgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4+PiBPbiBXZWQsIE5vdiAxMywg MjAxOSBhdCAwMzo1MTozMVBNICswMDAwLCBGYWJyaXppbyBDYXN0cm8gd3JvdGU6Cj4gPj4+Pj4+ IFRoZSBsdmRzLWNvZGVjIGRyaXZlciBpcyBhIGdlbmVyaWMgc3R1YiBmb3IgdHJhbnNwYXJlbnQg TFZEUwo+ID4+Pj4+PiBlbmNvZGVycyBhbmQgZGVjb2RlcnMuCj4gPj4+Pj4+IEl0J3MgZ29vZCBw cmFjdGljZSB0byBsaXN0IGEgZGV2aWNlIHNwZWNpZmljIGNvbXBhdGlibGUgc3RyaW5nCj4gPj4+ Pj4+IGJlZm9yZSB0aGUgZ2VuZXJpYyBmYWxsYmFjayAoaWYgYW55KSBpbiB0aGUgRFQgbm9kZSBm b3IgdGhlIHJlbGV2YW50Cj4gPj4+Pj4+IExWRFMgZW5jb2Rlci9kZWNvZGVyLCBhbmQgaXQncyBh bHNvIHJlcXVpcmVkIGJ5IHRoZSBkdC1iaW5kaW5ncy4KPiA+Pj4+Pj4gQSBub3RhYmxlIGV4Y2Vw dGlvbiB0byB0aGUgZ2VuZXJpYyBmYWxsYmFjayBtZWNoYW5pc20gaXMgdGhlIGNhc2UKPiA+Pj4+ Pj4gb2YgInRoaW5lLHRoYzYzbHZkbTgzZCIsIGFzIGRvY3VtZW50ZWQgaW46Cj4gPj4+Pj4+IERv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2 M2x2ZG04M2QudHh0Cj4gPj4+Pj4+IFRoaXMgcGF0Y2ggZW5mb3JjZXMgdGhlIGFkb3B0aW9uIG9m IGEgZGV2aWNlIHNwZWNpZmljIGNvbXBhdGlibGUKPiA+Pj4+Pj4gc3RyaW5nIChhcyBmaXN0IHN0 cmluZyBpbiB0aGUgbGlzdCksIGJ5IHVzaW5nIG1hcmtlcnMgZm9yIHRoZQo+ID4+Pj4+PiBjb21w YXRpYmxlIHN0cmluZyB3ZSBtYXRjaCBhZ2FpbnN0IGFuZCB0aGUgaW5kZXggb2YgdGhlIG1hdGNo aW5nCj4gPj4+Pj4+IGNvbXBhdGlibGUgc3RyaW5nIGluIHRoZSBsaXN0Lgo+ID4+Pj4+Pgo+ID4+ Pj4+PiBTaWduZWQtb2ZmLWJ5OiBGYWJyaXppbyBDYXN0cm8gPGZhYnJpemlvLmNhc3Ryb0BicC5y ZW5lc2FzLmNvbT4KPiA+Pj4+Pj4KPiA+Pj4+Pj4gLS0tCj4gPj4+Pj4+IEhpIExhdXJlbnQsCj4g Pj4+Pj4+Cj4gPj4+Pj4+IEkgZG9uJ3QgdGhpbmsgd2UgbmVlZCB0byBkbyBhbnl0aGluZyBpbiB0 aGUgZHJpdmVyIHRvIGFkZHJlc3MgeW91cgo+ID4+Pj4+PiBjb21tZW50LCBhcyB3ZSBjYW4gImVu Zm9yY2UiIHRoaXMgd2l0aCB0aGUgYmluZGluZ3MgKHBsZWFzZSBzZWUgdGhlCj4gPj4+Pj4+IG5l eHQgcGF0Y2gsIGFzIGl0IHdvdWxkIGhlbHAgd2l0aCB0aGUgImVuZm9yY2luZyIgb2YgdGhlIGNv bXBhdGlibGUKPiA+Pj4+Pj4gc3RyaW5nIGZvciB0aGUgdGhpbmUgZGV2aWNlKS4KPiA+Pj4+Pj4g SSBhbSBzZW5kaW5nIHRoaXMgcGF0Y2ggb25seSBzbyB0aGF0IHlvdSBjYW4gc2VlIHdoYXQgYSBw b3NzaWJsZQo+ID4+Pj4+PiBzb2x1dGlvbiBpbiB0aGUgZHJpdmVyIGNvdWxkIGxvb2sgbGlrZS4K PiA+Pj4+Pj4KPiA+Pj4+Pj4gdjMtPnY0Ogo+ID4+Pj4+PiAqIE5ldyBwYXRjaCBhZGRyZXNzaW5n IHRoZSBiZWxvdyBjb21tZW50IGZyb20gTGF1cmVudDoKPiA+Pj4+Pj4gIkkgdGhpbmsgdGhlIGx2 ZHMtZGVjb2RlciBkcml2ZXIgc2hvdWxkIGVycm9yIG91dCBhdCBwcm9iZSB0aW1lIGlmIG9ubHkK PiA+Pj4+Pj4gb25lIGNvbXBhdGlibGUgc3RyaW5nIGlzIGxpc3RlZC4iCj4gPj4+Pj4+Cj4gPj4+ Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvbHZkcy1jb2RlYy5jCj4gPj4+Pj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvbHZkcy1jb2RlYy5jCj4gPj4+Pj4+Cj4gPj4+Pj4+ IEBAIC02NSw3ICs3MCwzMCBAQCBzdGF0aWMgaW50IGx2ZHNfY29kZWNfcHJvYmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiA+Pj4+Pj4gICAgICAgICBpZiAoIWx2ZHNfY29kZWMpCj4g Pj4+Pj4+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPiA+Pj4+Pj4KPiA+Pj4+Pj4g LSAgICAgICBsdmRzX2NvZGVjLT5jb25uZWN0b3JfdHlwZSA9ICh1MzIpb2ZfZGV2aWNlX2dldF9t YXRjaF9kYXRhKCZwZGV2LT5kZXYpOwo+ID4+Pj4+PiArICAgICAgIGx2ZHNfY29kZWMtPmRhdGEg PSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7Cj4gPj4+Pj4+ICsgICAgICAg aWYgKCFsdmRzX2NvZGVjLT5kYXRhKQo+ID4+Pj4+PiArICAgICAgICAgICAgICAgcmV0dXJuIC1F SU5WQUw7Cj4gPj4+Pj4+ICsKPiA+Pj4+Pj4gKyAgICAgICAvKgo+ID4+Pj4+PiArICAgICAgICAq IElmIHdlIGhhdmVuJ3QgbWF0Y2hlZCBhIGRldmljZSBzcGVjaWZpYyBjb21wYXRpYmxlIHN0cmlu Zywgd2UgbmVlZAo+ID4+Pj4+PiArICAgICAgICAqIHRvIHdvcmsgb3V0IGlmIHRoZSBnZW5lcmlj IGNvbXBhdGlibGUgc3RyaW5nIHdlIG1hdGNoZWQgYWdhaW5zdCB3YXMKPiA+Pj4+Pj4gKyAgICAg ICAgKiBsaXN0ZWQgZmlyc3QgaW4gdGhlIGNvbXBhdGlibGUgcHJvcGVydHkuCj4gPj4+Pj4+ICsg ICAgICAgICovCj4gPj4+Pj4KPiA+Pj4+PiBDYW4ndCB3ZSBkbyB0aGlzIHVuY29uZGl0aW9uYWxs eSwgYW5kIHRodXMgZHJvcCB0aGUgbHZkc19jb2RlY19kYXRhCj4gPj4+Pj4gc3RydWN0dXJlID8K PiA+Pj4+Cj4gPj4+PiBJIGRvbid0IHRoaW5rIHNvLCBhbmQgdGhlIHJlYXNvbiBmb3IgdGhpcyBp cyB0aGF0IHdlIGhhdmUgYSBjb3JuZXIgY2FzZSBmb3IKPiA+Pj4+IHRoaW5lLHRoYzYzbHZkbTgz ZC4gSGVyZSBpcyB3aGF0J3MgYWxsb3dlZCAoYWNjb3JkaW5nIHRvIHRoZSBkb2N1bWVudGF0aW9u KQo+ID4+Pj4gZnJvbSB3aGF0J3Mgc3VwcG9ydGVkIHVwc3RyZWFtICgrIHRoaXMgc2VyaWVzKToK PiA+Pj4+ICJ0aSxkczkwYzE4NSIsICJsdmRzLWVuY29kZXIiCj4gPj4+PiAidGksZHM5MGMxODci LCAibHZkcy1lbmNvZGVyIgo+ID4+Pj4gInRpLHNuNzVsdmRzODMiLCAibHZkcy1lbmNvZGVyIgo+ ID4+Pj4gInRpLGRzOTBjZjM4NGEiLCAibHZkcy1kZWNvZGVyIgo+ID4+Pj4gInRoaW5lLHRoYzYz bHZkbTgzZCIKPiA+Pj4+Cj4gPj4+PiBBcyB5b3UgY2FuIHNlZSBmcm9tIHRoZSBleGFtcGxlcyBh Ym92ZSwgaW4gbW9zdCBjYXNlcyBpdCdzIGVub3VnaCB0byBzYXkgaXQncwo+ID4+Pj4gYWxsIGdv b2Qgd2hlbiB3ZSBtYXRjaCBhIGNvbXBhdGlibGUgc3RyaW5nIHdpdGggaW5kZXggPiAwLCBidXQg Zm9yIHRoZSB0aGluZQo+ID4+Pj4gZGV2aWNlIHlvdSBfaGF2ZV8gdG8gbWF0Y2ggdGhlIHN0cmlu ZyB3aXRoIGluZGV4IDAgYXMgdGhhdCdzIHdoYXQncyBjdXJyZW50bHkKPiA+Pj4+IGRvY3VtZW50 ZWQgKHBsZWFzZSBzZWUgdGhpbmUsdGhjNjNsdmRtODNkLnR4dCkgYW5kIHRoYXQncyB3aGF0J3Mg c3VwcG9ydGVkCj4gPj4+PiBieSBkZXZpY2UgdHJlZXMgYWxyZWFkeSAocGxlYXNlIHNlZSBhcmNo L2FybS9ib290L2R0cy9yOGE3Nzc5LW1hcnplbi5kdHMpLgo+ID4+Pgo+ID4+PiBIb3cgYWJvdXQg dGhlIGZvbGxvd2luZyBsb2dpYyA/Cj4gPj4+Cj4gPj4+ICAgICAgIGlmIChtYXRjaF9pbmRleCgi bHZkcy1lbmNvZGVyIikgPT0gMCB8fAo+ID4+PiAgICAgICAgICAgbWF0Y2hfaW5kZXgoImx2ZHMt ZGVjb2RlciIpID09IDApCj4gPj4+ICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gPj4+ Cj4gPj4+Cj4gPj4KPiA+PiBOb3cgSSBzZWUgd2hhdCB5b3UgbWVhbgo+ID4+Cj4gPj4+PiBUaGlz IHBhdGNoICJjbGFzc2lmaWVzIiBjb21wYXRpYmxlIHN0cmluZ3MsIGFuZCBpdCBjb25zaWRlcnMg YSBnb29kIG1hdGNoCj4gPj4+PiBkZXZpY2Ugc3BlY2lmaWMgY29tcGF0aWJsZSBzdHJpbmdzLCBv ciBnZW5lcmljIGNvbXBhdGlibGUgc3RyaW5ncyBhcyBsb25nCj4gPj4+PiBhcyB0aGV5IGFyZSBu b3QgbGlzdGVkIGZpcnN0Lgo+ID4+Pj4KPiA+Pj4+IFRoZXNlIGRheXMgeW91IGNhbiBsZXZlcmFn ZSB0aGUgeWFtbCBmaWxlcyB0byB2YWxpZGF0ZSB0aGUgZGV2aWNlIHRyZWVzLAo+ID4+Pj4gdGhl cmVmb3JlIHdlIHNob3VsZCBiZSBmb2N1c2luZyBvbiB3cml0aW5nIHlhbWwgZmlsZXMgaW4gc3Vj aCBhIHdheSB3ZSBvbmx5Cj4gPj4+PiBwYXNzIHRoZSBjaGVja3Mgd2UgbWVhbiB0bywgYW5kIGJ5 IGNoZWNrcyBJIG1lYW46Cj4gPj4+PiBtYWtlIGR0YnNfY2hlY2sKPiA+Pj4+Cj4gPj4+PiBvciBt b3JlIHNwZWNpZmljYWxseSwgZm9yIHRoaXMgc2VyaWVzOgo+ID4+Pj4gbWFrZSBkdGJzX2NoZWNr ICBEVF9TQ0hFTUFfRklMRVM9RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3Bs YXkvYnJpZGdlL2x2ZHMtY29kZWMueWFtbAo+ID4+Pj4KPiA+Pj4+IGFuZCB0aGF0J3Mgb2YgY291 cnNlIG9uIHRvcCBvZiBtYWtlIGR0X2JpbmRpbmdfY2hlY2suCj4gPj4+Cj4gPj4+IFN1cmUsIGJ1 dCB0aGF0IGRvZXNuJ3QgcHJldmVudCBhbnlvbmUgaWdub3JpbmcgdGhlIHZhbGlkYXRpb24uCj4g Pj4+Cj4gPj4+PiBJdCdzIGEgdmVyeSBjb21tb24gcmVxdWlyZW1lbnQgdG8gaGF2ZSBhIHBhcnQg bnVtYmVyIHNwZWNpZmljIGNvbXBhdGlibGUKPiA+Pj4+IHN0cmluZyBmaXJzdCBmb2xsb3dlZCBi eSBhIGdlbmVyaWMgKGZhbGxiYWNrKSBjb21wYXRpYmxlIHN0cmluZyBpbiB0aGUgZGV2aWNlIHRy ZWVzLAo+ID4+Pj4gbW9zdCBkcml2ZXJzIGZvciBSZW5lc2FzIFNvQ3MgaGF2ZSBzaW1pbGFyIHJl cXVpcmVtZW50cy4KPiA+Pj4+Cj4gPj4+PiBJZiB3ZSBzdGFydCBkb2luZyB0aGlzIGhlcmUsIHdl J2xsIGVuZCB1cCBkb2luZyBpdCBlbHNld2hlcmUgYXMgd2VsbCwgYW5kIEkgcmVhbGx5Cj4gPj4+ PiB0aGluayB3ZSBzaG91bGRuJ3QsIGJ1dCBvdGhlcnMgbWF5IHNlZSB0aGluZ3MgZGlmZmVyZW50 bHksIHNvIEknbGwgd2FpdCBmb3Igb3RoZXJzCj4gPj4+PiAoYW5kIHlvdXJzZWxmIHdpdGggZnVy dGhlciBjb21tZW50cykgdG8ganVtcCBpbiBiZWZvcmUgZG9pbmcgYW55IG1vcmUgd29yawo+ID4+ Pj4gb24gdGhpcyBwYXRjaC4KPiA+Pj4KPiA+Pj4gSSBhZ3JlZSB3aXRoIHRoaXMgYXJndW1lbnQs IGl0IHdvdWxkIHNldCBhIHByZWNlZGVudCwgYW5kIGlzIHByb2JhYmx5Cj4gPj4+IG5vdCB3b3J0 aCBkdXBsaWNhdGluZyBzaW1pbGFyIGNvZGUgaW4gYWxsIGRyaXZlcnMuIEkgd29uZGVyIGlmIHRo aXMgaXMKPiA+Pj4gc29tZXRoaW5nIHdlIGNvdWxkIGhhbmRsZSB3aXRoIGNvcmUgaGVscGVycywg YnV0IG1heWJlIGl0J3Mgb3ZlcmtpbGwuCj4gPj4KPiA+PiBJIHdhcyBob3Bpbmcgb3RoZXJzIHdv dWxkIGNvbW1lbnQgYXMgd2VsbCwgYnV0IHBlcmhhcHMgdGhpcyB0b3BpYyBpcyBub3QgdG9vIGV4 Y2l0aW5nLgo+ID4+Cj4gPj4gR2VlcnQsIHdoYXQgZG8geW91IHRoaW5rIGFib3V0IHRoaXM/IElz IHRoaXMgc29tZXRoaW5nIHdlIHNob3VsZCBlbmZvcmNlCj4gPj4gaW4gZHJpdmVycz8KPiA+IAo+ ID4gU28gSUlVSUMsIHlvdSB3YW50IHRvIGVuZm9yY2UgdGhlIHByZXNlbmNlIG9mIGJvdGggc3Bl Y2lmaWMgYW5kIGdlbmVyaWMKPiA+IGNvbXBhdGlibGUgdmFsdWVzIChpbiB0aGF0IG9yZGVyKSBp biB0aGUgZHJpdmVyIChleGNlcHQgZm9yCj4gPiAidGhpbmUsdGhjNjNsdmRtODNkIiwgYXMgdGhh dCBwcmVkYXRlcyB0aGUgaW50cm9kdWN0aW9uIG9mIHRoZSBnZW5lcmljCj4gPiBjb21wYXRpYmxl IHZhbHVlKT8KPiAKPiBZZWFoLCB0aGlzIGlzIHdoYXQgTGF1cmVudCB3b3VsZCB3YW50IGlkZWFs bHkuCj4gCj4gPiBIb3dldmVyLCB0aGUgZHJpdmVyIHdvdWxkIG5vdCByZWFsbHkgY2FyZSBhYm91 dCB0aGUgYWN0dWFsIGhhcmR3YXJlLXNwZWNpZmljCj4gPiB2YWx1ZSwgYXMgaXQgd291bGQgc3Rp bGwgbWF0Y2ggYWdhaW5zdCB0aGUgZ2VuZXJpYyBvbmUsIGFuZCB0aGUKPiA+IGhhcmR3YXJlLXNw ZWNpZmljIG9uZSBtYXkgbm90IGV2ZW4gYmUgbGlzdGVkIGluIHRoZSBkcml2ZXIncyBtYXRjaCB0 YWJsZT8KPiAKPiBFeGFjdGx5Lgo+IAo+ID4gQnkgZGVmaW5pdGlvbiwgeW91IGNhbiBoYXZlIG9u ZSBvciBtb3JlIGNvbXBhdGlibGUgdmFsdWVzIGxpc3RlZCBpbiBhCj4gPiBkZXZpY2Ugbm9kZSwg ZnJvbSBtb3N0LXNwZWNpZmljIHRvIGxlYXN0LXNwZWNpZmljLiAgVHlwaWNhbGx5IHRoZSBkcml2 ZXIKPiA+IGNhbm5vdCBrbm93IGlmIGEgbW9yZSBzcGVjaWZpYyB2YWx1ZSBpcyBtaXNzaW5nLCBi dXQgWUFNTCBEVCBiaW5kaW5nCj4gPiB2YWxpZGF0aW9uIGNhbi4KPiA+IAo+ID4gSW4gdGhpcyBj YXNlIGl0IGlzIGEgYml0IHNwZWNpYWwsIGFzIHRoZXJlIGlzIGEgZ2VuZXJpYyBvbmUgaW52b2x2 ZWQsIHNvCj4gPiB5b3UgY2FuIGFzc3VtZSB0aGVyZSBzaG91bGQgYmUgYSBtb3JlIHNwZWNpZmlj IG9uZSwgdG9vLgo+ID4gSWYgeW91IHdhbnQgdG8gaGFuZGxlIHRoaXMgaW4gdGhlIGNvcmUsIHlv dSBwcm9iYWJseSBuZWVkIHRvIGFkZCBhbgo+ID4gImlzX2dlbmVyaWMiIGZsYWcgdG8gc3RydWN0 IG9mX2RldmljZV9pZC4KPiAKPiBUaGF0J3MgYWN0dWFsbHkgYW4gaW50ZXJlc3Rpbmcgd2F5IG9m IGxvb2tpbmcgYXQgdGhpcy4KPiBMYXVyZW50PwoKSSBsaWtlIHRoZSBpZGVhLCBpdCdzIGJldHRl ciB0aGFuIGRvaW5nIGl0IGluIGVhY2ggZHJpdmVyLgoKPiA+IFJvYi9NYXJrPwoKUGluZyA/Cgo+ ID4+Pj4+PiArICAgICAgIGlmICghbHZkc19jb2RlYy0+ZGF0YS0+ZGV2aWNlX3NwZWNpZmljKSB7 Cj4gPj4+Pj4+ICsgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkICptYXRj aDsKPiA+Pj4+Pj4gKyAgICAgICAgICAgICAgIGludCBjb21wYXRpYmxlX2luZGV4Owo+ID4+Pj4+ PiArCj4gPj4+Pj4+ICsgICAgICAgICAgICAgICBtYXRjaCA9IG9mX21hdGNoX25vZGUoZGV2LT5k cml2ZXItPm9mX21hdGNoX3RhYmxlLAo+ID4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRldi0+b2Zfbm9kZSk7Cj4gPj4+Pj4+ICsgICAgICAgICAgICAgICBjb21w YXRpYmxlX2luZGV4ID0gb2ZfcHJvcGVydHlfbWF0Y2hfc3RyaW5nKGRldi0+b2Zfbm9kZSwKPiA+ Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgImNvbXBhdGlibGUiLAo+ID4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtYXRjaC0+Y29tcGF0aWJsZSk7Cj4g Pj4+Pj4+ICsgICAgICAgICAgICAgICBpZiAoY29tcGF0aWJsZV9pbmRleCA9PSAwKSB7Cj4gPj4+ Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGRldl9lcnIoZGV2LCAiRGV2aWNlIHNwZWNpZmlj IGNvbXBhdGlibGUgbmVlZGVkXG4iKTsKPiA+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAg cmV0dXJuIC1FSU5WQUw7Cj4gPiAKPiA+IC1FTk9ERVY/Cj4gPiBTbyBhICJtb3JlIGdlbmVyaWMi IGRyaXZlciBjYW4gdGFrZSBvdmVyPwo+ID4gCj4gPj4+Pj4+ICsgICAgICAgICAgICAgICB9Cj4g Pj4+Pj4+ICsgICAgICAgfQo+ID4+Pj4+PiArCj4gPj4+Pj4+ICAgICAgICAgbHZkc19jb2RlYy0+ cG93ZXJkb3duX2dwaW8gPSBkZXZtX2dwaW9kX2dldF9vcHRpb25hbChkZXYsICJwb3dlcmRvd24i LAo+ID4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgR1BJT0RfT1VUX0hJR0gpOwo+ID4+Pj4+PiAgICAgICAgIGlmIChJU19F UlIobHZkc19jb2RlYy0+cG93ZXJkb3duX2dwaW8pKSB7Cj4gPj4+Pj4+IEBAIC05Miw3ICsxMjAs NyBAQCBzdGF0aWMgaW50IGx2ZHNfY29kZWNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikKPiA+Pj4+Pj4KPiA+Pj4+Pj4gICAgICAgICBsdmRzX2NvZGVjLT5wYW5lbF9icmlkZ2Ug PQo+ID4+Pj4+PiAgICAgICAgICAgICAgICAgZGV2bV9kcm1fcGFuZWxfYnJpZGdlX2FkZF90eXBl ZChkZXYsIHBhbmVsLAo+ID4+Pj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBsdmRzX2NvZGVjLT5jb25uZWN0b3JfdHlwZSk7Cj4gPj4+Pj4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsdmRzX2NvZGVjLT5kYXRhLT5jb25u ZWN0b3JfdHlwZSk7Cj4gPj4+Pj4+ICAgICAgICAgaWYgKElTX0VSUihsdmRzX2NvZGVjLT5wYW5l bF9icmlkZ2UpKQo+ID4+Pj4+PiAgICAgICAgICAgICAgICAgcmV0dXJuIFBUUl9FUlIobHZkc19j b2RlYy0+cGFuZWxfYnJpZGdlKTsKPiA+Pj4+Pj4KPiA+Pj4+Pj4gQEAgLTExOSwxOCArMTQ3LDMz IEBAIHN0YXRpYyBpbnQgbHZkc19jb2RlY19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikKPiA+Pj4+Pj4gICAgICAgICByZXR1cm4gMDsKPiA+Pj4+Pj4gIH0KPiA+Pj4+Pj4KPiA+ Pj4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgbHZkc19jb2RlY19kYXRhIGx2ZHNfY29kZWNfZGVj b2Rlcl9kYXRhID0gewo+ID4+Pj4+PiArICAgICAgIC5jb25uZWN0b3JfdHlwZSA9IERSTV9NT0RF X0NPTk5FQ1RPUl9EUEksCj4gPj4+Pj4+ICsgICAgICAgLmRldmljZV9zcGVjaWZpYyA9IGZhbHNl LAo+ID4+Pj4+PiArfTsKPiA+Pj4+Pj4gKwo+ID4+Pj4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBs dmRzX2NvZGVjX2RhdGEgbHZkc19jb2RlY19lbmNvZGVyX2RhdGEgPSB7Cj4gPj4+Pj4+ICsgICAg ICAgLmNvbm5lY3Rvcl90eXBlID0gRFJNX01PREVfQ09OTkVDVE9SX0xWRFMsCj4gPj4+Pj4+ICsg ICAgICAgLmRldmljZV9zcGVjaWZpYyA9IGZhbHNlLAo+ID4+Pj4+PiArfTsKPiA+Pj4+Pj4gKwo+ ID4+Pj4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBsdmRzX2NvZGVjX2RhdGEgbHZkc19jb2RlY190 aGM2M2x2ZG04M2RfZGF0YSA9IHsKPiA+Pj4+Pj4gKyAgICAgICAuY29ubmVjdG9yX3R5cGUgPSBE Uk1fTU9ERV9DT05ORUNUT1JfTFZEUywKPiA+Pj4+Pj4gKyAgICAgICAuZGV2aWNlX3NwZWNpZmlj ID0gdHJ1ZSwKPiA+Pj4+Pj4gK307Cj4gPj4+Pj4+ICsKPiA+Pj4+Pj4gIHN0YXRpYyBjb25zdCBz dHJ1Y3Qgb2ZfZGV2aWNlX2lkIGx2ZHNfY29kZWNfbWF0Y2hbXSA9IHsKPiA+Pj4+Pj4gICAgICAg ICB7Cj4gPj4+Pj4+ICAgICAgICAgICAgICAgICAuY29tcGF0aWJsZSA9ICJsdmRzLWRlY29kZXIi LAo+ID4+Pj4+PiAtICAgICAgICAgICAgICAgLmRhdGEgPSAodm9pZCAqKURSTV9NT0RFX0NPTk5F Q1RPUl9EUEksCj4gPj4+Pj4+ICsgICAgICAgICAgICAgICAuZGF0YSA9ICZsdmRzX2NvZGVjX2Rl Y29kZXJfZGF0YSwKPiA+Pj4+Pj4gICAgICAgICB9LAo+ID4+Pj4+PiAgICAgICAgIHsKPiA+Pj4+ Pj4gICAgICAgICAgICAgICAgIC5jb21wYXRpYmxlID0gImx2ZHMtZW5jb2RlciIsCj4gPj4+Pj4+ IC0gICAgICAgICAgICAgICAuZGF0YSA9ICh2b2lkICopRFJNX01PREVfQ09OTkVDVE9SX0xWRFMs Cj4gPj4+Pj4+ICsgICAgICAgICAgICAgICAuZGF0YSA9ICZsdmRzX2NvZGVjX2VuY29kZXJfZGF0 YSwKPiA+Pj4+Pj4gICAgICAgICB9LAo+ID4+Pj4+PiAgICAgICAgIHsKPiA+Pj4+Pj4gICAgICAg ICAgICAgICAgIC5jb21wYXRpYmxlID0gInRoaW5lLHRoYzYzbHZkbTgzZCIsCj4gPj4+Pj4+IC0g ICAgICAgICAgICAgICAuZGF0YSA9ICh2b2lkICopRFJNX01PREVfQ09OTkVDVE9SX0xWRFMsCj4g Pj4+Pj4+ICsgICAgICAgICAgICAgICAuZGF0YSA9ICZsdmRzX2NvZGVjX3RoYzYzbHZkbTgzZF9k YXRhLAo+ID4+Pj4+PiAgICAgICAgIH0sCj4gPj4+Pj4+ICAgICAgICAge30sCj4gPj4+Pj4+ICB9 OwoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==