All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org,
	Doug Goldstein <cardoe@cardoe.com>, Wei Liu <wl@xen.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH for-4.13] x86: re-order clang no integrated assembler tests
Date: Mon, 2 Dec 2019 12:46:47 +0100	[thread overview]
Message-ID: <20191202114647.GD980@Air-de-Roger> (raw)
In-Reply-To: <99fd0df5-14ee-b21c-ab03-32d427121e17@citrix.com>

On Mon, Dec 02, 2019 at 11:31:55AM +0000, Andrew Cooper wrote:
> On 02/12/2019 11:29, Roger Pau Monne wrote:
> > The tests to check whether the integrated assembler is capable of
> > building Xen should be performed before testing any assembler
> > features, or else the feature specific tests would be stale if the
> > integrated assembler is disabled afterwards.
> >
> > Fixes: ef286f67787a ('x86: move and fix clang .skip check')
> > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Reported-by: Doug Goldstein <cardoe@cardoe.com>
> > signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > Cc: Juergen Gross <jgross@suse.com>
> 
> Why 4.13?  They are only in 4.14 AFAICT

Oh sorry, I somehow assumed those ended up in 4.13.

> As for the change, looks plausible.  I'll throw it through CI.

I've got one already, which looks good (still in progress, but some
clang tests passed):

https://gitlab.com/xen-project/people/royger/xen/pipelines/99932608

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-12-02 11:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 11:29 [Xen-devel] [PATCH for-4.13] x86: re-order clang no integrated assembler tests Roger Pau Monne
2019-12-02 11:31 ` Andrew Cooper
2019-12-02 11:46   ` Roger Pau Monné [this message]
2019-12-03 10:03 ` Jan Beulich
2019-12-03 11:04   ` Roger Pau Monné
2019-12-03 11:16     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202114647.GD980@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.