All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH 1/9] token: handle join-before-accept-completion case
Date: Mon, 02 Dec 2019 17:57:44 +0100	[thread overview]
Message-ID: <20191202165744.GQ795@breakpoint.cc> (raw)
In-Reply-To: 09c7e48261b8c9040eb8d8864e42257b03894939.camel@redhat.com

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

Paolo Abeni <pabeni(a)redhat.com> wrote:
> On Mon, 2019-12-02 at 14:31 +0100, Florian Westphal wrote:
> > Paolo Abeni <pabeni(a)redhat.com> wrote:
> > > Note, with MPTCP v1, we will probably have to add additional checks
> > > here (e.g. con->fourth_ack must be true). Perhaps we can add that
> > > already?
> > 
> > I'm not sure this is the right location.  Should that check not
> > be done where we add the ssk to the conn_list?
> 
> My [mis?]understanding is that MP_JOIN should not be attemped before
> the msk is fully established (fourth_ack), so I thought it would be
> nice to catch that erroneous condition ASAP.

I see.  What would that buy us though wrt. error handling?

             reply	other threads:[~2019-12-02 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 16:57 Florian Westphal [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-12-02 15:00 [MPTCP] Re: [PATCH 1/9] token: handle join-before-accept-completion case Paolo Abeni
2019-12-02 13:31 Florian Westphal
2019-12-02 12:04 Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202165744.GQ795@breakpoint.cc \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.