From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Jürgen Groß" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"George Dunlap" <George.Dunlap@eu.citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
xen-devel@lists.xenproject.org,
"Roger Pau Monne" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH for-4.13] clang: do not enable live-patching support
Date: Mon, 2 Dec 2019 12:01:19 -0500 [thread overview]
Message-ID: <20191202170119.GA18997@char.us.oracle.com> (raw)
In-Reply-To: <db8386cf-1309-b24a-59a8-e0bd96f3749d@citrix.com>
On Mon, Dec 02, 2019 at 03:55:04PM +0000, Andrew Cooper wrote:
> On 02/12/2019 15:53, Konrad Rzeszutek Wilk wrote:
> >>> I plan to release ack the patch in case the missing maintainer's acks
> >>> are not coming in too late.
> >> I think Andy's objection was that there has been zero testing of
> >> livepatching on gcc. Maybe we can find someone to do a smoke-test.
> > As in integrate livepatch-build tools in osstest smoke-tests?
> > Because the livepatch test cases are in osstest, unless something went awry?
>
> The sum total of livepatch testing in OSSTest is using the hand-coded
> ELF objects from the tests/ directory.
>
> This is perhaps ok for the basic mechanism, but its not representative
> of actually building real livepatches using livepatch build tools.
True. But it tests the _hypervisor_ livepatch code.
I am thinking that this discussion about "oh, but livepatch-build tools don't work b/c"
is well <shrug> sucks but should never block an release as the core
livepatch functionality is OK.
Irrespective of that the testing of livepatch-build tools should be in osstest,
granted nobody has taken a step in this - but is somebody signing up for it?
[I can't, -ENOTIME]
>
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-02 16:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 16:01 [Xen-devel] [PATCH for-4.13] clang: do not enable live-patching support Roger Pau Monne
2019-11-27 16:14 ` Jan Beulich
2019-11-27 16:21 ` George Dunlap
2019-11-27 16:25 ` Jan Beulich
2019-11-27 16:35 ` Jürgen Groß
2019-11-27 16:42 ` George Dunlap
2019-12-02 15:53 ` Konrad Rzeszutek Wilk
2019-12-02 15:55 ` Andrew Cooper
2019-12-02 17:01 ` Konrad Rzeszutek Wilk [this message]
2019-12-03 9:17 ` George Dunlap
2019-12-06 20:21 ` Andrew Cooper
2019-12-06 20:58 ` Lars Kurth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202170119.GA18997@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.