From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E71DC432C3 for ; Mon, 2 Dec 2019 17:17:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F60A20672 for ; Mon, 2 Dec 2019 17:17:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CvxYYvpQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727589AbfLBRRe (ORCPT ); Mon, 2 Dec 2019 12:17:34 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:37668 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727553AbfLBRRd (ORCPT ); Mon, 2 Dec 2019 12:17:33 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D198309; Mon, 2 Dec 2019 18:17:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575307051; bh=s7J25vEgjKQ7uxoOTPNljX92zYrKAqcEPb8GugLEtKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CvxYYvpQEGQ2wAg7VTDGItUSAO2+4n/Fh61GcQkofU4QzuEPrnvknCP5928eTA21E V9jZ8yq+3pvtijpYgIGngJQ+f3ChrCRHt+bEEeA0WeUL0UoYSfnwbdefUxaixwdhWZ RFwHUReYF8AJzOwASZC0NlRXUHogvlMvrCfGn3ww= Date: Mon, 2 Dec 2019 19:17:24 +0200 From: Laurent Pinchart To: Boris Brezillon Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH v3 19/21] drm/panel: simple: Add support for Toshiba LTA089AC29000 panel Message-ID: <20191202171724.GS4929@pendragon.ideasonboard.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <20191023154512.9762-20-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191023154512.9762-20-boris.brezillon@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:10PM +0200, Boris Brezillon wrote: > Add a new entry for the Toshiba LTA089AC29000 panel. > > Signed-off-by: Boris Brezillon > --- > Changes in v3: > * None > --- > drivers/gpu/drm/panel/panel-simple.c | 36 ++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 5d487686d25c..27c92b44bd95 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2937,6 +2937,39 @@ static const struct panel_desc toshiba_lt089ac29000 = { > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > +static const struct drm_display_mode toshiba_lta089ac29000_mode = { > + .clock = 79500, > + .hdisplay = 1280, > + .hsync_start = 1280 + 192, > + .hsync_end = 1280 + 192 + 128, > + .htotal = 1280 + 192 + 128 + 64, > + .vdisplay = 768, > + .vsync_start = 768 + 20, > + .vsync_end = 768 + 20 + 7, > + .vtotal = 768 + 20 + 7 + 3, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc toshiba_lta089ac29000 = { > + .modes = &toshiba_lta089ac29000_mode, > + .num_modes = 1, > + .size = { > + .width = 194, > + .height = 116, > + }, > + /* > + * FIXME: > + * The panel supports 2 bus formats: jeida-24 and jeida-18. The > + * mode is selected through the 8b6b_SEL pin. If anyone ever needs > + * support for jeida-18 we should probably parse the 'data-mapping' > + * property. > + * In the unlikely event where 8b6b_SEL is connected to a GPIO, we'd > + * need a new infra to allow bus format negotiation at the panel level. > + */ > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > +}; > + > static const struct drm_display_mode tpk_f07a_0102_mode = { > .clock = 33260, > .hdisplay = 800, > @@ -3392,6 +3425,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "toshiba,lt089ac29000", > .data = &toshiba_lt089ac29000, > + }, { > + .compatible = "toshiba,lta089ac29000", Is this really different than "toshiba,lt089ac29000" ? Both have the exact same timing, the only difference is .bus_format, and according to https://www.avnet-integrated.eu/fileadmin/user_upload/Files/Displays/Colour_TFT/LT089AC29000.pdf the "toshiba,lt089ac29000" is an LVDS panel. > + .data = &toshiba_lta089ac29000, > }, { > .compatible = "tpk,f07a-0102", > .data = &tpk_f07a_0102, -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 19/21] drm/panel: simple: Add support for Toshiba LTA089AC29000 panel Date: Mon, 2 Dec 2019 19:17:24 +0200 Message-ID: <20191202171724.GS4929@pendragon.ideasonboard.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <20191023154512.9762-20-boris.brezillon@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7814C8826D for ; Mon, 2 Dec 2019 17:17:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20191023154512.9762-20-boris.brezillon@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim List-Id: dri-devel@lists.freedesktop.org SGkgQm9yaXMsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFdlZCwgT2N0IDIzLCAyMDE5 IGF0IDA1OjQ1OjEwUE0gKzAyMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90ZToKPiBBZGQgYSBuZXcg ZW50cnkgZm9yIHRoZSBUb3NoaWJhIExUQTA4OUFDMjkwMDAgcGFuZWwuCj4gCj4gU2lnbmVkLW9m Zi1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AY29sbGFib3JhLmNvbT4KPiAt LS0KPiBDaGFuZ2VzIGluIHYzOgo+ICogTm9uZQo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vcGFu ZWwvcGFuZWwtc2ltcGxlLmMgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDEg ZmlsZSBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5l bC1zaW1wbGUuYwo+IGluZGV4IDVkNDg3Njg2ZDI1Yy4uMjdjOTJiNDRiZDk1IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+IEBAIC0yOTM3LDYgKzI5MzcsMzkgQEAgc3Rh dGljIGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNjIHRvc2hpYmFfbHQwODlhYzI5MDAwID0gewo+ICAJ LmNvbm5lY3Rvcl90eXBlID0gRFJNX01PREVfQ09OTkVDVE9SX0xWRFMsCj4gIH07Cj4gIAo+ICtz dGF0aWMgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgdG9zaGliYV9sdGEwODlhYzI5MDAw X21vZGUgPSB7Cj4gKwkuY2xvY2sgPSA3OTUwMCwKPiArCS5oZGlzcGxheSA9IDEyODAsCj4gKwku aHN5bmNfc3RhcnQgPSAxMjgwICsgMTkyLAo+ICsJLmhzeW5jX2VuZCA9IDEyODAgKyAxOTIgKyAx MjgsCj4gKwkuaHRvdGFsID0gMTI4MCArIDE5MiArIDEyOCArIDY0LAo+ICsJLnZkaXNwbGF5ID0g NzY4LAo+ICsJLnZzeW5jX3N0YXJ0ID0gNzY4ICsgMjAsCj4gKwkudnN5bmNfZW5kID0gNzY4ICsg MjAgKyA3LAo+ICsJLnZ0b3RhbCA9IDc2OCArIDIwICsgNyArIDMsCj4gKwkudnJlZnJlc2ggPSA2 MCwKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcGFuZWxfZGVzYyB0b3NoaWJhX2x0 YTA4OWFjMjkwMDAgPSB7Cj4gKwkubW9kZXMgPSAmdG9zaGliYV9sdGEwODlhYzI5MDAwX21vZGUs Cj4gKwkubnVtX21vZGVzID0gMSwKPiArCS5zaXplID0gewo+ICsJCS53aWR0aCA9IDE5NCwKPiAr CQkuaGVpZ2h0ID0gMTE2LAo+ICsJfSwKPiArCS8qCj4gKwkgKiBGSVhNRToKPiArCSAqIFRoZSBw YW5lbCBzdXBwb3J0cyAyIGJ1cyBmb3JtYXRzOiBqZWlkYS0yNCBhbmQgamVpZGEtMTguIFRoZQo+ ICsJICogbW9kZSBpcyBzZWxlY3RlZCB0aHJvdWdoIHRoZSA4YjZiX1NFTCBwaW4uIElmIGFueW9u ZSBldmVyIG5lZWRzCj4gKwkgKiBzdXBwb3J0IGZvciBqZWlkYS0xOCB3ZSBzaG91bGQgcHJvYmFi bHkgcGFyc2UgdGhlICdkYXRhLW1hcHBpbmcnCj4gKwkgKiBwcm9wZXJ0eS4KPiArCSAqIEluIHRo ZSB1bmxpa2VseSBldmVudCB3aGVyZSA4YjZiX1NFTCBpcyBjb25uZWN0ZWQgdG8gYSBHUElPLCB3 ZSdkCj4gKwkgKiBuZWVkIGEgbmV3IGluZnJhIHRvIGFsbG93IGJ1cyBmb3JtYXQgbmVnb3RpYXRp b24gYXQgdGhlIHBhbmVsIGxldmVsLgo+ICsJICovCj4gKwkuYnVzX2Zvcm1hdCA9IE1FRElBX0JV U19GTVRfUkdCODg4XzFYN1g0X0pFSURBLAo+ICsJLmJ1c19mbGFncyA9IERSTV9CVVNfRkxBR19E RV9ISUdIIHwgRFJNX0JVU19GTEFHX1BJWERBVEFfRFJJVkVfUE9TRURHRSwKPiArfTsKPiArCj4g IHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSB0cGtfZjA3YV8wMTAyX21vZGUg PSB7Cj4gIAkuY2xvY2sgPSAzMzI2MCwKPiAgCS5oZGlzcGxheSA9IDgwMCwKPiBAQCAtMzM5Miw2 ICszNDI1LDkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgcGxhdGZvcm1fb2Zf bWF0Y2hbXSA9IHsKPiAgCX0sIHsKPiAgCQkuY29tcGF0aWJsZSA9ICJ0b3NoaWJhLGx0MDg5YWMy OTAwMCIsCj4gIAkJLmRhdGEgPSAmdG9zaGliYV9sdDA4OWFjMjkwMDAsCj4gKwl9LCB7Cj4gKwkJ LmNvbXBhdGlibGUgPSAidG9zaGliYSxsdGEwODlhYzI5MDAwIiwKCklzIHRoaXMgcmVhbGx5IGRp ZmZlcmVudCB0aGFuICJ0b3NoaWJhLGx0MDg5YWMyOTAwMCIgPyBCb3RoIGhhdmUgdGhlCmV4YWN0 IHNhbWUgdGltaW5nLCB0aGUgb25seSBkaWZmZXJlbmNlIGlzIC5idXNfZm9ybWF0LCBhbmQgYWNj b3JkaW5nIHRvCmh0dHBzOi8vd3d3LmF2bmV0LWludGVncmF0ZWQuZXUvZmlsZWFkbWluL3VzZXJf dXBsb2FkL0ZpbGVzL0Rpc3BsYXlzL0NvbG91cl9URlQvTFQwODlBQzI5MDAwLnBkZgp0aGUgInRv c2hpYmEsbHQwODlhYzI5MDAwIiBpcyBhbiBMVkRTIHBhbmVsLgoKPiArCQkuZGF0YSA9ICZ0b3No aWJhX2x0YTA4OWFjMjkwMDAsCj4gIAl9LCB7Cj4gIAkJLmNvbXBhdGlibGUgPSAidHBrLGYwN2Et MDEwMiIsCj4gIAkJLmRhdGEgPSAmdHBrX2YwN2FfMDEwMiwKCi0tIApSZWdhcmRzLAoKTGF1cmVu dCBQaW5jaGFydApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=