From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E007C432C0 for ; Mon, 2 Dec 2019 17:34:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 000F320848 for ; Mon, 2 Dec 2019 17:34:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kli7KIOW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 000F320848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BGuUh4++48jEa0xe5MKzMYPrJ9RZCfuTGd/e7WE8Vh8=; b=kli7KIOWXxfJ2u JfR+aQHknp51cLXWoprvKEvEaJmymjrPuUVmQegpD77L56yYNg616Sl9aG4VYAhn89O/jSER0lELP rSJSHSsjFBMXncxQpoudVR2V++x1f0h1WrSkHcMj8lLxG/APRRnGq8RQUJrsrOM3ZiNyD/qrdFuxF 6BDbQA0lwBF4CxTv8Rv1sWIZ0/uaDIbYP3G4B3/BGhLcBbTWGb7hpZ0DaNFh3zNWU+gmoKMvbNp5K KUIsWE3Hb04U/IBNFIlr0Iyxar7qLvbC1OkKu0PwTwCqMtpPdUFo9M/o7q8C0Wg60Fq34ImoNKl4B FQJGMM8h2J1aCQ4k9mjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibpaX-0004d2-Af; Mon, 02 Dec 2019 17:34:21 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibpaU-0004ca-50 for linux-nvme@lists.infradead.org; Mon, 02 Dec 2019 17:34:19 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id EF4B868BE1; Mon, 2 Dec 2019 18:34:14 +0100 (CET) Date: Mon, 2 Dec 2019 18:34:14 +0100 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCH] nvme: Namepace identification descriptor list is optional Message-ID: <20191202173414.GA8950@lst.de> References: <20191202155611.21549-1-kbusch@kernel.org> <20191202161545.GA7434@lst.de> <20191202162256.GA21631@redsun51.ssa.fujisawa.hgst.com> <10e6520d-bc8c-94ff-00c4-32a727131b89@intel.com> <20191202162905.GA7683@lst.de> <20191202164903.GA21650@redsun51.ssa.fujisawa.hgst.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191202164903.GA21650@redsun51.ssa.fujisawa.hgst.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_093418_344790_2C8E222E X-CRM114-Status: GOOD ( 11.05 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , linux-nvme@lists.infradead.org, Ingo Brunberg , "Nadolski, Edmund" , stable@vger.kernel.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Dec 03, 2019 at 01:49:03AM +0900, Keith Busch wrote: > Customer or OEM requirments are poorly written, like "Must report NVMe > version 1.3". Nobody bothers to mention that it must also be compliant > to that version, or even realize they never cared for those features in > the first place. > > Compliance testing like from UNH should have caught this before shipping > with such a device, but it's a cheap device, so maybe they skip that step. > > > I wonder if we actually do users a favour by allowing that.. > > I think it's too late now. We did successfully use such namespaces > before 5.4, even if they're fundamentally broken. > > Johannes also commented *not* to consider these errors when this > identification was originally implemented, so either he knew vendors > screwed this up, or had the forethought to know they would. Yes. I guess your patch is the best thing for now: Reviewed-by: Christoph Hellwig But I think we might need a new kernel tain flag or something like it for devices that are so obviously broken in their identifiers. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42767C432C0 for ; Mon, 2 Dec 2019 17:34:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0305820865 for ; Mon, 2 Dec 2019 17:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727709AbfLBReR (ORCPT ); Mon, 2 Dec 2019 12:34:17 -0500 Received: from verein.lst.de ([213.95.11.211]:39500 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727655AbfLBReR (ORCPT ); Mon, 2 Dec 2019 12:34:17 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id EF4B868BE1; Mon, 2 Dec 2019 18:34:14 +0100 (CET) Date: Mon, 2 Dec 2019 18:34:14 +0100 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , "Nadolski, Edmund" , stable@vger.kernel.org, Ingo Brunberg , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: Re: [PATCH] nvme: Namepace identification descriptor list is optional Message-ID: <20191202173414.GA8950@lst.de> References: <20191202155611.21549-1-kbusch@kernel.org> <20191202161545.GA7434@lst.de> <20191202162256.GA21631@redsun51.ssa.fujisawa.hgst.com> <10e6520d-bc8c-94ff-00c4-32a727131b89@intel.com> <20191202162905.GA7683@lst.de> <20191202164903.GA21650@redsun51.ssa.fujisawa.hgst.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191202164903.GA21650@redsun51.ssa.fujisawa.hgst.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Dec 03, 2019 at 01:49:03AM +0900, Keith Busch wrote: > Customer or OEM requirments are poorly written, like "Must report NVMe > version 1.3". Nobody bothers to mention that it must also be compliant > to that version, or even realize they never cared for those features in > the first place. > > Compliance testing like from UNH should have caught this before shipping > with such a device, but it's a cheap device, so maybe they skip that step. > > > I wonder if we actually do users a favour by allowing that.. > > I think it's too late now. We did successfully use such namespaces > before 5.4, even if they're fundamentally broken. > > Johannes also commented *not* to consider these errors when this > identification was originally implemented, so either he knew vendors > screwed this up, or had the forethought to know they would. Yes. I guess your patch is the best thing for now: Reviewed-by: Christoph Hellwig But I think we might need a new kernel tain flag or something like it for devices that are so obviously broken in their identifiers.