From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D66D8C432C0 for ; Tue, 3 Dec 2019 06:39:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC1D0206DF for ; Tue, 3 Dec 2019 06:39:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Eeb15EdS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="D14DfDQG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC1D0206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a/MdXEsPQ0bpUoZfLjRSTjAAOQ7H9kNKVYWSrwM+Ie0=; b=Eeb15EdSJc7WN4 uPP0cegPZ8gSn2H/jbV05ivbVE13ZvBMLWsGxUbdpk8WIreaQH0TKr1YLAWFd8AaqbtsO6uDdOvdF C70mfZF4I/9rQHvyyCvGqgbhqzPYksqx6J8VGEM0szkNqPeL27hAvQnoj87m0dVchHgYaBtYbMwkd 0nwf9zUFDIhre8CSSiHEJTPkMIExOOpVIxAsHkdmFlDr6wEwXHgwLJEs8hVqNV6GGqLkp6CNgTEX/ qVHA/p/zDeOp0XbD6U234sxjWYjpCt5o0pxdbDTYqiK6yLze+EWl5n8Xpnx570NSpmVU0IFp6yP3b l5D64IXYcDoqmMuphp/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic1qm-0007up-4e; Tue, 03 Dec 2019 06:39:56 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic1qe-0007nL-JK; Tue, 03 Dec 2019 06:39:50 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 70227309; Tue, 3 Dec 2019 07:39:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575355186; bh=NKJAGVwnbEA5vcxRJnNw/eHXqWVE7J8TQMaQ6WQ1rME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D14DfDQGqmcPI/cWzbaSwFmIu2oGRWeQ94ouc59CDImFZ8t3SX6+BbiXsn2fRsOZk Tnv6M49uf5jSzTHOa93zxLqOpHWEUA/ltoic1as76ib31vB5+Oo8hU9R8nUV2Cj5eu z/3+mXvqwo0HuNNUiRzpAUwj6s6qiSBMTuin2TnY= Date: Tue, 3 Dec 2019 08:39:40 +0200 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 03/26] drm/panel: simple: use drm_panel backlight support Message-ID: <20191203063940.GC4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-4-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191202193230.21310-4-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_223948_927685_28446EEC X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:07PM +0100, Sam Ravnborg wrote: > Use drm_panel infrastructure for backlight. > Replace direct calls with drm_panel_*() calls > to utilize the drm_panel support. > > Signed-off-by: Sam Ravnborg > cc: Laurent Pinchart > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-simple.c | 50 ++++++---------------------- > 1 file changed, 11 insertions(+), 39 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 72f69709f349..a5df6d6dd455 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -21,7 +21,6 @@ > * DEALINGS IN THE SOFTWARE. > */ > > -#include > #include > #include > #include > @@ -105,7 +104,6 @@ struct panel_simple { > > const struct panel_desc *desc; > > - struct backlight_device *backlight; > struct regulator *supply; > struct i2c_adapter *ddc; > > @@ -236,12 +234,6 @@ static int panel_simple_disable(struct drm_panel *panel) > if (!p->enabled) > return 0; > > - if (p->backlight) { > - p->backlight->props.power = FB_BLANK_POWERDOWN; > - p->backlight->props.state |= BL_CORE_FBBLANK; > - backlight_update_status(p->backlight); > - } > - > if (p->desc->delay.disable) > msleep(p->desc->delay.disable); > > @@ -307,12 +299,6 @@ static int panel_simple_enable(struct drm_panel *panel) > if (p->desc->delay.enable) > msleep(p->desc->delay.enable); > > - if (p->backlight) { > - p->backlight->props.state &= ~BL_CORE_FBBLANK; > - p->backlight->props.power = FB_BLANK_UNBLANK; > - backlight_update_status(p->backlight); > - } > - > p->enabled = true; > > return 0; > @@ -414,9 +400,9 @@ static void panel_simple_parse_panel_timing_node(struct device *dev, > > static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > { > - struct device_node *backlight, *ddc; > struct panel_simple *panel; > struct display_timing dt; > + struct device_node *ddc; > int err; > > panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL); > @@ -442,24 +428,13 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > return err; > } > > - backlight = of_parse_phandle(dev->of_node, "backlight", 0); > - if (backlight) { > - panel->backlight = of_find_backlight_by_node(backlight); > - of_node_put(backlight); > - > - if (!panel->backlight) > - return -EPROBE_DEFER; > - } > - > ddc = of_parse_phandle(dev->of_node, "ddc-i2c-bus", 0); > if (ddc) { > panel->ddc = of_find_i2c_adapter_by_node(ddc); > of_node_put(ddc); > > - if (!panel->ddc) { > - err = -EPROBE_DEFER; > - goto free_backlight; > - } > + if (!panel->ddc) > + return -EPROBE_DEFER; > } > > if (!of_get_display_timing(dev->of_node, "panel-timing", &dt)) > @@ -468,6 +443,10 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > drm_panel_init(&panel->base, dev, &panel_simple_funcs, > desc->connector_type); > > + err = drm_panel_of_backlight(&panel->base); > + if (err) > + goto free_ddc; > + > err = drm_panel_add(&panel->base); > if (err < 0) > goto free_ddc; > @@ -479,9 +458,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > free_ddc: > if (panel->ddc) > put_device(&panel->ddc->dev); > -free_backlight: > - if (panel->backlight) > - put_device(&panel->backlight->dev); > > return err; > } > @@ -491,16 +467,12 @@ static int panel_simple_remove(struct device *dev) > struct panel_simple *panel = dev_get_drvdata(dev); > > drm_panel_remove(&panel->base); > - > - panel_simple_disable(&panel->base); > - panel_simple_unprepare(&panel->base); > + drm_panel_disable(&panel->base); > + drm_panel_unprepare(&panel->base); > > if (panel->ddc) > put_device(&panel->ddc->dev); > > - if (panel->backlight) > - put_device(&panel->backlight->dev); > - > return 0; > } > > @@ -508,8 +480,8 @@ static void panel_simple_shutdown(struct device *dev) > { > struct panel_simple *panel = dev_get_drvdata(dev); > > - panel_simple_disable(&panel->base); > - panel_simple_unprepare(&panel->base); > + drm_panel_disable(&panel->base); > + drm_panel_unprepare(&panel->base); Without your panel double-disable protection series, you risk disabling the backlight twice. I think backlight_disable() will work fine, but you may want to double-check. With this checked (and possibly addressed if needed), Reviewed-by: Laurent Pinchart > } > > static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = { -- Regards, Laurent Pinchart _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v1 03/26] drm/panel: simple: use drm_panel backlight support Date: Tue, 3 Dec 2019 08:39:40 +0200 Message-ID: <20191203063940.GC4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-4-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191202193230.21310-4-sam@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sam Ravnborg Cc: Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Thierry Reding , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon List-Id: linux-rockchip.vger.kernel.org SGkgU2FtLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBNb24sIERlYyAwMiwgMjAxOSBh dCAwODozMjowN1BNICswMTAwLCBTYW0gUmF2bmJvcmcgd3JvdGU6Cj4gVXNlIGRybV9wYW5lbCBp bmZyYXN0cnVjdHVyZSBmb3IgYmFja2xpZ2h0Lgo+IFJlcGxhY2UgZGlyZWN0IGNhbGxzIHdpdGgg ZHJtX3BhbmVsXyooKSBjYWxscwo+IHRvIHV0aWxpemUgdGhlIGRybV9wYW5lbCBzdXBwb3J0Lgo+ IAo+IFNpZ25lZC1vZmYtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiBjYzog TGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IENj OiBUaGllcnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29tPgo+IENjOiBTYW0gUmF2 bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9w YW5lbC1zaW1wbGUuYyB8IDUwICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDM5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9k cm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiBpbmRleCA3MmY2OTcwOWYzNDkuLmE1ZGY2ZDZkZDQ1 NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiBAQCAtMjEsNyArMjEs NiBAQAo+ICAgKiBERUFMSU5HUyBJTiBUSEUgU09GVFdBUkUuCj4gICAqLwo+ICAKPiAtI2luY2x1 ZGUgPGxpbnV4L2JhY2tsaWdodC5oPgo+ICAjaW5jbHVkZSA8bGludXgvZGVsYXkuaD4KPiAgI2lu Y2x1ZGUgPGxpbnV4L2dwaW8vY29uc3VtZXIuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5o Pgo+IEBAIC0xMDUsNyArMTA0LDYgQEAgc3RydWN0IHBhbmVsX3NpbXBsZSB7Cj4gIAo+ICAJY29u c3Qgc3RydWN0IHBhbmVsX2Rlc2MgKmRlc2M7Cj4gIAo+IC0Jc3RydWN0IGJhY2tsaWdodF9kZXZp Y2UgKmJhY2tsaWdodDsKPiAgCXN0cnVjdCByZWd1bGF0b3IgKnN1cHBseTsKPiAgCXN0cnVjdCBp MmNfYWRhcHRlciAqZGRjOwo+ICAKPiBAQCAtMjM2LDEyICsyMzQsNiBAQCBzdGF0aWMgaW50IHBh bmVsX3NpbXBsZV9kaXNhYmxlKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKQo+ICAJaWYgKCFwLT5l bmFibGVkKQo+ICAJCXJldHVybiAwOwo+ICAKPiAtCWlmIChwLT5iYWNrbGlnaHQpIHsKPiAtCQlw LT5iYWNrbGlnaHQtPnByb3BzLnBvd2VyID0gRkJfQkxBTktfUE9XRVJET1dOOwo+IC0JCXAtPmJh Y2tsaWdodC0+cHJvcHMuc3RhdGUgfD0gQkxfQ09SRV9GQkJMQU5LOwo+IC0JCWJhY2tsaWdodF91 cGRhdGVfc3RhdHVzKHAtPmJhY2tsaWdodCk7Cj4gLQl9Cj4gLQo+ICAJaWYgKHAtPmRlc2MtPmRl bGF5LmRpc2FibGUpCj4gIAkJbXNsZWVwKHAtPmRlc2MtPmRlbGF5LmRpc2FibGUpOwo+ICAKPiBA QCAtMzA3LDEyICsyOTksNiBAQCBzdGF0aWMgaW50IHBhbmVsX3NpbXBsZV9lbmFibGUoc3RydWN0 IGRybV9wYW5lbCAqcGFuZWwpCj4gIAlpZiAocC0+ZGVzYy0+ZGVsYXkuZW5hYmxlKQo+ICAJCW1z bGVlcChwLT5kZXNjLT5kZWxheS5lbmFibGUpOwo+ICAKPiAtCWlmIChwLT5iYWNrbGlnaHQpIHsK PiAtCQlwLT5iYWNrbGlnaHQtPnByb3BzLnN0YXRlICY9IH5CTF9DT1JFX0ZCQkxBTks7Cj4gLQkJ cC0+YmFja2xpZ2h0LT5wcm9wcy5wb3dlciA9IEZCX0JMQU5LX1VOQkxBTks7Cj4gLQkJYmFja2xp Z2h0X3VwZGF0ZV9zdGF0dXMocC0+YmFja2xpZ2h0KTsKPiAtCX0KPiAtCj4gIAlwLT5lbmFibGVk ID0gdHJ1ZTsKPiAgCj4gIAlyZXR1cm4gMDsKPiBAQCAtNDE0LDkgKzQwMCw5IEBAIHN0YXRpYyB2 b2lkIHBhbmVsX3NpbXBsZV9wYXJzZV9wYW5lbF90aW1pbmdfbm9kZShzdHJ1Y3QgZGV2aWNlICpk ZXYsCj4gIAo+ICBzdGF0aWMgaW50IHBhbmVsX3NpbXBsZV9wcm9iZShzdHJ1Y3QgZGV2aWNlICpk ZXYsIGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNjICpkZXNjKQo+ICB7Cj4gLQlzdHJ1Y3QgZGV2aWNl X25vZGUgKmJhY2tsaWdodCwgKmRkYzsKPiAgCXN0cnVjdCBwYW5lbF9zaW1wbGUgKnBhbmVsOwo+ ICAJc3RydWN0IGRpc3BsYXlfdGltaW5nIGR0Owo+ICsJc3RydWN0IGRldmljZV9ub2RlICpkZGM7 Cj4gIAlpbnQgZXJyOwo+ICAKPiAgCXBhbmVsID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9mKCpw YW5lbCksIEdGUF9LRVJORUwpOwo+IEBAIC00NDIsMjQgKzQyOCwxMyBAQCBzdGF0aWMgaW50IHBh bmVsX3NpbXBsZV9wcm9iZShzdHJ1Y3QgZGV2aWNlICpkZXYsIGNvbnN0IHN0cnVjdCBwYW5lbF9k ZXNjICpkZXNjKQo+ICAJCXJldHVybiBlcnI7Cj4gIAl9Cj4gIAo+IC0JYmFja2xpZ2h0ID0gb2Zf cGFyc2VfcGhhbmRsZShkZXYtPm9mX25vZGUsICJiYWNrbGlnaHQiLCAwKTsKPiAtCWlmIChiYWNr bGlnaHQpIHsKPiAtCQlwYW5lbC0+YmFja2xpZ2h0ID0gb2ZfZmluZF9iYWNrbGlnaHRfYnlfbm9k ZShiYWNrbGlnaHQpOwo+IC0JCW9mX25vZGVfcHV0KGJhY2tsaWdodCk7Cj4gLQo+IC0JCWlmICgh cGFuZWwtPmJhY2tsaWdodCkKPiAtCQkJcmV0dXJuIC1FUFJPQkVfREVGRVI7Cj4gLQl9Cj4gLQo+ ICAJZGRjID0gb2ZfcGFyc2VfcGhhbmRsZShkZXYtPm9mX25vZGUsICJkZGMtaTJjLWJ1cyIsIDAp Owo+ICAJaWYgKGRkYykgewo+ICAJCXBhbmVsLT5kZGMgPSBvZl9maW5kX2kyY19hZGFwdGVyX2J5 X25vZGUoZGRjKTsKPiAgCQlvZl9ub2RlX3B1dChkZGMpOwo+ICAKPiAtCQlpZiAoIXBhbmVsLT5k ZGMpIHsKPiAtCQkJZXJyID0gLUVQUk9CRV9ERUZFUjsKPiAtCQkJZ290byBmcmVlX2JhY2tsaWdo dDsKPiAtCQl9Cj4gKwkJaWYgKCFwYW5lbC0+ZGRjKQo+ICsJCQlyZXR1cm4gLUVQUk9CRV9ERUZF UjsKPiAgCX0KPiAgCj4gIAlpZiAoIW9mX2dldF9kaXNwbGF5X3RpbWluZyhkZXYtPm9mX25vZGUs ICJwYW5lbC10aW1pbmciLCAmZHQpKQo+IEBAIC00NjgsNiArNDQzLDEwIEBAIHN0YXRpYyBpbnQg cGFuZWxfc2ltcGxlX3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwgY29uc3Qgc3RydWN0IHBhbmVs X2Rlc2MgKmRlc2MpCj4gIAlkcm1fcGFuZWxfaW5pdCgmcGFuZWwtPmJhc2UsIGRldiwgJnBhbmVs X3NpbXBsZV9mdW5jcywKPiAgCQkgICAgICAgZGVzYy0+Y29ubmVjdG9yX3R5cGUpOwo+ICAKPiAr CWVyciA9IGRybV9wYW5lbF9vZl9iYWNrbGlnaHQoJnBhbmVsLT5iYXNlKTsKPiArCWlmIChlcnIp Cj4gKwkJZ290byBmcmVlX2RkYzsKPiArCj4gIAllcnIgPSBkcm1fcGFuZWxfYWRkKCZwYW5lbC0+ YmFzZSk7Cj4gIAlpZiAoZXJyIDwgMCkKPiAgCQlnb3RvIGZyZWVfZGRjOwo+IEBAIC00NzksOSAr NDU4LDYgQEAgc3RhdGljIGludCBwYW5lbF9zaW1wbGVfcHJvYmUoc3RydWN0IGRldmljZSAqZGV2 LCBjb25zdCBzdHJ1Y3QgcGFuZWxfZGVzYyAqZGVzYykKPiAgZnJlZV9kZGM6Cj4gIAlpZiAocGFu ZWwtPmRkYykKPiAgCQlwdXRfZGV2aWNlKCZwYW5lbC0+ZGRjLT5kZXYpOwo+IC1mcmVlX2JhY2ts aWdodDoKPiAtCWlmIChwYW5lbC0+YmFja2xpZ2h0KQo+IC0JCXB1dF9kZXZpY2UoJnBhbmVsLT5i YWNrbGlnaHQtPmRldik7Cj4gIAo+ICAJcmV0dXJuIGVycjsKPiAgfQo+IEBAIC00OTEsMTYgKzQ2 NywxMiBAQCBzdGF0aWMgaW50IHBhbmVsX3NpbXBsZV9yZW1vdmUoc3RydWN0IGRldmljZSAqZGV2 KQo+ICAJc3RydWN0IHBhbmVsX3NpbXBsZSAqcGFuZWwgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsK PiAgCj4gIAlkcm1fcGFuZWxfcmVtb3ZlKCZwYW5lbC0+YmFzZSk7Cj4gLQo+IC0JcGFuZWxfc2lt cGxlX2Rpc2FibGUoJnBhbmVsLT5iYXNlKTsKPiAtCXBhbmVsX3NpbXBsZV91bnByZXBhcmUoJnBh bmVsLT5iYXNlKTsKPiArCWRybV9wYW5lbF9kaXNhYmxlKCZwYW5lbC0+YmFzZSk7Cj4gKwlkcm1f cGFuZWxfdW5wcmVwYXJlKCZwYW5lbC0+YmFzZSk7Cj4gIAo+ICAJaWYgKHBhbmVsLT5kZGMpCj4g IAkJcHV0X2RldmljZSgmcGFuZWwtPmRkYy0+ZGV2KTsKPiAgCj4gLQlpZiAocGFuZWwtPmJhY2ts aWdodCkKPiAtCQlwdXRfZGV2aWNlKCZwYW5lbC0+YmFja2xpZ2h0LT5kZXYpOwo+IC0KPiAgCXJl dHVybiAwOwo+ICB9Cj4gIAo+IEBAIC01MDgsOCArNDgwLDggQEAgc3RhdGljIHZvaWQgcGFuZWxf c2ltcGxlX3NodXRkb3duKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgewo+ICAJc3RydWN0IHBhbmVs X3NpbXBsZSAqcGFuZWwgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiAgCj4gLQlwYW5lbF9zaW1w bGVfZGlzYWJsZSgmcGFuZWwtPmJhc2UpOwo+IC0JcGFuZWxfc2ltcGxlX3VucHJlcGFyZSgmcGFu ZWwtPmJhc2UpOwo+ICsJZHJtX3BhbmVsX2Rpc2FibGUoJnBhbmVsLT5iYXNlKTsKPiArCWRybV9w YW5lbF91bnByZXBhcmUoJnBhbmVsLT5iYXNlKTsKCldpdGhvdXQgeW91ciBwYW5lbCBkb3VibGUt ZGlzYWJsZSBwcm90ZWN0aW9uIHNlcmllcywgeW91IHJpc2sgZGlzYWJsaW5nCnRoZSBiYWNrbGln aHQgdHdpY2UuIEkgdGhpbmsgYmFja2xpZ2h0X2Rpc2FibGUoKSB3aWxsIHdvcmsgZmluZSwgYnV0 IHlvdQptYXkgd2FudCB0byBkb3VibGUtY2hlY2suCgpXaXRoIHRoaXMgY2hlY2tlZCAoYW5kIHBv c3NpYmx5IGFkZHJlc3NlZCBpZiBuZWVkZWQpLAoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hh cnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gIH0KPiAgCj4gIHN0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSBhbXBpcmVfYW1fNDgwMjcyaDN0bXF3X3Qw MWhfbW9kZSA9IHsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8092C43215 for ; Tue, 3 Dec 2019 06:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EA8A2073F for ; Tue, 3 Dec 2019 06:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="D14DfDQG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727136AbfLCGjt (ORCPT ); Tue, 3 Dec 2019 01:39:49 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:56442 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbfLCGjt (ORCPT ); Tue, 3 Dec 2019 01:39:49 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 70227309; Tue, 3 Dec 2019 07:39:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575355186; bh=NKJAGVwnbEA5vcxRJnNw/eHXqWVE7J8TQMaQ6WQ1rME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D14DfDQGqmcPI/cWzbaSwFmIu2oGRWeQ94ouc59CDImFZ8t3SX6+BbiXsn2fRsOZk Tnv6M49uf5jSzTHOa93zxLqOpHWEUA/ltoic1as76ib31vB5+Oo8hU9R8nUV2Cj5eu z/3+mXvqwo0HuNNUiRzpAUwj6s6qiSBMTuin2TnY= Date: Tue, 3 Dec 2019 08:39:40 +0200 From: Laurent Pinchart To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Thierry Reding , Abhinav Kumar , Andrzej Hajda , Benjamin Gaignard , Boris Brezillon , Daniel Vetter , David Airlie , Jagan Teki , Jitao Shi , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Neil Armstrong , NXP Linux Team , Pengutronix Kernel Team , Purism Kernel Team , Sean Paul , Stefan Agner , Tomi Valkeinen Subject: Re: [PATCH v1 03/26] drm/panel: simple: use drm_panel backlight support Message-ID: <20191203063940.GC4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-4-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191202193230.21310-4-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:07PM +0100, Sam Ravnborg wrote: > Use drm_panel infrastructure for backlight. > Replace direct calls with drm_panel_*() calls > to utilize the drm_panel support. > > Signed-off-by: Sam Ravnborg > cc: Laurent Pinchart > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-simple.c | 50 ++++++---------------------- > 1 file changed, 11 insertions(+), 39 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 72f69709f349..a5df6d6dd455 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -21,7 +21,6 @@ > * DEALINGS IN THE SOFTWARE. > */ > > -#include > #include > #include > #include > @@ -105,7 +104,6 @@ struct panel_simple { > > const struct panel_desc *desc; > > - struct backlight_device *backlight; > struct regulator *supply; > struct i2c_adapter *ddc; > > @@ -236,12 +234,6 @@ static int panel_simple_disable(struct drm_panel *panel) > if (!p->enabled) > return 0; > > - if (p->backlight) { > - p->backlight->props.power = FB_BLANK_POWERDOWN; > - p->backlight->props.state |= BL_CORE_FBBLANK; > - backlight_update_status(p->backlight); > - } > - > if (p->desc->delay.disable) > msleep(p->desc->delay.disable); > > @@ -307,12 +299,6 @@ static int panel_simple_enable(struct drm_panel *panel) > if (p->desc->delay.enable) > msleep(p->desc->delay.enable); > > - if (p->backlight) { > - p->backlight->props.state &= ~BL_CORE_FBBLANK; > - p->backlight->props.power = FB_BLANK_UNBLANK; > - backlight_update_status(p->backlight); > - } > - > p->enabled = true; > > return 0; > @@ -414,9 +400,9 @@ static void panel_simple_parse_panel_timing_node(struct device *dev, > > static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > { > - struct device_node *backlight, *ddc; > struct panel_simple *panel; > struct display_timing dt; > + struct device_node *ddc; > int err; > > panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL); > @@ -442,24 +428,13 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > return err; > } > > - backlight = of_parse_phandle(dev->of_node, "backlight", 0); > - if (backlight) { > - panel->backlight = of_find_backlight_by_node(backlight); > - of_node_put(backlight); > - > - if (!panel->backlight) > - return -EPROBE_DEFER; > - } > - > ddc = of_parse_phandle(dev->of_node, "ddc-i2c-bus", 0); > if (ddc) { > panel->ddc = of_find_i2c_adapter_by_node(ddc); > of_node_put(ddc); > > - if (!panel->ddc) { > - err = -EPROBE_DEFER; > - goto free_backlight; > - } > + if (!panel->ddc) > + return -EPROBE_DEFER; > } > > if (!of_get_display_timing(dev->of_node, "panel-timing", &dt)) > @@ -468,6 +443,10 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > drm_panel_init(&panel->base, dev, &panel_simple_funcs, > desc->connector_type); > > + err = drm_panel_of_backlight(&panel->base); > + if (err) > + goto free_ddc; > + > err = drm_panel_add(&panel->base); > if (err < 0) > goto free_ddc; > @@ -479,9 +458,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > free_ddc: > if (panel->ddc) > put_device(&panel->ddc->dev); > -free_backlight: > - if (panel->backlight) > - put_device(&panel->backlight->dev); > > return err; > } > @@ -491,16 +467,12 @@ static int panel_simple_remove(struct device *dev) > struct panel_simple *panel = dev_get_drvdata(dev); > > drm_panel_remove(&panel->base); > - > - panel_simple_disable(&panel->base); > - panel_simple_unprepare(&panel->base); > + drm_panel_disable(&panel->base); > + drm_panel_unprepare(&panel->base); > > if (panel->ddc) > put_device(&panel->ddc->dev); > > - if (panel->backlight) > - put_device(&panel->backlight->dev); > - > return 0; > } > > @@ -508,8 +480,8 @@ static void panel_simple_shutdown(struct device *dev) > { > struct panel_simple *panel = dev_get_drvdata(dev); > > - panel_simple_disable(&panel->base); > - panel_simple_unprepare(&panel->base); > + drm_panel_disable(&panel->base); > + drm_panel_unprepare(&panel->base); Without your panel double-disable protection series, you risk disabling the backlight twice. I think backlight_disable() will work fine, but you may want to double-check. With this checked (and possibly addressed if needed), Reviewed-by: Laurent Pinchart > } > > static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B6CEC432C3 for ; Tue, 3 Dec 2019 06:39:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22F3B20684 for ; Tue, 3 Dec 2019 06:39:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n9ixoafo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="D14DfDQG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22F3B20684 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ORuBCvM0+lRBlBUnLCFXJQVFExXearRXbCcBDEAgsu4=; b=n9ixoafoJBEai8 37O1BpVXdefoCcbC0l25bBZRpDrOg2GgogzqPBMTZsdfAOenIJa2N2Tb+6RFY/35zqDkve7Parajf xMe/5Wmh22POmReoEUFV7clw69bNdm22Jbri1jkSVPhqU6v1YOkRId1Ywt/ozUSJ6dIdn8XqMu3Ht dSdvnZMkqjHDu48X4u0kmKpDu/MrIXVumQ+NSuL++xZ3DNI/nWzeNDf3HhDPUNAl3gfFsEf35gKQh ofmj4IuCa810qtqcntUCgup1uyN88qd6wrua0h+bzeCVIwhlE2U44I70xf4R/1ZlYduH45fW26gjm /PRS6BbyaimPjkLA3oSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic1qh-0007o5-LV; Tue, 03 Dec 2019 06:39:51 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic1qe-0007nL-JK; Tue, 03 Dec 2019 06:39:50 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 70227309; Tue, 3 Dec 2019 07:39:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575355186; bh=NKJAGVwnbEA5vcxRJnNw/eHXqWVE7J8TQMaQ6WQ1rME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D14DfDQGqmcPI/cWzbaSwFmIu2oGRWeQ94ouc59CDImFZ8t3SX6+BbiXsn2fRsOZk Tnv6M49uf5jSzTHOa93zxLqOpHWEUA/ltoic1as76ib31vB5+Oo8hU9R8nUV2Cj5eu z/3+mXvqwo0HuNNUiRzpAUwj6s6qiSBMTuin2TnY= Date: Tue, 3 Dec 2019 08:39:40 +0200 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 03/26] drm/panel: simple: use drm_panel backlight support Message-ID: <20191203063940.GC4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-4-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191202193230.21310-4-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_223948_927685_28446EEC X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:07PM +0100, Sam Ravnborg wrote: > Use drm_panel infrastructure for backlight. > Replace direct calls with drm_panel_*() calls > to utilize the drm_panel support. > > Signed-off-by: Sam Ravnborg > cc: Laurent Pinchart > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-simple.c | 50 ++++++---------------------- > 1 file changed, 11 insertions(+), 39 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 72f69709f349..a5df6d6dd455 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -21,7 +21,6 @@ > * DEALINGS IN THE SOFTWARE. > */ > > -#include > #include > #include > #include > @@ -105,7 +104,6 @@ struct panel_simple { > > const struct panel_desc *desc; > > - struct backlight_device *backlight; > struct regulator *supply; > struct i2c_adapter *ddc; > > @@ -236,12 +234,6 @@ static int panel_simple_disable(struct drm_panel *panel) > if (!p->enabled) > return 0; > > - if (p->backlight) { > - p->backlight->props.power = FB_BLANK_POWERDOWN; > - p->backlight->props.state |= BL_CORE_FBBLANK; > - backlight_update_status(p->backlight); > - } > - > if (p->desc->delay.disable) > msleep(p->desc->delay.disable); > > @@ -307,12 +299,6 @@ static int panel_simple_enable(struct drm_panel *panel) > if (p->desc->delay.enable) > msleep(p->desc->delay.enable); > > - if (p->backlight) { > - p->backlight->props.state &= ~BL_CORE_FBBLANK; > - p->backlight->props.power = FB_BLANK_UNBLANK; > - backlight_update_status(p->backlight); > - } > - > p->enabled = true; > > return 0; > @@ -414,9 +400,9 @@ static void panel_simple_parse_panel_timing_node(struct device *dev, > > static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > { > - struct device_node *backlight, *ddc; > struct panel_simple *panel; > struct display_timing dt; > + struct device_node *ddc; > int err; > > panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL); > @@ -442,24 +428,13 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > return err; > } > > - backlight = of_parse_phandle(dev->of_node, "backlight", 0); > - if (backlight) { > - panel->backlight = of_find_backlight_by_node(backlight); > - of_node_put(backlight); > - > - if (!panel->backlight) > - return -EPROBE_DEFER; > - } > - > ddc = of_parse_phandle(dev->of_node, "ddc-i2c-bus", 0); > if (ddc) { > panel->ddc = of_find_i2c_adapter_by_node(ddc); > of_node_put(ddc); > > - if (!panel->ddc) { > - err = -EPROBE_DEFER; > - goto free_backlight; > - } > + if (!panel->ddc) > + return -EPROBE_DEFER; > } > > if (!of_get_display_timing(dev->of_node, "panel-timing", &dt)) > @@ -468,6 +443,10 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > drm_panel_init(&panel->base, dev, &panel_simple_funcs, > desc->connector_type); > > + err = drm_panel_of_backlight(&panel->base); > + if (err) > + goto free_ddc; > + > err = drm_panel_add(&panel->base); > if (err < 0) > goto free_ddc; > @@ -479,9 +458,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > free_ddc: > if (panel->ddc) > put_device(&panel->ddc->dev); > -free_backlight: > - if (panel->backlight) > - put_device(&panel->backlight->dev); > > return err; > } > @@ -491,16 +467,12 @@ static int panel_simple_remove(struct device *dev) > struct panel_simple *panel = dev_get_drvdata(dev); > > drm_panel_remove(&panel->base); > - > - panel_simple_disable(&panel->base); > - panel_simple_unprepare(&panel->base); > + drm_panel_disable(&panel->base); > + drm_panel_unprepare(&panel->base); > > if (panel->ddc) > put_device(&panel->ddc->dev); > > - if (panel->backlight) > - put_device(&panel->backlight->dev); > - > return 0; > } > > @@ -508,8 +480,8 @@ static void panel_simple_shutdown(struct device *dev) > { > struct panel_simple *panel = dev_get_drvdata(dev); > > - panel_simple_disable(&panel->base); > - panel_simple_unprepare(&panel->base); > + drm_panel_disable(&panel->base); > + drm_panel_unprepare(&panel->base); Without your panel double-disable protection series, you risk disabling the backlight twice. I think backlight_disable() will work fine, but you may want to double-check. With this checked (and possibly addressed if needed), Reviewed-by: Laurent Pinchart > } > > static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = { -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel