All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brendan Higgins <brendanhiggins@google.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: shuah@kernel.org, corbet@lwn.net,
	linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	SeongJae Park <sjpark@amazon.de>
Subject: Re: [PATCH 0/6] Fix nits in the kunit
Date: Mon, 2 Dec 2019 23:00:25 -0800	[thread overview]
Message-ID: <20191203070025.GA4206@google.com> (raw)
In-Reply-To: <1575242724-4937-1-git-send-email-sj38.park@gmail.com>

On Mon, Dec 02, 2019 at 08:25:18AM +0900, SeongJae Park wrote:
> From: SeongJae Park <sjpark@amazon.de>
> 
> This patchset contains trivial fixes for the kunit documentations and the
> wrapper python scripts.
> 
> SeongJae Park (6):
>   docs/kunit/start: Use in-tree 'kunit_defconfig'
>   docs/kunit/start: Skip wrapper run command
>   kunit: Remove duplicated defconfig creation
>   kunit: Create default config in 'build_dir'
>   kunit: Place 'test.log' under the 'build_dir'
>   kunit: Rename 'kunitconfig' to '.kunitconfig'
> 
>  Documentation/dev-tools/kunit/start.rst | 19 +++++--------------
>  tools/testing/kunit/kunit.py            | 10 ++++++----
>  tools/testing/kunit/kunit_kernel.py     |  6 +++---
>  3 files changed, 14 insertions(+), 21 deletions(-)

I applied your patchset to torvalds/master, ran the command:

tools/testing/kunit/kunit.py run --timeout=60 --jobs=8 --defconfig --build_dir=.kunit

and got the error:

Traceback (most recent call last):
  File "tools/testing/kunit/kunit.py", line 140, in <module>
    main(sys.argv[1:])
  File "tools/testing/kunit/kunit.py", line 123, in main
    create_default_kunitconfig()
  File "tools/testing/kunit/kunit.py", line 36, in create_default_kunitconfig
    kunit_kernel.KUNITCONFIG_PATH)
  File "/usr/lib/python3.7/shutil.py", line 121, in copyfile
    with open(dst, 'wb') as fdst:
FileNotFoundError: [Errno 2] No such file or directory: '.kunit/.kunitconfig'

It seems that it expects the build_dir to already exist; however, I
don't think this is clear from the error message. Would you mind
addressing that here?

Cheers!

  parent reply	other threads:[~2019-12-03  7:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-01 23:25 [PATCH 0/6] Fix nits in the kunit SeongJae Park
2019-12-01 23:25 ` [PATCH 1/6] docs/kunit/start: Use in-tree 'kunit_defconfig' SeongJae Park
2019-12-02 17:13   ` Brendan Higgins
2019-12-01 23:25 ` [PATCH 2/6] docs/kunit/start: Skip wrapper run command SeongJae Park
2019-12-02 17:25   ` Brendan Higgins
2019-12-02 20:59     ` SeongJae Park
2019-12-03  8:27       ` SeongJae Park
2019-12-02 21:03     ` David Gow
2019-12-02 21:09       ` SeongJae Park
2019-12-01 23:25 ` [PATCH 3/6] kunit: Remove duplicated defconfig creation SeongJae Park
2019-12-02 17:27   ` Brendan Higgins
2019-12-01 23:25 ` [PATCH 4/6] kunit: Create default config in 'build_dir' SeongJae Park
2019-12-03  6:40   ` Brendan Higgins
2019-12-03  8:28     ` SeongJae Park
2019-12-01 23:25 ` [PATCH 5/6] kunit: Place 'test.log' under the 'build_dir' SeongJae Park
2019-12-03  6:48   ` Brendan Higgins
2019-12-01 23:25 ` [PATCH 6/6] kunit: Rename 'kunitconfig' to '.kunitconfig' SeongJae Park
2019-12-03  7:00 ` Brendan Higgins [this message]
2019-12-03  7:10   ` [PATCH 0/6] Fix nits in the kunit SeongJae Park
2019-12-03  8:25     ` SeongJae Park
2019-12-03 17:45       ` Brendan Higgins
2019-12-03 18:10         ` SeongJae Park
2019-12-03 22:35           ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203070025.GA4206@google.com \
    --to=brendanhiggins@google.com \
    --cc=corbet@lwn.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=sj38.park@gmail.com \
    --cc=sjpark@amazon.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.