From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF31C432C0 for ; Tue, 3 Dec 2019 07:03:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 445F320656 for ; Tue, 3 Dec 2019 07:03:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XfzhAjBE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="E3kueX+7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 445F320656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XCO64G8pr8Vidlp8e7AwkpswbGqgPDDkyPpWReY7s4Q=; b=XfzhAjBEZ3IWlu yONrI7ygMS+RQbnysHD4PsecIzms3htWo3s+f9fD4iGKeU3eZQC+VhLtXW/tpu3iDQQEFWVshdyx7 wjFugfP6Muf93MPK3vYZh0VpSFoRFR7mIvnQ44bsK27+saXSTVR/qr0QxbkoVLxWRjbIatbOduoT1 bw1tmDcxB9N0kE20YAxHduXQsgNyCp8h9KJzObRJxltx/SoX78ZaaQj6o2Tm2yl7HIQfXqjaoDGcK 39mrZmDXVexFsGMTafI3P2ZGSqEVMnvKZr+MAEmUoV463v5O/ugwR10E1QyqgpplZCILZwArR5yiU Tg5QzwgeEzkER0cDG5Rw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2DG-0001fy-Eo; Tue, 03 Dec 2019 07:03:10 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2D6-0001Y8-8b; Tue, 03 Dec 2019 07:03:04 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DCEFE309; Tue, 3 Dec 2019 08:02:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575356577; bh=BHGcClPJ8faRIFKK7GdcaZ3ZNqYB59soqjub02MQB1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E3kueX+7poUsLlLNHNb8tDRtAIJFMNynguFfEhRjHD8V/rg8SOIyTvGI64Sm/v7sW kRat1924btOO2rZxPhXW1Fv6jz6Q2UvxV3F3RAYHjBZjx27fOnvFuVje9e9COANAEw Z4e9gqTJkCwCprwCs08uymK0XroFud5phDqLqJFY= Date: Tue, 3 Dec 2019 09:02:49 +0200 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 07/26] drm/panel: remove get_timings Message-ID: <20191203070249.GG4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-8-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191202193230.21310-8-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_230300_594050_274123E2 X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:11PM +0100, Sam Ravnborg wrote: > There was no users - so remove it. > The callback was implemented in two drivers - deleted. This looks good to me, so Reviewed-by: Laurent Pinchart but I'll let Thierry decide if he prefers keeping it. > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Laurent Pinchart > Cc: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 18 ------------------ > drivers/gpu/drm/panel/panel-simple.c | 18 ------------------ > include/drm/drm_panel.h | 9 --------- > 3 files changed, 45 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > index b878930b17e4..3bcba64235c4 100644 > --- a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > +++ b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > @@ -217,30 +217,12 @@ static int seiko_panel_get_modes(struct drm_panel *panel, > return seiko_panel_get_fixed_modes(p, connector); > } > > -static int seiko_panel_get_timings(struct drm_panel *panel, > - unsigned int num_timings, > - struct display_timing *timings) > -{ > - struct seiko_panel *p = to_seiko_panel(panel); > - unsigned int i; > - > - if (p->desc->num_timings < num_timings) > - num_timings = p->desc->num_timings; > - > - if (timings) > - for (i = 0; i < num_timings; i++) > - timings[i] = p->desc->timings[i]; > - > - return p->desc->num_timings; > -} > - > static const struct drm_panel_funcs seiko_panel_funcs = { > .disable = seiko_panel_disable, > .unprepare = seiko_panel_unprepare, > .prepare = seiko_panel_prepare, > .enable = seiko_panel_enable, > .get_modes = seiko_panel_get_modes, > - .get_timings = seiko_panel_get_timings, > }; > > static int seiko_panel_probe(struct device *dev, > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index d6299fe6d276..e225791a6fb2 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -326,30 +326,12 @@ static int panel_simple_get_modes(struct drm_panel *panel, > return num; > } > > -static int panel_simple_get_timings(struct drm_panel *panel, > - unsigned int num_timings, > - struct display_timing *timings) > -{ > - struct panel_simple *p = to_panel_simple(panel); > - unsigned int i; > - > - if (p->desc->num_timings < num_timings) > - num_timings = p->desc->num_timings; > - > - if (timings) > - for (i = 0; i < num_timings; i++) > - timings[i] = p->desc->timings[i]; > - > - return p->desc->num_timings; > -} > - > static const struct drm_panel_funcs panel_simple_funcs = { > .disable = panel_simple_disable, > .unprepare = panel_simple_unprepare, > .prepare = panel_simple_prepare, > .enable = panel_simple_enable, > .get_modes = panel_simple_get_modes, > - .get_timings = panel_simple_get_timings, > }; > > #define PANEL_SIMPLE_BOUNDS_CHECK(to_check, bounds, field) \ > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index 4fd61cb9eb93..c4e82b9ce586 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -102,15 +102,6 @@ struct drm_panel_funcs { > */ > int (*get_modes)(struct drm_panel *panel, > struct drm_connector *connector); > - > - /** > - * @get_timings: > - * > - * Copy display timings into the provided array and return > - * the number of display timings available. > - */ > - int (*get_timings)(struct drm_panel *panel, unsigned int num_timings, > - struct display_timing *timings); > }; > > /** -- Regards, Laurent Pinchart _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v1 07/26] drm/panel: remove get_timings Date: Tue, 3 Dec 2019 09:02:49 +0200 Message-ID: <20191203070249.GG4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-8-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191202193230.21310-8-sam@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sam Ravnborg Cc: Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Thierry Reding , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon List-Id: linux-rockchip.vger.kernel.org SGkgU2FtLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBNb24sIERlYyAwMiwgMjAxOSBh dCAwODozMjoxMVBNICswMTAwLCBTYW0gUmF2bmJvcmcgd3JvdGU6Cj4gVGhlcmUgd2FzIG5vIHVz ZXJzIC0gc28gcmVtb3ZlIGl0Lgo+IFRoZSBjYWxsYmFjayB3YXMgaW1wbGVtZW50ZWQgaW4gdHdv IGRyaXZlcnMgLSBkZWxldGVkLgoKVGhpcyBsb29rcyBnb29kIHRvIG1lLCBzbwoKUmV2aWV3ZWQt Ynk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4K CmJ1dCBJJ2xsIGxldCBUaGllcnJ5IGRlY2lkZSBpZiBoZSBwcmVmZXJzIGtlZXBpbmcgaXQuCgo+ IFNpZ25lZC1vZmYtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KPiBDYzogVGhp ZXJyeSBSZWRpbmcgPHRoaWVycnkucmVkaW5nQGdtYWlsLmNvbT4KPiBDYzogTGF1cmVudCBQaW5j aGFydCA8TGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IENjOiBTYW0gUmF2bmJv cmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1heGltZSBSaXBhcmQgPG1yaXBhcmRAa2Vy bmVsLm9yZz4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5l bC9wYW5lbC1zZWlrby00M3d2ZjFnLmMgfCAxOCAtLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVy cy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jICAgICAgICB8IDE4IC0tLS0tLS0tLS0tLS0t LS0tLQo+ICBpbmNsdWRlL2RybS9kcm1fcGFuZWwuaCAgICAgICAgICAgICAgICAgICAgIHwgIDkg LS0tLS0tLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgNDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zZWlrby00M3d2ZjFnLmMgYi9kcml2 ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2Vpa28tNDN3dmYxZy5jCj4gaW5kZXggYjg3ODkzMGIx N2U0Li4zYmNiYTY0MjM1YzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3Bh bmVsLXNlaWtvLTQzd3ZmMWcuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1z ZWlrby00M3d2ZjFnLmMKPiBAQCAtMjE3LDMwICsyMTcsMTIgQEAgc3RhdGljIGludCBzZWlrb19w YW5lbF9nZXRfbW9kZXMoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwsCj4gIAlyZXR1cm4gc2Vpa29f cGFuZWxfZ2V0X2ZpeGVkX21vZGVzKHAsIGNvbm5lY3Rvcik7Cj4gIH0KPiAgCj4gLXN0YXRpYyBp bnQgc2Vpa29fcGFuZWxfZ2V0X3RpbWluZ3Moc3RydWN0IGRybV9wYW5lbCAqcGFuZWwsCj4gLQkJ CQkgICAgdW5zaWduZWQgaW50IG51bV90aW1pbmdzLAo+IC0JCQkJICAgIHN0cnVjdCBkaXNwbGF5 X3RpbWluZyAqdGltaW5ncykKPiAtewo+IC0Jc3RydWN0IHNlaWtvX3BhbmVsICpwID0gdG9fc2Vp a29fcGFuZWwocGFuZWwpOwo+IC0JdW5zaWduZWQgaW50IGk7Cj4gLQo+IC0JaWYgKHAtPmRlc2Mt Pm51bV90aW1pbmdzIDwgbnVtX3RpbWluZ3MpCj4gLQkJbnVtX3RpbWluZ3MgPSBwLT5kZXNjLT5u dW1fdGltaW5nczsKPiAtCj4gLQlpZiAodGltaW5ncykKPiAtCQlmb3IgKGkgPSAwOyBpIDwgbnVt X3RpbWluZ3M7IGkrKykKPiAtCQkJdGltaW5nc1tpXSA9IHAtPmRlc2MtPnRpbWluZ3NbaV07Cj4g LQo+IC0JcmV0dXJuIHAtPmRlc2MtPm51bV90aW1pbmdzOwo+IC19Cj4gLQo+ICBzdGF0aWMgY29u c3Qgc3RydWN0IGRybV9wYW5lbF9mdW5jcyBzZWlrb19wYW5lbF9mdW5jcyA9IHsKPiAgCS5kaXNh YmxlID0gc2Vpa29fcGFuZWxfZGlzYWJsZSwKPiAgCS51bnByZXBhcmUgPSBzZWlrb19wYW5lbF91 bnByZXBhcmUsCj4gIAkucHJlcGFyZSA9IHNlaWtvX3BhbmVsX3ByZXBhcmUsCj4gIAkuZW5hYmxl ID0gc2Vpa29fcGFuZWxfZW5hYmxlLAo+ICAJLmdldF9tb2RlcyA9IHNlaWtvX3BhbmVsX2dldF9t b2RlcywKPiAtCS5nZXRfdGltaW5ncyA9IHNlaWtvX3BhbmVsX2dldF90aW1pbmdzLAo+ICB9Owo+ ICAKPiAgc3RhdGljIGludCBzZWlrb19wYW5lbF9wcm9iZShzdHJ1Y3QgZGV2aWNlICpkZXYsCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYyBiL2RyaXZl cnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+IGluZGV4IGQ2Mjk5ZmU2ZDI3Ni4uZTIy NTc5MWE2ZmIyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1w bGUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+IEBAIC0z MjYsMzAgKzMyNiwxMiBAQCBzdGF0aWMgaW50IHBhbmVsX3NpbXBsZV9nZXRfbW9kZXMoc3RydWN0 IGRybV9wYW5lbCAqcGFuZWwsCj4gIAlyZXR1cm4gbnVtOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50 IHBhbmVsX3NpbXBsZV9nZXRfdGltaW5ncyhzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCwKPiAtCQkJ CSAgICB1bnNpZ25lZCBpbnQgbnVtX3RpbWluZ3MsCj4gLQkJCQkgICAgc3RydWN0IGRpc3BsYXlf dGltaW5nICp0aW1pbmdzKQo+IC17Cj4gLQlzdHJ1Y3QgcGFuZWxfc2ltcGxlICpwID0gdG9fcGFu ZWxfc2ltcGxlKHBhbmVsKTsKPiAtCXVuc2lnbmVkIGludCBpOwo+IC0KPiAtCWlmIChwLT5kZXNj LT5udW1fdGltaW5ncyA8IG51bV90aW1pbmdzKQo+IC0JCW51bV90aW1pbmdzID0gcC0+ZGVzYy0+ bnVtX3RpbWluZ3M7Cj4gLQo+IC0JaWYgKHRpbWluZ3MpCj4gLQkJZm9yIChpID0gMDsgaSA8IG51 bV90aW1pbmdzOyBpKyspCj4gLQkJCXRpbWluZ3NbaV0gPSBwLT5kZXNjLT50aW1pbmdzW2ldOwo+ IC0KPiAtCXJldHVybiBwLT5kZXNjLT5udW1fdGltaW5nczsKPiAtfQo+IC0KPiAgc3RhdGljIGNv bnN0IHN0cnVjdCBkcm1fcGFuZWxfZnVuY3MgcGFuZWxfc2ltcGxlX2Z1bmNzID0gewo+ICAJLmRp c2FibGUgPSBwYW5lbF9zaW1wbGVfZGlzYWJsZSwKPiAgCS51bnByZXBhcmUgPSBwYW5lbF9zaW1w bGVfdW5wcmVwYXJlLAo+ICAJLnByZXBhcmUgPSBwYW5lbF9zaW1wbGVfcHJlcGFyZSwKPiAgCS5l bmFibGUgPSBwYW5lbF9zaW1wbGVfZW5hYmxlLAo+ICAJLmdldF9tb2RlcyA9IHBhbmVsX3NpbXBs ZV9nZXRfbW9kZXMsCj4gLQkuZ2V0X3RpbWluZ3MgPSBwYW5lbF9zaW1wbGVfZ2V0X3RpbWluZ3Ms Cj4gIH07Cj4gIAo+ICAjZGVmaW5lIFBBTkVMX1NJTVBMRV9CT1VORFNfQ0hFQ0sodG9fY2hlY2ss IGJvdW5kcywgZmllbGQpIFwKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX3BhbmVsLmgg Yi9pbmNsdWRlL2RybS9kcm1fcGFuZWwuaAo+IGluZGV4IDRmZDYxY2I5ZWI5My4uYzRlODJiOWNl NTg2IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9wYW5lbC5oCj4gKysrIGIvaW5jbHVk ZS9kcm0vZHJtX3BhbmVsLmgKPiBAQCAtMTAyLDE1ICsxMDIsNiBAQCBzdHJ1Y3QgZHJtX3BhbmVs X2Z1bmNzIHsKPiAgCSAqLwo+ICAJaW50ICgqZ2V0X21vZGVzKShzdHJ1Y3QgZHJtX3BhbmVsICpw YW5lbCwKPiAgCQkJIHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpOwo+IC0KPiAtCS8q Kgo+IC0JICogQGdldF90aW1pbmdzOgo+IC0JICoKPiAtCSAqIENvcHkgZGlzcGxheSB0aW1pbmdz IGludG8gdGhlIHByb3ZpZGVkIGFycmF5IGFuZCByZXR1cm4KPiAtCSAqIHRoZSBudW1iZXIgb2Yg ZGlzcGxheSB0aW1pbmdzIGF2YWlsYWJsZS4KPiAtCSAqLwo+IC0JaW50ICgqZ2V0X3RpbWluZ3Mp KHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsLCB1bnNpZ25lZCBpbnQgbnVtX3RpbWluZ3MsCj4gLQkJ CSAgIHN0cnVjdCBkaXNwbGF5X3RpbWluZyAqdGltaW5ncyk7Cj4gIH07Cj4gIAo+ICAvKioKCi0t IApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78EABC43215 for ; Tue, 3 Dec 2019 07:03:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F55E2073B for ; Tue, 3 Dec 2019 07:03:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="E3kueX+7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727340AbfLCHDA (ORCPT ); Tue, 3 Dec 2019 02:03:00 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:56844 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727282AbfLCHDA (ORCPT ); Tue, 3 Dec 2019 02:03:00 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DCEFE309; Tue, 3 Dec 2019 08:02:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575356577; bh=BHGcClPJ8faRIFKK7GdcaZ3ZNqYB59soqjub02MQB1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E3kueX+7poUsLlLNHNb8tDRtAIJFMNynguFfEhRjHD8V/rg8SOIyTvGI64Sm/v7sW kRat1924btOO2rZxPhXW1Fv6jz6Q2UvxV3F3RAYHjBZjx27fOnvFuVje9e9COANAEw Z4e9gqTJkCwCprwCs08uymK0XroFud5phDqLqJFY= Date: Tue, 3 Dec 2019 09:02:49 +0200 From: Laurent Pinchart To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Thierry Reding , Abhinav Kumar , Andrzej Hajda , Benjamin Gaignard , Boris Brezillon , Daniel Vetter , David Airlie , Jagan Teki , Jitao Shi , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Neil Armstrong , NXP Linux Team , Pengutronix Kernel Team , Purism Kernel Team , Sean Paul , Stefan Agner , Tomi Valkeinen Subject: Re: [PATCH v1 07/26] drm/panel: remove get_timings Message-ID: <20191203070249.GG4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-8-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191202193230.21310-8-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:11PM +0100, Sam Ravnborg wrote: > There was no users - so remove it. > The callback was implemented in two drivers - deleted. This looks good to me, so Reviewed-by: Laurent Pinchart but I'll let Thierry decide if he prefers keeping it. > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Laurent Pinchart > Cc: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 18 ------------------ > drivers/gpu/drm/panel/panel-simple.c | 18 ------------------ > include/drm/drm_panel.h | 9 --------- > 3 files changed, 45 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > index b878930b17e4..3bcba64235c4 100644 > --- a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > +++ b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > @@ -217,30 +217,12 @@ static int seiko_panel_get_modes(struct drm_panel *panel, > return seiko_panel_get_fixed_modes(p, connector); > } > > -static int seiko_panel_get_timings(struct drm_panel *panel, > - unsigned int num_timings, > - struct display_timing *timings) > -{ > - struct seiko_panel *p = to_seiko_panel(panel); > - unsigned int i; > - > - if (p->desc->num_timings < num_timings) > - num_timings = p->desc->num_timings; > - > - if (timings) > - for (i = 0; i < num_timings; i++) > - timings[i] = p->desc->timings[i]; > - > - return p->desc->num_timings; > -} > - > static const struct drm_panel_funcs seiko_panel_funcs = { > .disable = seiko_panel_disable, > .unprepare = seiko_panel_unprepare, > .prepare = seiko_panel_prepare, > .enable = seiko_panel_enable, > .get_modes = seiko_panel_get_modes, > - .get_timings = seiko_panel_get_timings, > }; > > static int seiko_panel_probe(struct device *dev, > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index d6299fe6d276..e225791a6fb2 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -326,30 +326,12 @@ static int panel_simple_get_modes(struct drm_panel *panel, > return num; > } > > -static int panel_simple_get_timings(struct drm_panel *panel, > - unsigned int num_timings, > - struct display_timing *timings) > -{ > - struct panel_simple *p = to_panel_simple(panel); > - unsigned int i; > - > - if (p->desc->num_timings < num_timings) > - num_timings = p->desc->num_timings; > - > - if (timings) > - for (i = 0; i < num_timings; i++) > - timings[i] = p->desc->timings[i]; > - > - return p->desc->num_timings; > -} > - > static const struct drm_panel_funcs panel_simple_funcs = { > .disable = panel_simple_disable, > .unprepare = panel_simple_unprepare, > .prepare = panel_simple_prepare, > .enable = panel_simple_enable, > .get_modes = panel_simple_get_modes, > - .get_timings = panel_simple_get_timings, > }; > > #define PANEL_SIMPLE_BOUNDS_CHECK(to_check, bounds, field) \ > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index 4fd61cb9eb93..c4e82b9ce586 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -102,15 +102,6 @@ struct drm_panel_funcs { > */ > int (*get_modes)(struct drm_panel *panel, > struct drm_connector *connector); > - > - /** > - * @get_timings: > - * > - * Copy display timings into the provided array and return > - * the number of display timings available. > - */ > - int (*get_timings)(struct drm_panel *panel, unsigned int num_timings, > - struct display_timing *timings); > }; > > /** -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B943C432C3 for ; Tue, 3 Dec 2019 07:03:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 015C020656 for ; Tue, 3 Dec 2019 07:03:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YRW1+/Zy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="E3kueX+7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 015C020656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Be9aH/4UjOLFPjyxCGoN+FqUGc1JS0qVISUTyWpneI=; b=YRW1+/Zyh0/zQ2 vWklPiMFavB6rZzq9OQ4We7ocX/PtvEcpLfA1+ns9SJBRvqRo4bjIdo1iWM4CCF4RPphGkDyOcI19 UOPmXXBpQjCBEH+UYqYaoT6KRPEqQSRabQDQNTBGVz9UK/kMZzxkeDaLKXsz/vwbbpduD1t3Fx6ra AStqmlH8id8TQJArBDC8tDHyy9HPnn+IUkK9khC7MaNNXoeM7wURRQeZLQ6HiZY1y314c53mSSW7K xmdW2OfFcrkm+hfi9yxKiE7Y2rQq2xbIdRHJo25ilu1Y6b7uOVDvBsU7U071xAQs9WWzCkZqlitk3 KEgAnhlAZVtmoC26APrg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2DB-0001Ym-LV; Tue, 03 Dec 2019 07:03:05 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2D6-0001Y8-8b; Tue, 03 Dec 2019 07:03:04 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DCEFE309; Tue, 3 Dec 2019 08:02:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575356577; bh=BHGcClPJ8faRIFKK7GdcaZ3ZNqYB59soqjub02MQB1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E3kueX+7poUsLlLNHNb8tDRtAIJFMNynguFfEhRjHD8V/rg8SOIyTvGI64Sm/v7sW kRat1924btOO2rZxPhXW1Fv6jz6Q2UvxV3F3RAYHjBZjx27fOnvFuVje9e9COANAEw Z4e9gqTJkCwCprwCs08uymK0XroFud5phDqLqJFY= Date: Tue, 3 Dec 2019 09:02:49 +0200 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 07/26] drm/panel: remove get_timings Message-ID: <20191203070249.GG4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-8-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191202193230.21310-8-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_230300_594050_274123E2 X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:11PM +0100, Sam Ravnborg wrote: > There was no users - so remove it. > The callback was implemented in two drivers - deleted. This looks good to me, so Reviewed-by: Laurent Pinchart but I'll let Thierry decide if he prefers keeping it. > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Laurent Pinchart > Cc: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 18 ------------------ > drivers/gpu/drm/panel/panel-simple.c | 18 ------------------ > include/drm/drm_panel.h | 9 --------- > 3 files changed, 45 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > index b878930b17e4..3bcba64235c4 100644 > --- a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > +++ b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > @@ -217,30 +217,12 @@ static int seiko_panel_get_modes(struct drm_panel *panel, > return seiko_panel_get_fixed_modes(p, connector); > } > > -static int seiko_panel_get_timings(struct drm_panel *panel, > - unsigned int num_timings, > - struct display_timing *timings) > -{ > - struct seiko_panel *p = to_seiko_panel(panel); > - unsigned int i; > - > - if (p->desc->num_timings < num_timings) > - num_timings = p->desc->num_timings; > - > - if (timings) > - for (i = 0; i < num_timings; i++) > - timings[i] = p->desc->timings[i]; > - > - return p->desc->num_timings; > -} > - > static const struct drm_panel_funcs seiko_panel_funcs = { > .disable = seiko_panel_disable, > .unprepare = seiko_panel_unprepare, > .prepare = seiko_panel_prepare, > .enable = seiko_panel_enable, > .get_modes = seiko_panel_get_modes, > - .get_timings = seiko_panel_get_timings, > }; > > static int seiko_panel_probe(struct device *dev, > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index d6299fe6d276..e225791a6fb2 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -326,30 +326,12 @@ static int panel_simple_get_modes(struct drm_panel *panel, > return num; > } > > -static int panel_simple_get_timings(struct drm_panel *panel, > - unsigned int num_timings, > - struct display_timing *timings) > -{ > - struct panel_simple *p = to_panel_simple(panel); > - unsigned int i; > - > - if (p->desc->num_timings < num_timings) > - num_timings = p->desc->num_timings; > - > - if (timings) > - for (i = 0; i < num_timings; i++) > - timings[i] = p->desc->timings[i]; > - > - return p->desc->num_timings; > -} > - > static const struct drm_panel_funcs panel_simple_funcs = { > .disable = panel_simple_disable, > .unprepare = panel_simple_unprepare, > .prepare = panel_simple_prepare, > .enable = panel_simple_enable, > .get_modes = panel_simple_get_modes, > - .get_timings = panel_simple_get_timings, > }; > > #define PANEL_SIMPLE_BOUNDS_CHECK(to_check, bounds, field) \ > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index 4fd61cb9eb93..c4e82b9ce586 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -102,15 +102,6 @@ struct drm_panel_funcs { > */ > int (*get_modes)(struct drm_panel *panel, > struct drm_connector *connector); > - > - /** > - * @get_timings: > - * > - * Copy display timings into the provided array and return > - * the number of display timings available. > - */ > - int (*get_timings)(struct drm_panel *panel, unsigned int num_timings, > - struct display_timing *timings); > }; > > /** -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel